From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1ZsQBP-0004pu-9J
	for mharc-grub-devel@gnu.org; Sat, 31 Oct 2015 03:02:35 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54102)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arvidjaar@gmail.com>) id 1ZsQBN-0004oX-80
	for grub-devel@gnu.org; Sat, 31 Oct 2015 03:02:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arvidjaar@gmail.com>) id 1ZsQBK-0008Nr-1u
	for grub-devel@gnu.org; Sat, 31 Oct 2015 03:02:33 -0400
Received: from mail-lb0-x232.google.com ([2a00:1450:4010:c04::232]:36722)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arvidjaar@gmail.com>) id 1ZsQBJ-0008NX-Pr
	for grub-devel@gnu.org; Sat, 31 Oct 2015 03:02:29 -0400
Received: by lbjm5 with SMTP id m5so60914912lbj.3
	for <grub-devel@gnu.org>; Sat, 31 Oct 2015 00:02:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=to:from:subject:message-id:date:user-agent:mime-version
	:content-type:content-transfer-encoding;
	bh=/DrhoMXM1hTaKJ1lQF6bYGwJFyCsoXUfi809seK5nBs=;
	b=U5GbvfGl0+MsyqDngpVZEmPZ2MV9ZaK/dqxozZCtLVTG28+Zak6Rh1d+QGUbyXsblt
	UNB2u0I+eT31lR5f5/L8uYT6pbd6+x4+KP3uNMD6gXCxNFLWYq3U5mRpkAsowVOeXD0G
	5ze3RRmYzngJiv/l0OIenqzjMEpq/1fFmXemMLJAGcokBueSBeChNTKYVgq58BWKY8YQ
	6F/Eu1F7V/kvY161ReF8Wa6sT2+qWuRAbR23PkkxrXak0WSkEtoSJAn+TMxXQ77EjvxH
	/uZ8AHJMUG2e6vcZVbSTidTqk4hfXDyHTjT3Twu/d6a7iPb8r57M5lJ27j6p6neQo6Vh
	ZjCg==
X-Received: by 10.112.35.196 with SMTP id k4mr5683849lbj.3.1446274949016;
	Sat, 31 Oct 2015 00:02:29 -0700 (PDT)
Received: from [192.168.1.41] (ppp91-76-25-247.pppoe.mtu-net.ru.
	[91.76.25.247]) by smtp.gmail.com with ESMTPSA id
	r70sm1938193lfd.24.2015.10.31.00.02.28 for <grub-devel@gnu.org>
	(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
	Sat, 31 Oct 2015 00:02:28 -0700 (PDT)
To: The development of GRUB 2 <grub-devel@gnu.org>
From: Andrei Borzenkov <arvidjaar@gmail.com>
Subject: modules size in mkimage
Message-ID: <56346783.20504@gmail.com>
Date: Sat, 31 Oct 2015 10:02:27 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
	Thunderbird/38.3.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address
	(bad octet value).
X-Received-From: 2a00:1450:4010:c04::232
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: The development of GNU GRUB <grub-devel@gnu.org>
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 31 Oct 2015 07:02:34 -0000

mkimage sets module size to aligned value; later it is used to actually 
process it which /may/ lead to inconsistency (as any comparison is 
against stored aligned size, not actual module size).

Same applies to all other embedded types actually. The only one that 
does it right is pubkey.

Just to make sure I do not miss something obvious; otherwise I'll make a 
patch.