From: Tim Gardner <tim.gardner@canonical.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Jayamohan Kallickal <jayamohan.kallickal@avagotech.com>,
Minh Tran <minh.tran@avagotech.com>,
John Soni Jose <sony.john-n@avagotech.com>,
"James E.J. Bottomley" <JBottomley@odin.com>
Subject: Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check
Date: Sun, 1 Nov 2015 08:43:59 -0700 [thread overview]
Message-ID: <5636333F.7000903@canonical.com> (raw)
In-Reply-To: <mqdbnbgxec5.fsf@linux-x5ow.site>
On 10/30/2015 02:59 PM, Johannes Thumshirn wrote:
> Hi Tim,
> tim.gardner@canonical.com writes:
>
>> From: Tim Gardner <tim.gardner@canonical.com>
>>
>> drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous':
>> drivers/scsi/be2iscsi/be_main.c:3187:18: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
>> WARN_ON(!length > 0);
>>
>> gcc version 5.2.1
>
> This patch (or similar) was already posted on Oct 1 by Joel Stanley.
> See http://comments.gmane.org/gmane.linux.scsi/105462
>
> Thanks,
> Johannes
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
Mechanical application of prarens makes that expression more complicated
then it needs to be. It is, after all, an unsigned integer.
rtg
--
Tim Gardner tim.gardner@canonical.com
next prev parent reply other threads:[~2015-11-01 15:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 18:22 [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check tim.gardner
2015-10-30 19:28 ` Manoj Kumar
2015-10-30 20:59 ` Johannes Thumshirn
2015-11-01 15:43 ` Tim Gardner [this message]
2015-11-12 1:28 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5636333F.7000903@canonical.com \
--to=tim.gardner@canonical.com \
--cc=JBottomley@odin.com \
--cc=jayamohan.kallickal@avagotech.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=minh.tran@avagotech.com \
--cc=sony.john-n@avagotech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.