From: Hans Verkuil <hverkuil@xs4all.nl>
To: Ran Shalit <ranshalit@gmail.com>
Cc: linux-media@vger.kernel.org
Subject: Re: videobuf & read/write operation
Date: Sun, 01 Nov 2015 22:48:34 +0100 [thread overview]
Message-ID: <563688B2.1080006@xs4all.nl> (raw)
In-Reply-To: <CAJ2oMhJ9st3-Wcuv_Q69wf_cr6eoB4q_b5=1n2OgZmP9WTvdng@mail.gmail.com>
On 11/01/2015 09:13 PM, Ran Shalit wrote:
>> Don't use videobuf! Use videobuf2, just like the skeleton driver.
>>
>> The old videobuf framework is deprecated and you shouldn't use it as it is
>> horrible.
>>
>> Why on earth are you trying to use videobuf if the skeleton driver clearly
>> uses vb2?
>>
>
> Right,
> I now see that I was examining code which is quite old (2.6.37 from
> SDK I'm using).
>
> In case we only need read/write operation, do we still need to
> implement all videobuf2 APIs ?
vb2 only got merged in 2.6.39. For what kernel are you doing this? 2.6.37 is ancient.
Anyway, for read/write you implement exactly the same vb2 callbacks as for stream I/O.
Read/write is implemented in the vb2 framework on top of stream I/O.
Typically drivers will have to implement queue_setup, buf_queue and start/stop_streaming
at minimum. The wait_prepare/finish callbacks are also needed, but you can typically use
the vb2_ops_wait_prepare/finish helper functions for that. Again, follow what the skeleton
driver does.
Regards,
Hans
>
>
> Regards,
> Ran
>
>
>>
>>> When the documentation refers to " I/O stream" , does it also include
>>> the read/write operation or only streaming I/O method ?
>>>
>>> In case I am using only read/write, do I need to implement all these 4 APIs:
>>>
>>> struct videobuf_queue_ops {
>>> int (*buf_setup)(struct videobuf_queue *q,
>>> unsigned int *count, unsigned int *size);
>>> int (*buf_prepare)(struct videobuf_queue *q,
>>> struct videobuf_buffer *vb,
>>> enum v4l2_field field);
>>> void (*buf_queue)(struct videobuf_queue *q,
>>> struct videobuf_buffer *vb);
>>> void (*buf_release)(struct videobuf_queue *q,
>>> struct videobuf_buffer *vb);
>>> };
>>>
>>> Are these APIs relevant for both read/write and streaminf I/O ?
>>>
>>> Best Regards,
>>> Ran
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>
>>
prev parent reply other threads:[~2015-11-01 21:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-01 19:21 videobuf & read/write operation Ran Shalit
2015-11-01 19:39 ` Hans Verkuil
2015-11-01 20:13 ` Ran Shalit
2015-11-01 21:48 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563688B2.1080006@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=ranshalit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.