From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout4.w1.samsung.com (mailout4.w1.samsung.com. [210.118.77.14]) by gmr-mx.google.com with ESMTPS id sm2si1560184pab.0.2015.11.01.15.46.30 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sun, 01 Nov 2015 15:46:30 -0800 (PST) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NX5009XEU1E8U40@mailout4.w1.samsung.com> for rtc-linux@googlegroups.com; Sun, 01 Nov 2015 23:46:26 +0000 (GMT) Subject: [rtc-linux] Re: [PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC To: Alexandre Belloni , Alim Akhtar References: <1446186334-16510-1-git-send-email-alim.akhtar@samsung.com> <1446186334-16510-5-git-send-email-alim.akhtar@samsung.com> <20151101174048.GD22331@piout.net> Cc: lee.jones@linaro.org, broonie@kernel.org, linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski Message-id: <5636A44D.4090908@samsung.com> Date: Mon, 02 Nov 2015 08:46:21 +0900 MIME-version: 1.0 In-reply-to: <20151101174048.GD22331@piout.net> Content-type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 02.11.2015 02:40, Alexandre Belloni wrote: > On 30/10/2015 at 11:55:34 +0530, Alim Akhtar wrote : >> RTC found in s2mps15 is almost same as one found on s2mps13 >> with few differences in RTC_UPDATE register fields, like: >> 1> Bit[4] and Bit[1] are reversed >> - On s2mps13 >> WUDR -> bit[4], AUDR -> bit[1] >> - On s2mps15 >> WUDR -> bit[1], AUDR -> bit[4] >> 2> In case of s2mps13, for alarm register, need to set both >> WDUR and ADUR high, whereas for s2mps15 only set AUDR to high. >> 3> On s2mps15, WUDR, RUDR and AUDR functions should never be used >> at the same time. >> >> This patch add required changes to enable s2mps15 rtc timer. >> >> Cc: Alexandre Belloni >> Signed-off-by: Alim Akhtar >> --- >> drivers/rtc/rtc-s5m.c | 37 +++++++++++++++++++++++++++++++++---- >> include/linux/mfd/samsung/rtc.h | 2 ++ >> 2 files changed, 35 insertions(+), 4 deletions(-) >> > Applied after fixing the small alignment issue, thanks. > I think you cannot apply it directly because it depends on headers from patch 2/4. It won't build. Best regards, Krzysztof -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC Date: Mon, 02 Nov 2015 08:46:21 +0900 Message-ID: <5636A44D.4090908@samsung.com> References: <1446186334-16510-1-git-send-email-alim.akhtar@samsung.com> <1446186334-16510-5-git-send-email-alim.akhtar@samsung.com> <20151101174048.GD22331@piout.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.w1.samsung.com ([210.118.77.14]:61454 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753215AbbKAXq3 (ORCPT ); Sun, 1 Nov 2015 18:46:29 -0500 In-reply-to: <20151101174048.GD22331@piout.net> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Alexandre Belloni , Alim Akhtar Cc: lee.jones@linaro.org, broonie@kernel.org, linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org On 02.11.2015 02:40, Alexandre Belloni wrote: > On 30/10/2015 at 11:55:34 +0530, Alim Akhtar wrote : >> RTC found in s2mps15 is almost same as one found on s2mps13 >> with few differences in RTC_UPDATE register fields, like: >> 1> Bit[4] and Bit[1] are reversed >> - On s2mps13 >> WUDR -> bit[4], AUDR -> bit[1] >> - On s2mps15 >> WUDR -> bit[1], AUDR -> bit[4] >> 2> In case of s2mps13, for alarm register, need to set both >> WDUR and ADUR high, whereas for s2mps15 only set AUDR to high. >> 3> On s2mps15, WUDR, RUDR and AUDR functions should never be used >> at the same time. >> >> This patch add required changes to enable s2mps15 rtc timer. >> >> Cc: Alexandre Belloni >> Signed-off-by: Alim Akhtar >> --- >> drivers/rtc/rtc-s5m.c | 37 +++++++++++++++++++++++++++++++++---- >> include/linux/mfd/samsung/rtc.h | 2 ++ >> 2 files changed, 35 insertions(+), 4 deletions(-) >> > Applied after fixing the small alignment issue, thanks. > I think you cannot apply it directly because it depends on headers from patch 2/4. It won't build. Best regards, Krzysztof