From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [RFC v2 2/5] drm/dsi: Try to match non-DT dsi devices Date: Mon, 2 Nov 2015 10:56:37 +0530 Message-ID: <5636F40D.5090003@codeaurora.org> References: <1435641851-27295-1-git-send-email-architt@codeaurora.org> <1444123482-25579-1-git-send-email-architt@codeaurora.org> <1444123482-25579-3-git-send-email-architt@codeaurora.org> <563365A0.5000507@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <563365A0.5000507@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andrzej Hajda , dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, treding@nvidia.com List-Id: linux-arm-msm@vger.kernel.org CgpPbiAxMC8zMC8yMDE1IDA2OjEyIFBNLCBBbmRyemVqIEhhamRhIHdyb3RlOgo+IE9uIDEwLzA2 LzIwMTUgMTE6MjQgQU0sIEFyY2hpdCBUYW5lamEgd3JvdGU6Cj4+IEFkZCBhIGRldmljZSBuYW1l IGZpZWxkIGluIG1pcGlfZHNpX2RldmljZS4gVGhpcyBuYW1lIGlzIGRpZmZlcmVudCBmcm9tCj4+ IHRoZSBhY3R1YWwgZGV2IG5hbWUgKHdoaWNoIGlzIG9mIHRoZSBmb3JtYXQgImhvc3RuYW1lLnJl ZyIpLiBXaGVuIHRoZQo+PiBkZXZpY2UgaXMgY3JlYXRlZCB2aWEgRFQsIHRoaXMgbmFtZSBpcyBz ZXQgdG8gdGhlIG1vZGFsaWFzIHN0cmluZy4KPj4gSW4gdGhlIG5vbi1EVCBjYXNlLCB0aGUgZHJp dmVyIGNyZWF0aW5nIHRoZSBEU0kgZGV2aWNlIHByb3ZpZGVzIHRoZQo+PiBuYW1lIGJ5IHBvcHVs YXRpbmcgYSBmaWxlZCBpbiBtaXBpX2RzaV9kZXZpY2VfaW5mby4KPj4KPj4gTWF0Y2hpbmcgZm9y IERUIGNhc2Ugd291bGQgYmUgYXMgaXQgd2FzIGJlZm9yZS4gRm9yIHRoZSBub24tRFQgY2FzZSwK Pj4gd2UgY29tcGFyZSB0aGUgZGV2aWNlIGFuZCBkcml2ZXIgbmFtZXMuIE1hdGNoaW5nIGJ5IGNv bXBhcmluZyBkcml2ZXIgYW5kCj4+IGRldmljZSBuYW1lcyBpc24ndCB0aGUgYmVzdCB0aGluZyB0 byBkby4gSSdkIGFwcHJlY2lhdGUgc29tZSBzdWdnZXN0aW9ucwo+PiBoZXJlLgo+Pgo+PiBPdGhl ciBidXNlcyAobGlrZSBpMmMvc3BpKSBwZXJmb3JtIGEgbm9uLURUIG1hdGNoIGJ5IGNvbXBhcmlu ZyB0aGUKPj4gZGV2aWNlIG5hbWUgYW5kIGVudHJpZXMgaW4gdGhlIGRyaXZlcidzIGlkX3RhYmxl LiBUaGUgaWRfdGFibGUgc3RydWN0cwo+PiBmb3IgZGlmZmVyZW50IGJ1c2VzIGFyZSBkZWZpbmVk IGluICJpbmNsdWRlL2xpbnV4L21vZF9kZXZpY2V0YWJsZS5oIiwgSQo+PiBkaWRuJ3Qgd2FudCB0 byB0b3VjaCB0aGF0IGZvciBub3cuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IEFyY2hpdCBUYW5lamEg PGFyY2hpdHRAY29kZWF1cm9yYS5vcmc+Cj4gQmVzaWRlIHNtYWxsIGNvbW1lbnRzIGJlbG93Lgo+ Cj4gUmV2aWV3ZWQtYnk6IEFuZHJ6ZWogSGFqZGEgPGEuaGFqZGFAc2Ftc3VuZy5jb20+Cj4KPj4g LS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2RybV9taXBpX2RzaS5jIHwgMjkgKysrKysrKysrKysr KysrKysrKysrKysrKysrKy0KPj4gICBpbmNsdWRlL2RybS9kcm1fbWlwaV9kc2kuaCAgICAgfCAg OCArKysrKysrKwo+PiAgIDIgZmlsZXMgY2hhbmdlZCwgMzYgaW5zZXJ0aW9ucygrKSwgMSBkZWxl dGlvbigtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9taXBpX2RzaS5j IGIvZHJpdmVycy9ncHUvZHJtL2RybV9taXBpX2RzaS5jCj4+IGluZGV4IDI0NWVjZmUuLjQ2ZWU1 MTUgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fbWlwaV9kc2kuYwo+PiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vZHJtX21pcGlfZHNpLmMKPj4gQEAgLTQ1LDkgKzQ1LDMwIEBACj4+ ICAgICogc3Vic2V0IG9mIHRoZSBNSVBJIERDUyBjb21tYW5kIHNldC4KPj4gICAgKi8KPj4KPj4g K3N0YXRpYyBjb25zdCBzdHJ1Y3QgZGV2aWNlX3R5cGUgbWlwaV9kc2lfZGV2aWNlX3R5cGU7Cj4+ ICsKPj4gICBzdGF0aWMgaW50IG1pcGlfZHNpX2RldmljZV9tYXRjaChzdHJ1Y3QgZGV2aWNlICpk ZXYsIHN0cnVjdCBkZXZpY2VfZHJpdmVyICpkcnYpCj4+ICAgewo+PiAtCXJldHVybiBvZl9kcml2 ZXJfbWF0Y2hfZGV2aWNlKGRldiwgZHJ2KTsKPj4gKwlzdHJ1Y3QgbWlwaV9kc2lfZGV2aWNlICpk c2k7Cj4+ICsKPj4gKwlpZiAoZGV2LT50eXBlID09ICZtaXBpX2RzaV9kZXZpY2VfdHlwZSkKPj4g KwkJZHNpID0gdG9fbWlwaV9kc2lfZGV2aWNlKGRldik7Cj4+ICsJZWxzZQo+PiArCQlyZXR1cm4g MDsKPj4gKwo+PiArCS8qIEF0dGVtcHQgT0Ygc3R5bGUgbWF0Y2ggKi8KPj4gKwlpZiAob2ZfZHJp dmVyX21hdGNoX2RldmljZShkZXYsIGRydikpCj4+ICsJCXJldHVybiAxOwo+PiArCj4+ICsJLyoK Pj4gKwkgKiBUcnkgdG8gY29tcGFyZSBkc2kgZGV2aWNlIGFuZCBkcml2ZXIgbmFtZXMuIElmIHRo aXMgbWF0Y2hpbmcgYXBwcm9hY2gKPj4gKwkgKiBpc24ndCBzdHJvbmcsIHdlJ2QgcHJvYmFibHkg d2FudCB0aGUgZHNpIGRyaXZlcnMgdG8gcG9wdWxhdGUgdGhlCj4+ICsJICogaWRfdGFibGUgZmll bGQgYW5kIHVzZSB0aGF0IGluc3RlYWQKPj4gKwkgKi8KPj4gKwlpZiAoIXN0cmNtcChkc2ktPm5h bWUsIGRydi0+bmFtZSkpCj4+ICsJCXJldHVybiAxOwo+PiArCj4+ICsJcmV0dXJuIDA7Cj4+ICAg fQo+Pgo+PiAgIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZGV2X3BtX29wcyBtaXBpX2RzaV9kZXZpY2Vf cG1fb3BzID0gewo+PiBAQCAtMTI1LDYgKzE0Niw3IEBAIHN0cnVjdCBtaXBpX2RzaV9kZXZpY2Ug Km1pcGlfZHNpX2RldmljZV9uZXcoc3RydWN0IG1pcGlfZHNpX2hvc3QgKmhvc3QsCj4+ICAgCWRz aS0+ZGV2LnR5cGUgPSAmbWlwaV9kc2lfZGV2aWNlX3R5cGU7Cj4+ICAgCWRzaS0+ZGV2Lm9mX25v ZGUgPSBpbmZvLT5ub2RlOwo+PiAgIAlkc2ktPmNoYW5uZWwgPSBpbmZvLT5yZWc7Cj4+ICsJc3Ry bGNweShkc2ktPm5hbWUsIGluZm8tPm5hbWUsIHNpemVvZihkc2ktPm5hbWUpKTsKPj4KPj4gICAJ ZGV2X3NldF9uYW1lKCZkc2ktPmRldiwgIiVzLiVkIiwgZGV2X25hbWUoaG9zdC0+ZGV2KSwgaW5m by0+cmVnKTsKPj4KPj4gQEAgLTE0Nyw2ICsxNjksMTEgQEAgb2ZfbWlwaV9kc2lfZGV2aWNlX2Fk ZChzdHJ1Y3QgbWlwaV9kc2lfaG9zdCAqaG9zdCwgc3RydWN0IGRldmljZV9ub2RlICpub2RlKQo+ PiAgIAlpbnQgcmV0Owo+PiAgIAl1MzIgcmVnOwo+Pgo+PiArCWlmIChvZl9tb2RhbGlhc19ub2Rl KG5vZGUsIGluZm8ubmFtZSwgc2l6ZW9mKGluZm8ubmFtZSkpIDwgMCkgewo+PiArCQlkZXZfZXJy KGRldiwgIm1vZGFsaWFzIGZhaWx1cmUgb24gJXNcbiIsIG5vZGUtPmZ1bGxfbmFtZSk7Cj4+ICsJ CXJldHVybiBFUlJfUFRSKC1FSU5WQUwpOwo+PiArCX0KPj4gKwo+PiAgIAlyZXQgPSBvZl9wcm9w ZXJ0eV9yZWFkX3UzMihub2RlLCAicmVnIiwgJnJlZyk7Cj4+ICAgCWlmIChyZXQpIHsKPj4gICAJ CWRldl9lcnIoZGV2LCAiZGV2aWNlIG5vZGUgJXMgaGFzIG5vIHZhbGlkIHJlZyBwcm9wZXJ0eTog JWRcbiIsCj4+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2RybS9kcm1fbWlwaV9kc2kuaCBiL2luY2x1 ZGUvZHJtL2RybV9taXBpX2RzaS5oCj4+IGluZGV4IDkwZjRmM2MuLjkzZGVjN2IgMTAwNjQ0Cj4+ IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9taXBpX2RzaS5oCj4+ICsrKyBiL2luY2x1ZGUvZHJtL2Ry bV9taXBpX2RzaS5oCj4+IEBAIC0xMzksOCArMTM5LDExIEBAIGVudW0gbWlwaV9kc2lfcGl4ZWxf Zm9ybWF0IHsKPj4gICAJTUlQSV9EU0lfRk1UX1JHQjU2NSwKPj4gICB9Owo+Pgo+PiArI2RlZmlu ZSBEU0lfREVWX05BTUVfU0laRQkJMjAKPj4gKwo+PiAgIC8qKgo+PiAgICAqIHN0cnVjdCBtaXBp X2RzaV9kZXZpY2VfaW5mbyAtIHRlbXBsYXRlIGZvciBjcmVhdGluZyBhIG1pcGlfZHNpX2Rldmlj ZQo+PiArICogQG5hbWU6IG5hbWUgb2YgdGhlIGRzaSBwZXJpcGhlcmFsCj4+ICAgICogQHJlZzog RFNJIHZpcnR1YWwgY2hhbm5lbCBhc3NpZ25lZCB0byBwZXJpcGhlcmFsCj4+ICAgICogQG5vZGU6 IHBvaW50ZXIgdG8gT0YgZGV2aWNlIG5vZGUKPj4gICAgKgo+PiBAQCAtMTQ4LDE0ICsxNTEsMTcg QEAgZW51bSBtaXBpX2RzaV9waXhlbF9mb3JtYXQgewo+PiAgICAqIERTSSBkZXZpY2UKPj4gICAg Ki8KPj4gICBzdHJ1Y3QgbWlwaV9kc2lfZGV2aWNlX2luZm8gewo+PiArCWNoYXIgbmFtZVtEU0lf REVWX05BTUVfU0laRV07Cj4gSSB3b25kZXIgaWYgaXQgc2hvdWxkbid0IGJlIGNhbGxlZCB0eXBl IGFzIGluIGNhc2Ugb2YgaTJjLAo+IGJ1dCBubyBzdHJvbmcgZmVlbGluZ3MuCgpXZSBjb3VsZCBj aGFuZ2UgaXQgdG8gJ3R5cGUnLiBJdCdsbCBiZSBlYXNpZXIgZm9yIHNvbWVvbmUgdG8gdW5kZXJz dGFuZAp3aGF0IHRoZSBkc2kgY29yZSBpcyBkb2luZyBieSBrZWVwaW5nIHRoZSBzYW1lIG5vbWVu Y2xhdHVyZSBhcyBpbgppMmMtY29yZS4KCj4+ICAgCXUzMiByZWc7Cj4+ICAgCXN0cnVjdCBkZXZp Y2Vfbm9kZSAqbm9kZTsKPj4gICB9Owo+Pgo+PiArCj4gRW1wdHkgbGluZS4KPgo+PiAgIC8qKgo+ PiAgICAqIHN0cnVjdCBtaXBpX2RzaV9kZXZpY2UgLSBEU0kgcGVyaXBoZXJhbCBkZXZpY2UKPj4g ICAgKiBAaG9zdDogRFNJIGhvc3QgZm9yIHRoaXMgcGVyaXBoZXJhbAo+PiAgICAqIEBkZXY6IGRy aXZlciBtb2RlbCBkZXZpY2Ugbm9kZSBmb3IgdGhpcyBwZXJpcGhlcmFsCj4+ICsgKiBAbmFtZTog bmFtZSBvZiB0aGUgZHNpIHBlcmlwaGVyYWwKPj4gICAgKiBAY2hhbm5lbDogdmlydHVhbCBjaGFu bmVsIGFzc2lnbmVkIHRvIHRoZSBwZXJpcGhlcmFsCj4+ICAgICogQGZvcm1hdDogcGl4ZWwgZm9y bWF0IGZvciB2aWRlbyBtb2RlCj4+ICAgICogQGxhbmVzOiBudW1iZXIgb2YgYWN0aXZlIGRhdGEg bGFuZXMKPj4gQEAgLTE2NSw2ICsxNzEsOCBAQCBzdHJ1Y3QgbWlwaV9kc2lfZGV2aWNlIHsKPj4g ICAJc3RydWN0IG1pcGlfZHNpX2hvc3QgKmhvc3Q7Cj4+ICAgCXN0cnVjdCBkZXZpY2UgZGV2Owo+ Pgo+PiArCWNoYXIgbmFtZVtEU0lfREVWX05BTUVfU0laRV07Cj4+ICsKPiBUaGlzIGVtcHR5IGxp bmUgY2FuIGJlIGFsc28gcmVtb3ZlZC4KPgoKV2lsbCByZW1vdmUgdGhlc2UuCgpUaGFua3MsCkFy Y2hpdAoKPiBSZWdhcmRzCj4gQW5kcnplago+Cj4+ICAgCXVuc2lnbmVkIGludCBjaGFubmVsOwo+ PiAgIAl1bnNpZ25lZCBpbnQgbGFuZXM7Cj4+ICAgCWVudW0gbWlwaV9kc2lfcGl4ZWxfZm9ybWF0 IGZvcm1hdDsKPgo+IC0tCj4gVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhl IGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4LWFybS1tc20iIGluCj4gdGhlIGJvZHkgb2YgYSBtZXNz YWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKPiBNb3JlIG1ham9yZG9tbyBpbmZvIGF0 ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwKPgoKLS0gClRoZSBR dWFsY29tbSBJbm5vdmF0aW9uIENlbnRlciwgSW5jLiBpcyBhIG1lbWJlciBvZiB0aGUgQ29kZSBB dXJvcmEgCkZvcnVtLCBob3N0ZWQgYnkgVGhlIExpbnV4IEZvdW5kYXRpb24KX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932105AbbKBF0v (ORCPT ); Mon, 2 Nov 2015 00:26:51 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:52786 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752931AbbKBF0q (ORCPT ); Mon, 2 Nov 2015 00:26:46 -0500 Subject: Re: [RFC v2 2/5] drm/dsi: Try to match non-DT dsi devices To: Andrzej Hajda , dri-devel@lists.freedesktop.org References: <1435641851-27295-1-git-send-email-architt@codeaurora.org> <1444123482-25579-1-git-send-email-architt@codeaurora.org> <1444123482-25579-3-git-send-email-architt@codeaurora.org> <563365A0.5000507@samsung.com> Cc: linux-kernel@vger.kernel.org, airlied@linux.ie, daniel@ffwll.ch, treding@nvidia.com, l.stach@pengutronix.de, robh@kernel.org, linux-arm-msm@vger.kernel.org, jani.nikula@linux.intel.com From: Archit Taneja Message-ID: <5636F40D.5090003@codeaurora.org> Date: Mon, 2 Nov 2015 10:56:37 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <563365A0.5000507@samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/30/2015 06:12 PM, Andrzej Hajda wrote: > On 10/06/2015 11:24 AM, Archit Taneja wrote: >> Add a device name field in mipi_dsi_device. This name is different from >> the actual dev name (which is of the format "hostname.reg"). When the >> device is created via DT, this name is set to the modalias string. >> In the non-DT case, the driver creating the DSI device provides the >> name by populating a filed in mipi_dsi_device_info. >> >> Matching for DT case would be as it was before. For the non-DT case, >> we compare the device and driver names. Matching by comparing driver and >> device names isn't the best thing to do. I'd appreciate some suggestions >> here. >> >> Other buses (like i2c/spi) perform a non-DT match by comparing the >> device name and entries in the driver's id_table. The id_table structs >> for different buses are defined in "include/linux/mod_devicetable.h", I >> didn't want to touch that for now. >> >> Signed-off-by: Archit Taneja > Beside small comments below. > > Reviewed-by: Andrzej Hajda > >> --- >> drivers/gpu/drm/drm_mipi_dsi.c | 29 ++++++++++++++++++++++++++++- >> include/drm/drm_mipi_dsi.h | 8 ++++++++ >> 2 files changed, 36 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c >> index 245ecfe..46ee515 100644 >> --- a/drivers/gpu/drm/drm_mipi_dsi.c >> +++ b/drivers/gpu/drm/drm_mipi_dsi.c >> @@ -45,9 +45,30 @@ >> * subset of the MIPI DCS command set. >> */ >> >> +static const struct device_type mipi_dsi_device_type; >> + >> static int mipi_dsi_device_match(struct device *dev, struct device_driver *drv) >> { >> - return of_driver_match_device(dev, drv); >> + struct mipi_dsi_device *dsi; >> + >> + if (dev->type == &mipi_dsi_device_type) >> + dsi = to_mipi_dsi_device(dev); >> + else >> + return 0; >> + >> + /* Attempt OF style match */ >> + if (of_driver_match_device(dev, drv)) >> + return 1; >> + >> + /* >> + * Try to compare dsi device and driver names. If this matching approach >> + * isn't strong, we'd probably want the dsi drivers to populate the >> + * id_table field and use that instead >> + */ >> + if (!strcmp(dsi->name, drv->name)) >> + return 1; >> + >> + return 0; >> } >> >> static const struct dev_pm_ops mipi_dsi_device_pm_ops = { >> @@ -125,6 +146,7 @@ struct mipi_dsi_device *mipi_dsi_device_new(struct mipi_dsi_host *host, >> dsi->dev.type = &mipi_dsi_device_type; >> dsi->dev.of_node = info->node; >> dsi->channel = info->reg; >> + strlcpy(dsi->name, info->name, sizeof(dsi->name)); >> >> dev_set_name(&dsi->dev, "%s.%d", dev_name(host->dev), info->reg); >> >> @@ -147,6 +169,11 @@ of_mipi_dsi_device_add(struct mipi_dsi_host *host, struct device_node *node) >> int ret; >> u32 reg; >> >> + if (of_modalias_node(node, info.name, sizeof(info.name)) < 0) { >> + dev_err(dev, "modalias failure on %s\n", node->full_name); >> + return ERR_PTR(-EINVAL); >> + } >> + >> ret = of_property_read_u32(node, "reg", ®); >> if (ret) { >> dev_err(dev, "device node %s has no valid reg property: %d\n", >> diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h >> index 90f4f3c..93dec7b 100644 >> --- a/include/drm/drm_mipi_dsi.h >> +++ b/include/drm/drm_mipi_dsi.h >> @@ -139,8 +139,11 @@ enum mipi_dsi_pixel_format { >> MIPI_DSI_FMT_RGB565, >> }; >> >> +#define DSI_DEV_NAME_SIZE 20 >> + >> /** >> * struct mipi_dsi_device_info - template for creating a mipi_dsi_device >> + * @name: name of the dsi peripheral >> * @reg: DSI virtual channel assigned to peripheral >> * @node: pointer to OF device node >> * >> @@ -148,14 +151,17 @@ enum mipi_dsi_pixel_format { >> * DSI device >> */ >> struct mipi_dsi_device_info { >> + char name[DSI_DEV_NAME_SIZE]; > I wonder if it shouldn't be called type as in case of i2c, > but no strong feelings. We could change it to 'type'. It'll be easier for someone to understand what the dsi core is doing by keeping the same nomenclature as in i2c-core. >> u32 reg; >> struct device_node *node; >> }; >> >> + > Empty line. > >> /** >> * struct mipi_dsi_device - DSI peripheral device >> * @host: DSI host for this peripheral >> * @dev: driver model device node for this peripheral >> + * @name: name of the dsi peripheral >> * @channel: virtual channel assigned to the peripheral >> * @format: pixel format for video mode >> * @lanes: number of active data lanes >> @@ -165,6 +171,8 @@ struct mipi_dsi_device { >> struct mipi_dsi_host *host; >> struct device dev; >> >> + char name[DSI_DEV_NAME_SIZE]; >> + > This empty line can be also removed. > Will remove these. Thanks, Archit > Regards > Andrzej > >> unsigned int channel; >> unsigned int lanes; >> enum mipi_dsi_pixel_format format; > > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation