From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [RFC v2 3/5] drm/dsi: Check for used channels Date: Mon, 2 Nov 2015 10:58:33 +0530 Message-ID: <5636F481.8080000@codeaurora.org> References: <1435641851-27295-1-git-send-email-architt@codeaurora.org> <1444123482-25579-1-git-send-email-architt@codeaurora.org> <1444123482-25579-4-git-send-email-architt@codeaurora.org> <563367F1.2060202@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <563367F1.2060202@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andrzej Hajda , dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, treding@nvidia.com List-Id: linux-arm-msm@vger.kernel.org CgpPbiAxMC8zMC8yMDE1IDA2OjIyIFBNLCBBbmRyemVqIEhhamRhIHdyb3RlOgo+IE9uIDEwLzA2 LzIwMTUgMTE6MjQgQU0sIEFyY2hpdCBUYW5lamEgd3JvdGU6Cj4+IFdlIGRvbid0IGNoZWNrIHdo ZXRoZXIgYSBwcmV2aW91c2x5IHJlZ2lzdGVyZWQgbWlwaV9kc2lfZGV2aWNlIHVuZGVyIHRoZQo+ PiBzYW1lIGhvc3Qgc2hhcmVzIHRoZSBzYW1lIHZpcnR1YWwgY2hhbm5lbC4KPj4KPj4gQmVmb3Jl IHJlZ2lzdGVyaW5nLCBjaGVjayBpZiBhbnkgb2YgdGhlIHJlZ2lzdGVyZWQgZGV2aWNlcyBkb2Vz bid0Cj4+IGFscmVhZHkgaGF2ZSB0aGUgc2FtZSB2aXJ0dWFsIGNoYW5uZWwuCj4+Cj4+IFRoaXMg d2Fzbid0IGNydWNpYWwgd2hlbiBhbGwgdGhlIGRldmljZXMgdW5kZXIgYSBob3N0IHdlcmUgcG9w dWxhdGVkIHZpYQo+PiBEVC4gTm93IHRoYXQgd2UgYWxzbyBzdXBwb3J0IGNyZWF0aW5nIGRldmlj ZXMgbWFudWFsbHksIHdlIGNvdWxkIGVuZCB1cAo+PiBpbiBhIHNpdHVhdGlvbiB3aGVyZSBhIGRy aXZlciB0cmllcyB0byBjcmVhdGUgYSBkZXZpY2Ugd2l0aCBhIHZpcnR1YWwKPj4gY2hhbm5lbCBh bHJlYWR5IHRha2VuIGJ5IGEgZGV2aWNlIHBvcHVsYXRlZCBpbiBEVC4KPj4KPj4gU2lnbmVkLW9m Zi1ieTogQXJjaGl0IFRhbmVqYSA8YXJjaGl0dEBjb2RlYXVyb3JhLm9yZz4KPiBCZXNpZGUgZmV3 IG5vbi1ibGNraW5nIG5pdHBpY2tzLgo+Cj4gUmV2aWV3ZWQtYnk6IEFuZHJ6ZWogSGFqZGEgPGEu aGFqZGFAc2Ftc3VuZy5jb20+Cj4KPj4gLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2RybV9taXBp X2RzaS5jIHwgMjYgKysrKysrKysrKysrKysrKysrKysrKysrLS0KPj4gICAxIGZpbGUgY2hhbmdl ZCwgMjQgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9kcm1fbWlwaV9kc2kuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fbWlwaV9k c2kuYwo+PiBpbmRleCA0NmVlNTE1Li5kYjYxMzBhIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vZHJtX21pcGlfZHNpLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9taXBpX2Rz aS5jCj4+IEBAIC0xMjMsNiArMTIzLDIyIEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZGV2aWNlX3R5 cGUgbWlwaV9kc2lfZGV2aWNlX3R5cGUgPSB7Cj4+ICAgCS5yZWxlYXNlID0gbWlwaV9kc2lfZGV2 X3JlbGVhc2UsCj4+ICAgfTsKPj4KPj4gK3N0YXRpYyBpbnQgX19kc2lfY2hlY2tfY2hhbl9idXN5 KHN0cnVjdCBkZXZpY2UgKmRldiwgdm9pZCAqZGF0YSkKPj4gK3sKPj4gKwlzdHJ1Y3QgbWlwaV9k c2lfZGV2aWNlICpkc2kgPSB0b19taXBpX2RzaV9kZXZpY2UoZGV2KTsKPj4gKwl1MzIgcmVnID0g Kih1MzIgKikgZGF0YTsKPj4gKwo+PiArCWlmIChkc2kgJiYgZHNpLT5jaGFubmVsID09IHJlZykK PiBNYXliZSBzaW1wbGVyIHdvdWxkIGJlOgo+Cj4gICAgICB1MzIgKnJlZyA9IGRhdGE7Cj4KPiAg ICAgIGlmIChkc2kgJiYgZHNpLT5jaGFubmVsID09ICpyZWcpCj4KClRoaXMgaXMgYmV0dGVyLiBJ J2xsIGNoYW5nZSBpdCB0byB0aGlzLgoKPgo+Cj4+ICsJCXJldHVybiAtRUJVU1k7Cj4+ICsKPj4g KwlyZXR1cm4gMDsKPj4gK30KPj4gKwo+PiArc3RhdGljIGludCBtaXBpX2RzaV9jaGVja19jaGFu X2J1c3koc3RydWN0IG1pcGlfZHNpX2hvc3QgKmhvc3QsIHUzMiByZWcpCj4+ICt7Cj4+ICsJcmV0 dXJuIGRldmljZV9mb3JfZWFjaF9jaGlsZChob3N0LT5kZXYsICZyZWcsIF9fZHNpX2NoZWNrX2No YW5fYnVzeSk7Cj4+ICt9Cj4+ICsKPj4gICBzdHJ1Y3QgbWlwaV9kc2lfZGV2aWNlICptaXBpX2Rz aV9kZXZpY2VfbmV3KHN0cnVjdCBtaXBpX2RzaV9ob3N0ICpob3N0LAo+PiAgIAkJCQkJICAgIHN0 cnVjdCBtaXBpX2RzaV9kZXZpY2VfaW5mbyAqaW5mbykKPj4gICB7Cj4+IEBAIC0xNTAsMTQgKzE2 NiwyMCBAQCBzdHJ1Y3QgbWlwaV9kc2lfZGV2aWNlICptaXBpX2RzaV9kZXZpY2VfbmV3KHN0cnVj dCBtaXBpX2RzaV9ob3N0ICpob3N0LAo+Pgo+PiAgIAlkZXZfc2V0X25hbWUoJmRzaS0+ZGV2LCAi JXMuJWQiLCBkZXZfbmFtZShob3N0LT5kZXYpLCBpbmZvLT5yZWcpOwo+Pgo+PiArCXIgPSBtaXBp X2RzaV9jaGVja19jaGFuX2J1c3koaG9zdCwgaW5mby0+cmVnKTsKPgo+IEkga25vdyB0aGlzIHIg dmFyaWFibGUgd2FzIGludHJvZHVjZWQgaW4gdGhlIDFzdCBwYXRjaCwgYnV0IGlmIHlvdSB3aWxs IHNlbmQKPiBuZXh0IGl0ZXJhdGlvbgo+IGNvbnNpZGVyIHJlcGxhY2luZyBpdCB3aXRoIHJldCwg bG9va3MgbW9yZSByZWFkYWJsZSBhbmQgZm9sbG93cyBmaWxlIGNvbnZlbnRpb24gOikKCkknbGwg cHJvYmFibHkgZW5kIHVwIHNlbmRpbmcgYW5vdGhlciBpdGVyYXRpb24gKG9yIG1vcmUpLiBJJ2xs IGNoYW5nZQp0aGUgbmFtZS4KClRoYW5rcywKQXJjaGl0Cgo+Cj4gUmVnYXJkcwo+IEFuZHJ6ZWoK Pgo+PiArCWlmIChyKQo+PiArCQlnb3RvIGVycjsKPj4gKwo+PiAgIAlyID0gZGV2aWNlX3JlZ2lz dGVyKCZkc2ktPmRldik7Cj4+ICAgCWlmIChyKSB7Cj4+ICAgCQlkZXZfZXJyKGRldiwgImZhaWxl ZCB0byByZWdpc3RlciBkZXZpY2U6ICVkXG4iLCByKTsKPj4gLQkJa2ZyZWUoZHNpKTsKPj4gLQkJ cmV0dXJuIEVSUl9QVFIocik7Cj4+ICsJCWdvdG8gZXJyOwo+PiAgIAl9Cj4+Cj4+ICAgCXJldHVy biBkc2k7Cj4+ICtlcnI6Cj4+ICsJa2ZyZWUoZHNpKTsKPj4gKwlyZXR1cm4gRVJSX1BUUihyKTsK Pj4gICB9Cj4+ICAgRVhQT1JUX1NZTUJPTChtaXBpX2RzaV9kZXZpY2VfbmV3KTsKPj4KPgo+IC0t Cj4gVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2Ny aWJlIGxpbnV4LWtlcm5lbCIgaW4KPiB0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21v QHZnZXIua2VybmVsLm9yZwo+IE1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtl cm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAo+IFBsZWFzZSByZWFkIHRoZSBGQVEgYXQgIGh0 dHA6Ly93d3cudHV4Lm9yZy9sa21sLwo+CgotLSAKVGhlIFF1YWxjb21tIElubm92YXRpb24gQ2Vu dGVyLCBJbmMuIGlzIGEgbWVtYmVyIG9mIHRoZSBDb2RlIEF1cm9yYSAKRm9ydW0sIGhvc3RlZCBi eSBUaGUgTGludXggRm91bmRhdGlvbgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932070AbbKBF2n (ORCPT ); Mon, 2 Nov 2015 00:28:43 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:52859 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751372AbbKBF2k (ORCPT ); Mon, 2 Nov 2015 00:28:40 -0500 Subject: Re: [RFC v2 3/5] drm/dsi: Check for used channels To: Andrzej Hajda , dri-devel@lists.freedesktop.org References: <1435641851-27295-1-git-send-email-architt@codeaurora.org> <1444123482-25579-1-git-send-email-architt@codeaurora.org> <1444123482-25579-4-git-send-email-architt@codeaurora.org> <563367F1.2060202@samsung.com> Cc: linux-kernel@vger.kernel.org, airlied@linux.ie, daniel@ffwll.ch, treding@nvidia.com, l.stach@pengutronix.de, robh@kernel.org, linux-arm-msm@vger.kernel.org, jani.nikula@linux.intel.com From: Archit Taneja Message-ID: <5636F481.8080000@codeaurora.org> Date: Mon, 2 Nov 2015 10:58:33 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <563367F1.2060202@samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/30/2015 06:22 PM, Andrzej Hajda wrote: > On 10/06/2015 11:24 AM, Archit Taneja wrote: >> We don't check whether a previously registered mipi_dsi_device under the >> same host shares the same virtual channel. >> >> Before registering, check if any of the registered devices doesn't >> already have the same virtual channel. >> >> This wasn't crucial when all the devices under a host were populated via >> DT. Now that we also support creating devices manually, we could end up >> in a situation where a driver tries to create a device with a virtual >> channel already taken by a device populated in DT. >> >> Signed-off-by: Archit Taneja > Beside few non-blcking nitpicks. > > Reviewed-by: Andrzej Hajda > >> --- >> drivers/gpu/drm/drm_mipi_dsi.c | 26 ++++++++++++++++++++++++-- >> 1 file changed, 24 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c >> index 46ee515..db6130a 100644 >> --- a/drivers/gpu/drm/drm_mipi_dsi.c >> +++ b/drivers/gpu/drm/drm_mipi_dsi.c >> @@ -123,6 +123,22 @@ static const struct device_type mipi_dsi_device_type = { >> .release = mipi_dsi_dev_release, >> }; >> >> +static int __dsi_check_chan_busy(struct device *dev, void *data) >> +{ >> + struct mipi_dsi_device *dsi = to_mipi_dsi_device(dev); >> + u32 reg = *(u32 *) data; >> + >> + if (dsi && dsi->channel == reg) > Maybe simpler would be: > > u32 *reg = data; > > if (dsi && dsi->channel == *reg) > This is better. I'll change it to this. > > >> + return -EBUSY; >> + >> + return 0; >> +} >> + >> +static int mipi_dsi_check_chan_busy(struct mipi_dsi_host *host, u32 reg) >> +{ >> + return device_for_each_child(host->dev, ®, __dsi_check_chan_busy); >> +} >> + >> struct mipi_dsi_device *mipi_dsi_device_new(struct mipi_dsi_host *host, >> struct mipi_dsi_device_info *info) >> { >> @@ -150,14 +166,20 @@ struct mipi_dsi_device *mipi_dsi_device_new(struct mipi_dsi_host *host, >> >> dev_set_name(&dsi->dev, "%s.%d", dev_name(host->dev), info->reg); >> >> + r = mipi_dsi_check_chan_busy(host, info->reg); > > I know this r variable was introduced in the 1st patch, but if you will send > next iteration > consider replacing it with ret, looks more readable and follows file convention :) I'll probably end up sending another iteration (or more). I'll change the name. Thanks, Archit > > Regards > Andrzej > >> + if (r) >> + goto err; >> + >> r = device_register(&dsi->dev); >> if (r) { >> dev_err(dev, "failed to register device: %d\n", r); >> - kfree(dsi); >> - return ERR_PTR(r); >> + goto err; >> } >> >> return dsi; >> +err: >> + kfree(dsi); >> + return ERR_PTR(r); >> } >> EXPORT_SYMBOL(mipi_dsi_device_new); >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation