All of lore.kernel.org
 help / color / mirror / Atom feed
From: Minkyu Kang <mk7.kang@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] s5p sdhci: call pinmux for card's gpio pins before use them
Date: Mon, 02 Nov 2015 14:37:54 +0900	[thread overview]
Message-ID: <5636F6B2.5020300@samsung.com> (raw)
In-Reply-To: <1446043310-21519-2-git-send-email-p.marczak@samsung.com>

On 28/10/15 23:41, Przemyslaw Marczak wrote:
> The SD card detection depends on checking one pin state.
> But the pin was configured after card was detected, which is wrong.
> 
> This commit fixes this, by moving call to pinmux before use the pin.
> 
> Tested-on: Odroid U3 and Odroid X2.
> 
> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
> Cc: Guillaume GARDET <guillaume.gardet@free.fr>
> Cc: Lukasz Majewski <l.majewski@samsung.com>
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> Cc: Simon Glass <sjg@chromium.org>
> ---
>  drivers/mmc/s5p_sdhci.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 

applied to u-boot-samsung.

Thanks,
Minkyu Kang.

  parent reply	other threads:[~2015-11-02  5:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-28 14:41 [U-Boot] [PATCH 1/2] Exynos4412: pinmux: disable pull for MMC pins Przemyslaw Marczak
2015-10-28 14:41 ` [U-Boot] [PATCH 2/2] s5p sdhci: call pinmux for card's gpio pins before use them Przemyslaw Marczak
2015-10-29  7:29   ` Jaehoon Chung
2015-10-29 17:13   ` Lukasz Majewski
2015-11-02  5:37   ` Minkyu Kang [this message]
2015-10-29  7:29 ` [U-Boot] [PATCH 1/2] Exynos4412: pinmux: disable pull for MMC pins Jaehoon Chung
2015-10-29 17:12 ` Lukasz Majewski
2015-11-02  5:37 ` Minkyu Kang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5636F6B2.5020300@samsung.com \
    --to=mk7.kang@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.