From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincent ABRIOU Subject: Re: [PATCH] drm/sti: Remove select of CONFIG_FW_LOADER_USER_HELPER_FALLBACK Date: Mon, 2 Nov 2015 10:10:27 +0100 Message-ID: <56372883.2020801@st.com> References: <1445235370-6717-1-git-send-email-tiwai@suse.de> <56322B6F.5080101@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2CBF56E13C for ; Mon, 2 Nov 2015 01:10:38 -0800 (PST) In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Takashi Iwai , Emil Velikov Cc: Benjamin Gaignard , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org SGkgVGFrYXNoaSwNCg0KSSBtYWRlIGEgcmV3b3JrIHRvIGxvYWQgdGhlIGZpcm13YXJlIGF0IGEg ZGlmZmVyZW50IHRpbWUsIHdoZW4gZmlsZSANCnN5c3RlbSBpcyBhdmFpbGFibGUuDQpJIGFtIG5v dyBhYmxlIHRvIHJlbW92ZSBGV19MT0FERVJfVVNFUl9IRUxQRVJfRkFMTEJBQ0suDQpJIHdpbGwg c3VibWl0IGEgbmV3IHBhdGNoIGZvciB0aGlzLg0KDQpWaW5jZW50DQoNCk9uIDEwLzI5LzIwMTUg MDM6NTMgUE0sIFRha2FzaGkgSXdhaSB3cm90ZToNCj4gT24gVGh1LCAyOSBPY3QgMjAxNSAxNToz Nzo1MSArMDEwMCwNCj4gRW1pbCBWZWxpa292IHdyb3RlOg0KPj4NCj4+IE9uIDI5IE9jdG9iZXIg MjAxNSBhdCAxNDoyMSwgVmluY2VudCBBQlJJT1UgPHZpbmNlbnQuYWJyaW91QHN0LmNvbT4gd3Jv dGU6DQo+Pj4gSGkgVGFrYXNoaSwNCj4+Pg0KPj4+IFJlbW92aW5nIEZXX0xPQURFUl9VU0VSX0hF TFBFUl9GQUxMQkFDSyBsZWFkcyB0byBhIGZhaWx1cmUgaW4gb3VyIEhRVkRQDQo+Pj4gZmlybXdh cmUgZXhlY3V0aW9uLg0KPj4+IEluZGVlZCwgb3VyIGZpcm13YXJlIGlzIG5vdCBidWlsdC1pbi4g SXQgaXMgYSBwcm9wcmlldGFyeSBmaXJtd2FyZQ0KPj4+IHVwbG9hZGVkIGludG8gdGhlIGZpbGUg c3lzdGVtIHRoYXQncyB3aHkgd2UgbmVlZCB0aGUNCj4+PiBVU0VSX0hFTFBFUl9GQUxMQkFDSyB0 byBiZSBhYmxlIHRvIGxvYWQgaXQgb25jZSBmaWxlIHN5c3RlbSBpcyBhdmFpbGFibGUuDQo+Pj4N Cj4+IEhtbSBtb3N0IG90aGVyIERSTSBkcml2ZXJzIGFsc28gcmVxdWlyZSBmaXJtd2FyZS4gV2hp c3Qgc29tZSBhbGxvdyB0aGUNCj4+IGZpcm13YXJlIHRvIGJlIHBpY2tlZCBpbiBpbml0cmQgaXQn cyBub3QgYSBzdHJpY3QgcmVxdWlyZW1lbnQuDQo+PiBTbyBJJ20gd29uZGVyaW5nIGhvdyBjb21l IHRoZXJlIGhhc24ndCBiZWVuIChtKWFueSByZXBvcnRzLA0KPj4gY29uc2lkZXJpbmcgdGhhdCBu ZWl0aGVyIG9uZSBzZXRzIFVTRVJfSEVMUEVSX0ZBTExCQUNLLg0KPj4NCj4+IFBlcmhhcHMgdGhl eSBhbHNvIG5lZWQgaXQsIG9yIHNvbWV0aGluZyBpbiB0aGUgc3RpIG1vZHVsZSBpcyBkb25lDQo+ PiBkaWZmZXJlbnRseSA/IEp1c3Qgc29tZSBmb29kIGZvciB0aG91Z2h0Lg0KPg0KPiBJdCdzIHRo ZSBvcHRpb24gZWFjaCB1c2VyIGRlY2lkZXMgdG8gc2V0IG9yIG5vdCwgZGVwZW5kaW5nIG9uIHRo ZQ0KPiBkZXBsb3llZCBzeXN0ZW0uICBNb3N0IG9mIFBDcyBkb24ndCBuZWVkIHRoZW0sIGFuZCBh Y3R1YWxseSBlbmFibGluZw0KPiB0aGlzIG9wdGlvbiBjYXVzZXMgdHJvdWJsZXMgZm9yIHRoZW0u ICBPbiBvdGhlciBlbWJlZGRlZCBzeXN0ZW1zLCB0aGlzDQo+IG1pZ2h0IGJlIHN0aWxsIG5lZWRl ZC4gIFNvLCBpdCdzIHRoZSBzeXN0ZW0gc2V0dXAgaXNzdWUsIGFuZCBub3QgdGhlDQo+IHRoaW5n IGEgZHJpdmVyIG5lZWRzIHRvIGNhcmUuDQo+DQo+IEltYWdpbmUgdGhhdCB5b3VyIGRyaXZlciBo YXMgInNlbGVjdCBFWFQzX0ZTIiBiZWNhdXNlIHlvdXIgc3lzdGVtDQo+IHJlcXVpcmVzIGl0OyB3 aXRob3V0IHRoYXQgb3B0aW9uLCBpdCB3b24ndCBib290LCBPTUchDQo+IElzIGl0IHRoZSByaWdo dCB0aGluZz8gIE9idmlvdXNseSBuby4gIFRoZSBzYW1lIGxvZ2ljIGlzIGFwcGxpZWQgdG8NCj4g dGhpcyBjYXNlLCB0b28uDQo+DQo+DQo+IFRha2FzaGkNCj4gX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18NCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdA0KPiBk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnDQo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwNCj4KX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752892AbbKBJKs (ORCPT ); Mon, 2 Nov 2015 04:10:48 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:43916 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752490AbbKBJKo (ORCPT ); Mon, 2 Nov 2015 04:10:44 -0500 From: Vincent ABRIOU To: Takashi Iwai , Emil Velikov CC: "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Benjamin Gaignard Date: Mon, 2 Nov 2015 10:10:27 +0100 Subject: Re: [PATCH] drm/sti: Remove select of CONFIG_FW_LOADER_USER_HELPER_FALLBACK Thread-Topic: [PATCH] drm/sti: Remove select of CONFIG_FW_LOADER_USER_HELPER_FALLBACK Thread-Index: AdEVTlKqHcfG/r5MSnCOA7J2Z8SPTg== Message-ID: <56372883.2020801@st.com> References: <1445235370-6717-1-git-send-email-tiwai@suse.de> <56322B6F.5080101@st.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 acceptlanguage: en-US Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.15.21,1.0.33,0.0.0000 definitions=2015-11-02_05:2015-10-29,2015-11-02,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tA29At3J030243 Hi Takashi, I made a rework to load the firmware at a different time, when file system is available. I am now able to remove FW_LOADER_USER_HELPER_FALLBACK. I will submit a new patch for this. Vincent On 10/29/2015 03:53 PM, Takashi Iwai wrote: > On Thu, 29 Oct 2015 15:37:51 +0100, > Emil Velikov wrote: >> >> On 29 October 2015 at 14:21, Vincent ABRIOU wrote: >>> Hi Takashi, >>> >>> Removing FW_LOADER_USER_HELPER_FALLBACK leads to a failure in our HQVDP >>> firmware execution. >>> Indeed, our firmware is not built-in. It is a proprietary firmware >>> uploaded into the file system that's why we need the >>> USER_HELPER_FALLBACK to be able to load it once file system is available. >>> >> Hmm most other DRM drivers also require firmware. Whist some allow the >> firmware to be picked in initrd it's not a strict requirement. >> So I'm wondering how come there hasn't been (m)any reports, >> considering that neither one sets USER_HELPER_FALLBACK. >> >> Perhaps they also need it, or something in the sti module is done >> differently ? Just some food for thought. > > It's the option each user decides to set or not, depending on the > deployed system. Most of PCs don't need them, and actually enabling > this option causes troubles for them. On other embedded systems, this > might be still needed. So, it's the system setup issue, and not the > thing a driver needs to care. > > Imagine that your driver has "select EXT3_FS" because your system > requires it; without that option, it won't boot, OMG! > Is it the right thing? Obviously no. The same logic is applied to > this case, too. > > > Takashi > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel >{.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I