From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] x86: make compat_iret() domain crash cases distinguishable Date: Mon, 2 Nov 2015 11:10:06 +0000 Message-ID: <5637448E.7010304@citrix.com> References: <5633BB0802000078000B0613@prv-mh.provo.novell.com> <5633BF82.2000301@citrix.com> <56374FAF02000078000B0AAB@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZtD06-0001GN-HJ for xen-devel@lists.xenproject.org; Mon, 02 Nov 2015 11:10:10 +0000 In-Reply-To: <56374FAF02000078000B0AAB@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel , Keir Fraser List-Id: xen-devel@lists.xenproject.org On 02/11/15 10:57, Jan Beulich wrote: >>>> On 30.10.15 at 20:05, wrote: >> On 30/10/15 17:46, Jan Beulich wrote: >>> Rather than issuing a (mostly) useless separate message, rely on >>> domain_crash() providing enough data, and leverage the line number >>> information it prints. >>> >>> Signed-off-by: Jan Beulich >> The messages are not completely useless, and they do save a round-trip >> to the debug symbols (which can be a very long RTT when dealing with >> customers). > Oh, also: Why would looking at the debug symbols be needed? You > get file name and line number printed. Any file patched will end up having a slide on the line number. The use of the debug symbols is necessary to confirm, especially in cases like this where there are multiple possibilities close to each other. ~Andrew