From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 1/3] KVM: x86: merge kvm_arch_set_irq with kvm_set_msi_inatomic Date: Mon, 2 Nov 2015 17:08:02 +0100 Message-ID: <56378A62.3090706@redhat.com> References: <1446466878-32837-1-git-send-email-pbonzini@redhat.com> <1446466878-32837-2-git-send-email-pbonzini@redhat.com> <20151102145923.GB24667@potion.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Alex Williamson To: Radim Krcmar Return-path: In-Reply-To: <20151102145923.GB24667@potion.brq.redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 02/11/2015 15:59, Radim Krcmar wrote: > > We do not want to do too much work in atomic context, in particular > > not walking all the VCPUs of the virtual machine. So we want > > to distinguish the architecture-specific injection function for irqfd > > from kvm_set_msi. Since it's still empty, reuse the newly added > > kvm_arch_set_irq and rename it to kvm_arch_set_irq_inatomic. > > kvm/queue uses kvm_arch_set_irq since b7184313f4b9 ("kvm/x86: Hyper-V > synthetic interrupt controller"). > > Is synic going to be dropped before this patch is merged? Yes. Both because the Virtuozzo people confirmed that kvm_arch_set_irq isn't needed for synic, and because synic is currently broken with APICv. Paolo