From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v3 3/6] xen: sched: clarify use cases of schedule_cpu_switch() Date: Mon, 2 Nov 2015 18:23:36 +0000 Message-ID: <5637AA28.8090201@citrix.com> References: <20151029225158.25219.4625.stgit@Solace.station> <20151029230427.25219.2409.stgit@Solace.station> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZtJld-0005E1-OC for xen-devel@lists.xenproject.org; Mon, 02 Nov 2015 18:23:41 +0000 In-Reply-To: <20151029230427.25219.2409.stgit@Solace.station> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Dario Faggioli , xen-devel@lists.xenproject.org Cc: Juergen Gross , George Dunlap , Jan Beulich List-Id: xen-devel@lists.xenproject.org On 29/10/15 23:04, Dario Faggioli wrote: > schedule_cpu_switch() is meant to be only used for moving > pCPUs from a cpupool to no cpupool, and from there back > to a cpupool, *not* to move them directly from one cpupool > to another. > > This is something that is reflected in the way it is > implemented, and should be kept in mind when looking at > it. However, that is not that clear, by just the look of > it. > > Make it more evident by: > - adding commentary and ASSERT()s; > - update the cpupool per-CPU variable (mapping pCPUs to > pools) directly in schedule_cpu_switch(), rather than > in various places in cpupool.c. > > Signed-off-by: Dario Faggioli > Acked-by: Juergen Gross Reviewed-by: George Dunlap