From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zain Subject: Re: [RESEND PATCH 1/4] Crypto: Crypto driver support aes/des/des3 for rk3288 Date: Tue, 3 Nov 2015 09:07:47 +0800 Message-ID: <563808E3.5090005@rock-chips.com> References: <1446193369-4453-1-git-send-email-zain.wang@rock-chips.com> <1446193369-4453-2-git-send-email-zain.wang@rock-chips.com> <2230290.pTq1BehVXW@phil> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, eddie.cai-TNX95d0MmH7DzftRWevZcw@public.gmane.org, linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, zhengsq-TNX95d0MmH7DzftRWevZcw@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org To: Heiko Stuebner Return-path: In-Reply-To: <2230290.pTq1BehVXW@phil> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-crypto.vger.kernel.org SGkgSGVpa28sCgpPbiAyMDE15bm0MTDmnIgzMOaXpSAyMjoyNiwgSGVpa28gU3R1ZWJuZXIgd3Jv dGU6Cj4gSGksCj4KPiBmaXJzdCBvZiBhbGwsIHRoYW5rcyBmb3Igd29ya2luZyBvbiB0aGlzLCBp dCB3aWxsIGJlIHJlYWxseSBjb29sIHRvIHNlZSB0aGUKPiBjcnlwdG8gYWNjZWxlcmF0b3Igc3Vw cG9ydGVkIGluIHRoZSBrZXJuZWwgOi0pCj4KPiBBbSBGcmVpdGFnLCAzMC4gT2t0b2JlciAyMDE1 LCAxNjoyMjo0NiBzY2hyaWViIFphaW4gV2FuZzoKPj4gQ3J5cHRvIGRyaXZlciBzdXBwb3J0IGNi Yy9lY2IgdHdvIGNoYWlubW9kZSwgYW5kIGFlcy9kZXMvZGVzMyB0aHJlZSBjaXBoZXIgbW9kZS4K Pj4gVGhlIG5hbWVzIHJlZ2lzdGVyZWQgYXJlOgo+PiAgICAgZWNiKGFlcykgY2JjKGFlcykgZWNi KGRlcykgY2JjKGRlcykgZWNiKGRlczNfZWRlKSBjYmMoZGVzM19lZGUpCj4+IFlvdSBjYW4gYWxs b2MgdGFncyBhYm92ZSBpbiB5b3VyIGNhc2UuCj4+Cj4+IEFuZCBvdGhlciBhbGdvcml0aG1zIGFu ZCBwbGF0Zm9ybXMgd2lsbCBiZSBhZGRlZCBsYXRlciBvbi4KPj4KPj4gU2lnbmVkLW9mZi1ieTog WmFpbiBXYW5nIDx6YWluLndhbmdAcm9jay1jaGlwcy5jb20+Cj4+IC0tLQo+PiAgZHJpdmVycy9j cnlwdG8vTWFrZWZpbGUgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEgKwo+PiAgZHJp dmVycy9jcnlwdG8vcmtfY3J5cHRvL01ha2VmaWxlICAgICAgICAgICAgICAgICAgfCAgIDMgKwo+ PiAgZHJpdmVycy9jcnlwdG8vcmtfY3J5cHRvL3JrMzI4OF9jcnlwdG8uYyAgICAgICAgICAgfCAz OTMgKysrKysrKysrKysrKysrKwo+PiAgZHJpdmVycy9jcnlwdG8vcmtfY3J5cHRvL3JrMzI4OF9j cnlwdG8uaCAgICAgICAgICAgfCAyOTEgKysrKysrKysrKysrCj4+ICAuLi4vY3J5cHRvL3JrX2Ny eXB0by9yazMyODhfY3J5cHRvX2FibGtjaXBoZXIuYyAgICB8IDUwMiArKysrKysrKysrKysrKysr KysrKysKPj4gIDUgZmlsZXMgY2hhbmdlZCwgMTE5MCBpbnNlcnRpb25zKCspCj4+ICBjcmVhdGUg bW9kZSAxMDA2NDQgZHJpdmVycy9jcnlwdG8vcmtfY3J5cHRvL01ha2VmaWxlCj4+ICBjcmVhdGUg bW9kZSAxMDA2NDQgZHJpdmVycy9jcnlwdG8vcmtfY3J5cHRvL3JrMzI4OF9jcnlwdG8uYwo+PiAg Y3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvY3J5cHRvL3JrX2NyeXB0by9yazMyODhfY3J5cHRv LmgKPj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL2NyeXB0by9ya19jcnlwdG8vcmszMjg4 X2NyeXB0b19hYmxrY2lwaGVyLmMKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvY3J5cHRvL01h a2VmaWxlIGIvZHJpdmVycy9jcnlwdG8vTWFrZWZpbGUKPj4gaW5kZXggYzNjZWQ2Zi4uMDBkMTAz YyAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9jcnlwdG8vTWFrZWZpbGUKPj4gKysrIGIvZHJpdmVy cy9jcnlwdG8vTWFrZWZpbGUKPj4gQEAgLTI5LDMgKzI5LDQgQEAgb2JqLSQoQ09ORklHX0NSWVBU T19ERVZfUUFUKSArPSBxYXQvCj4+ICBvYmotJChDT05GSUdfQ1JZUFRPX0RFVl9RQ0UpICs9IHFj ZS8KPj4gIG9iai0kKENPTkZJR19DUllQVE9fREVWX1ZNWCkgKz0gdm14Lwo+PiAgb2JqLSQoQ09O RklHX0NSWVBUT19ERVZfU1VONElfU1MpICs9IHN1bnhpLXNzLwo+PiArb2JqLSQoQ09ORklHX0NS WVBUT19ERVZfUkszMjg4KSArPSBya19jcnlwdG8vCj4gYXMgTWFyayBzYWlkIGluIHRoZSBvdGhl ciBtYWlsLCB0aGVyZSBtYXkgdmVyeSB3ZWxsIGZvbGxvdyBvdGhlciBSb2NrY2hpcAo+IGNyeXB0 by1yZWxhdGVkIGRyaXZlcnMsIHNvIG1heWJlIGl0IG1pZ2h0IGJlIGJldHRlciB0byBuYW1lIHRo ZSBjb3JlCj4gb3B0aW9uIENPTkZJR19DUllQVE9fREVWX1JPQ0tDSElQLiBBbmQgdGhlbiBtYXli ZSBkZWZpbmUKPiBDT05GSUdfQ1JZUFRPX0RFVl9SSzMyODggaW4gYSBLY29uZmlnIGluIHRoZSBz dWJkaXJlY3RvcnkgKGxpa2Ugdm14IGRvZXMpLgpvayEgZG9uZSEKPgo+Cj4+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2NyeXB0by9ya19jcnlwdG8vTWFrZWZpbGUgYi9kcml2ZXJzL2NyeXB0by9ya19j cnlwdG8vTWFrZWZpbGUKPj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPj4gaW5kZXggMDAwMDAwMC4u MGY2MmQ4Nwo+PiAtLS0gL2Rldi9udWxsCj4+ICsrKyBiL2RyaXZlcnMvY3J5cHRvL3JrX2NyeXB0 by9NYWtlZmlsZQo+IGdlbmVyYWxseSwgYSBsb3Qgb2YgdGhvc2Ugc3ViZGlyZWN0b3JpZXMgcmVm ZXJlbmNlIG9ubHkgdGhlIG1hbnVmYWN0dXJlcgo+IG5hbWUsIHNvIG15IHN1Z2dlc3Rpb24gd291 bGQgYmUgdG8gbmFtZSB5b3VycyBqdXN0ICJyb2NrY2hpcCIgaW5zdGVhZCBvZgo+ICJya19jcnlw dG8iLCB0byBhbHNvIGVhc2UgcmVhZGFiaWxpdHkuCm9rISBkb25lIQo+Cj4KPj4gQEAgLTAsMCAr MSwzIEBACj4+ICtvYmotJChDT05GSUdfQ1JZUFRPX0RFVl9SSzMyODgpICs9IHJrX2NyeXB0b19k cml2ZXIubwo+PiArcmtfY3J5cHRvX2RyaXZlci1vYmpzIDo9IHJrMzI4OF9jcnlwdG8ubyBcCj4+ ICsJCQkgcmszMjg4X2NyeXB0b19hYmxrY2lwaGVyLm8gXAo+IHRoYXQgbG9va3MgbG9va3Mgd3Jv bmcuCj4KPiAoMSkgdGhlIGNvbmZpZyBvcHRpb24gZG9lcyBub3QgZ2V0IGRlZmluZWQgaW4gYW55 IEtjb25maWcgZmlsZSBpbiB5b3VyIHNldAppIGFtIHNvcnJ5IGFib3V0IGl0LCBpIHdpbGwgY29t bWl0IGl0IG5leHQgdmVyc2lvbi4KPiAoMikgbmFtaW5nIHRoZSBkcml2ZXIgZ2VuZXJpY2FsbHkg d2hpbGUgeW91IGNvbXBpbGUgYSB2YXJpYW50IHdpbGwgaGluZGVyCj4gICAgIG11bHRpcGxhdGZv cm0ga2VybmVscywgYmVjYXVzZSB5b3UgbWlnaHQgd2FudCB0byBidWlsZCBib3RoIHRoZSByazMy ODgKPiAgICAgY29kZSBhbmQgc29tZSBhZGRpdGlvbmFsIHN0dWZmPwppIHdhbnQgdG8gY29tbWl0 IGhhc2ggYmFzZSBvbiB0aGlzIHBhdGNoIGxhdGVyLgo+ICgzKSB0aGUgX2RyaXZlciBzdWZmaXgg aXMgdW5uZWNlc3NhcnkKb2shIGRvbmUuCj4KPiBTbyBJIGd1ZXNzIGp1c3QgbmFtZSBpdCByazMy ODhfY3J5cHRvLm8gPwo+Cj4gWy4uLl0KPgo+IFdoaWxlIEkgaGF2ZSByZWFkIHRocm91Z2ggdGhl IGNvZGUgaW1wbGVtZW50aW5nIHRoZSBkZXZpY2UsIEkgaGF2ZW4ndAo+IHNlZW4gYW55dGhpbmcg c3ByaW5nIG91dCBidXQgZG8gbm90IGtub3cgZW5vdWdoIGFib3V0IHRoZSBjcnlwdG8gc3Vic3lz dGVtCj4gaXRzZWxmLiBCdXQgaXQgbG9va3MgbGlrZSB5b3UgZ290IHNvbWUgZmVlZGJhY2sgYWxy ZWFkeSBhbnl3YXkgZnJvbSBvdGhlcnMgOi0pCnRoYW5rcyBmb3IgeW91ciBjb21tZW50cy4KPgo+ IFRoYW5rcwo+IEhlaWtvCj4KPgo+ClRoYW5rcwpaYWluCgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0Ckxp bnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752392AbbKCBIK (ORCPT ); Mon, 2 Nov 2015 20:08:10 -0500 Received: from regular1.263xmail.com ([211.150.99.130]:59856 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbbKCBIC (ORCPT ); Mon, 2 Nov 2015 20:08:02 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: zain.wang@rock-chips.com X-FST-TO: eddie.cai@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: zain.wang@rock-chips.com X-UNIQUE-TAG: <5034bcb3023949a1823fe53e6a9e7322> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [RESEND PATCH 1/4] Crypto: Crypto driver support aes/des/des3 for rk3288 To: Heiko Stuebner References: <1446193369-4453-1-git-send-email-zain.wang@rock-chips.com> <1446193369-4453-2-git-send-email-zain.wang@rock-chips.com> <2230290.pTq1BehVXW@phil> Cc: zhengsq@rock-chips.com, hl@rock-chips.com, herbert@gondor.apana.org.au, davem@davemloft.net, mturquette@baylibre.com, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, robh+dt@kernel.org, galak@codeaurora.org, linux@arm.linux.org.uk, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, eddie.cai@rock-chips.com From: Zain X-Enigmail-Draft-Status: N1110 Message-ID: <563808E3.5090005@rock-chips.com> Date: Tue, 3 Nov 2015 09:07:47 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <2230290.pTq1BehVXW@phil> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko, On 2015年10月30日 22:26, Heiko Stuebner wrote: > Hi, > > first of all, thanks for working on this, it will be really cool to see the > crypto accelerator supported in the kernel :-) > > Am Freitag, 30. Oktober 2015, 16:22:46 schrieb Zain Wang: >> Crypto driver support cbc/ecb two chainmode, and aes/des/des3 three cipher mode. >> The names registered are: >> ecb(aes) cbc(aes) ecb(des) cbc(des) ecb(des3_ede) cbc(des3_ede) >> You can alloc tags above in your case. >> >> And other algorithms and platforms will be added later on. >> >> Signed-off-by: Zain Wang >> --- >> drivers/crypto/Makefile | 1 + >> drivers/crypto/rk_crypto/Makefile | 3 + >> drivers/crypto/rk_crypto/rk3288_crypto.c | 393 ++++++++++++++++ >> drivers/crypto/rk_crypto/rk3288_crypto.h | 291 ++++++++++++ >> .../crypto/rk_crypto/rk3288_crypto_ablkcipher.c | 502 +++++++++++++++++++++ >> 5 files changed, 1190 insertions(+) >> create mode 100644 drivers/crypto/rk_crypto/Makefile >> create mode 100644 drivers/crypto/rk_crypto/rk3288_crypto.c >> create mode 100644 drivers/crypto/rk_crypto/rk3288_crypto.h >> create mode 100644 drivers/crypto/rk_crypto/rk3288_crypto_ablkcipher.c >> >> diff --git a/drivers/crypto/Makefile b/drivers/crypto/Makefile >> index c3ced6f..00d103c 100644 >> --- a/drivers/crypto/Makefile >> +++ b/drivers/crypto/Makefile >> @@ -29,3 +29,4 @@ obj-$(CONFIG_CRYPTO_DEV_QAT) += qat/ >> obj-$(CONFIG_CRYPTO_DEV_QCE) += qce/ >> obj-$(CONFIG_CRYPTO_DEV_VMX) += vmx/ >> obj-$(CONFIG_CRYPTO_DEV_SUN4I_SS) += sunxi-ss/ >> +obj-$(CONFIG_CRYPTO_DEV_RK3288) += rk_crypto/ > as Mark said in the other mail, there may very well follow other Rockchip > crypto-related drivers, so maybe it might be better to name the core > option CONFIG_CRYPTO_DEV_ROCKCHIP. And then maybe define > CONFIG_CRYPTO_DEV_RK3288 in a Kconfig in the subdirectory (like vmx does). ok! done! > > >> diff --git a/drivers/crypto/rk_crypto/Makefile b/drivers/crypto/rk_crypto/Makefile >> new file mode 100644 >> index 0000000..0f62d87 >> --- /dev/null >> +++ b/drivers/crypto/rk_crypto/Makefile > generally, a lot of those subdirectories reference only the manufacturer > name, so my suggestion would be to name yours just "rockchip" instead of > "rk_crypto", to also ease readability. ok! done! > > >> @@ -0,0 +1,3 @@ >> +obj-$(CONFIG_CRYPTO_DEV_RK3288) += rk_crypto_driver.o >> +rk_crypto_driver-objs := rk3288_crypto.o \ >> + rk3288_crypto_ablkcipher.o \ > that looks looks wrong. > > (1) the config option does not get defined in any Kconfig file in your set i am sorry about it, i will commit it next version. > (2) naming the driver generically while you compile a variant will hinder > multiplatform kernels, because you might want to build both the rk3288 > code and some additional stuff? i want to commit hash base on this patch later. > (3) the _driver suffix is unnecessary ok! done. > > So I guess just name it rk3288_crypto.o ? > > [...] > > While I have read through the code implementing the device, I haven't > seen anything spring out but do not know enough about the crypto subsystem > itself. But it looks like you got some feedback already anyway from others :-) thanks for your comments. > > Thanks > Heiko > > > Thanks Zain