All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/8] serial: altera_jtag_uart: minor clean up
Date: Tue, 3 Nov 2015 13:20:32 +0800	[thread overview]
Message-ID: <56384420.5060906@wytron.com.tw> (raw)
In-Reply-To: <1446189498-26549-2-git-send-email-thomas@wytron.com.tw>



On 2015?10?30? 15:18, Thomas Chou wrote:
> - Moved macro definitions to top
> - Give spaces around the '>>' in ALTERA_JTAG_WSPACE()
> - Re-arrange header includes ascending order
> - Remove unused header linux/compiler.h
> - Remove the penultimate comma in of_match ids
>
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> ---
>   drivers/serial/altera_jtag_uart.c | 25 ++++++++++++-------------
>   1 file changed, 12 insertions(+), 13 deletions(-)
>

Applied to u-boot-nios.

> diff --git a/drivers/serial/altera_jtag_uart.c b/drivers/serial/altera_jtag_uart.c
> index 0aa741c..fd69188 100644
> --- a/drivers/serial/altera_jtag_uart.c
> +++ b/drivers/serial/altera_jtag_uart.c
> @@ -8,18 +8,10 @@
>   #include <common.h>
>   #include <dm.h>
>   #include <errno.h>
> -#include <asm/io.h>
> -#include <linux/compiler.h>
>   #include <serial.h>
> +#include <asm/io.h>
>
> -struct altera_jtaguart_regs {
> -	u32	data;			/* Data register */
> -	u32	control;		/* Control register */
> -};
> -
> -struct altera_jtaguart_platdata {
> -	struct altera_jtaguart_regs *regs;
> -};
> +DECLARE_GLOBAL_DATA_PTR;
>
>   /* data register */
>   #define ALTERA_JTAG_RVALID	BIT(15)	/* Read valid */
> @@ -27,11 +19,18 @@ struct altera_jtaguart_platdata {
>   /* control register */
>   #define ALTERA_JTAG_AC		BIT(10)	/* activity indicator */
>   #define ALTERA_JTAG_RRDY	BIT(12)	/* read available */
> -#define ALTERA_JTAG_WSPACE(d)	((d)>>16)	/* Write space avail */
> +#define ALTERA_JTAG_WSPACE(d)	((d) >> 16)	/* Write space avail */
>   /* Write fifo size. FIXME: this should be extracted with sopc2dts */
>   #define ALTERA_JTAG_WRITE_DEPTH	64
>
> -DECLARE_GLOBAL_DATA_PTR;
> +struct altera_jtaguart_regs {
> +	u32	data;			/* Data register */
> +	u32	control;		/* Control register */
> +};
> +
> +struct altera_jtaguart_platdata {
> +	struct altera_jtaguart_regs *regs;
> +};
>
>   static int altera_jtaguart_setbrg(struct udevice *dev, int baudrate)
>   {
> @@ -112,7 +111,7 @@ static const struct dm_serial_ops altera_jtaguart_ops = {
>   };
>
>   static const struct udevice_id altera_jtaguart_ids[] = {
> -	{ .compatible = "altr,juart-1.0", },
> +	{ .compatible = "altr,juart-1.0" },
>   	{ }
>   };
>
>

  parent reply	other threads:[~2015-11-03  5:20 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-30  7:18 [U-Boot] [PATCH 1/8] serial: altera_jtag_uart: use BIT macro Thomas Chou
2015-10-30  7:18 ` [U-Boot] [PATCH 2/8] serial: altera_jtag_uart: minor clean up Thomas Chou
2015-10-30  8:09   ` Jagan Teki
2015-11-03  5:20   ` Thomas Chou [this message]
2015-10-30  7:18 ` [U-Boot] [PATCH 3/8] serial: altera_uart: use BIT macro Thomas Chou
2015-10-30  8:10   ` Jagan Teki
2015-11-03  5:20   ` Thomas Chou
2015-10-30  7:18 ` [U-Boot] [PATCH 4/8] serial: altera_uart: minor clean up Thomas Chou
2015-10-30  8:12   ` Jagan Teki
2015-11-03  5:21   ` Thomas Chou
2015-10-30  7:18 ` [U-Boot] [PATCH 5/8] timer: altera_timer: use BIT macro Thomas Chou
2015-10-30  8:13   ` Jagan Teki
2015-11-03  5:21   ` Thomas Chou
2015-10-30  7:18 ` [U-Boot] [PATCH 6/8] timer: altera_timer: minor clean up Thomas Chou
2015-10-30  8:13   ` Jagan Teki
2015-11-03  5:21   ` Thomas Chou
2015-10-30  7:18 ` [U-Boot] [PATCH 7/8] misc: altera_sysid: " Thomas Chou
2015-10-30  8:14   ` Jagan Teki
2015-11-03  5:21   ` Thomas Chou
2015-10-30  7:18 ` [U-Boot] [PATCH 8/8] spi: altera_spi: " Thomas Chou
2015-10-30  8:15   ` Jagan Teki
2015-11-03  5:22   ` Thomas Chou
2015-10-30  8:07 ` [U-Boot] [PATCH 1/8] serial: altera_jtag_uart: use BIT macro Jagan Teki
2015-11-03  5:19 ` Thomas Chou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56384420.5060906@wytron.com.tw \
    --to=thomas@wytron.com.tw \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.