Re: [Qemu-devel] [PATCH 00/19] buffer/vnc: improve vnc buffer hsndling

[Peter Lieven <pl@kamp.de>]

Am 30.10.2015 um 12:09 schrieb Gerd Hoffmann:
>    Hi,
>
> This series has a bunch of improvements in the vnc buffer handling,
> to reduce the memory footprint.  Some of the changes are applied to
> the buffer helper functions which Daniel separated out of the vnc code
> recently.
>
> Most patches have been on the list before, based on a older version of
> Daniel's "separate out buffer code" patches.  Now I finally managed to
> rebase and adapt the changes to the latest version which landed in
> master meanwhile.  I don't expect major issues showing up here and plan
> to have a pull request with this in time for 2.5-rc0.
>
> Peter, if you have anything pending not yet in here please rebase and
> resend.
>
> please review,
>    Gerd
>
> Gerd Hoffmann (14):
>    buffer: add buffer_init
>    buffer: add buffer_move_empty
>    buffer: add buffer_move
>    buffer: add buffer_shrink
>    buffer: add tracing
>    vnc: attach names to buffers
>    vnc: kill jobs queue buffer
>    vnc-jobs: move buffer reset, use new buffer move
>    vnc: zap dead code
>    vnc: add vnc_width+vnc_height helpers
>    vnc: factor out vnc_update_server_surface
>    vnc: use vnc_{width,height} in vnc_set_area_dirty
>    vnc: only alloc server surface with clients connected
>    vnc: fix local state init
All above: Reviewed-by: Peter Lieven <pl@kamp.de>

>
> Peter Lieven (5):
>    buffer: make the Buffer capacity increase in powers of two
>    vnc: recycle empty vs->output buffer
>    buffer: factor out buffer_req_size
>    buffer: factor out buffer_adj_size
>    buffer: allow a buffer to shrink gracefully

The last Patch isn't the latest version. I have one with improved comments here:

https://github.com/plieven/qemu/commit/e599748ab1ef381d4b1c88bf1ea1454dd89353fb

I also had another improvement:

https://github.com/plieven/qemu/commit/2b4180a5f4ec29a59de692e9aa512b7b4d8023e7

which limits the number of memmove operation in qio_buffer_advance.

Peter