From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [RFC v2 5/5] drm/dsi: Get DSI host by DT device node Date: Tue, 3 Nov 2015 12:50:14 +0530 Message-ID: <5638602E.9000604@codeaurora.org> References: <1435641851-27295-1-git-send-email-architt@codeaurora.org> <1444123482-25579-1-git-send-email-architt@codeaurora.org> <1444123482-25579-6-git-send-email-architt@codeaurora.org> <56374004.6040501@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <56374004.6040501@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andrzej Hajda , dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, treding@nvidia.com List-Id: linux-arm-msm@vger.kernel.org CgpPbiAxMS8wMi8yMDE1IDA0OjIwIFBNLCBBbmRyemVqIEhhamRhIHdyb3RlOgo+IE9uIDEwLzA2 LzIwMTUgMTE6MjQgQU0sIEFyY2hpdCBUYW5lamEgd3JvdGU6Cj4+IG1pcGlfZHNpX2RldmljZXMg YXJlIGluaGVyZW50bHkgYXdhcmUgb2YgdGhlaXIgaG9zdCBiZWNhdXNlIHRoZXkKPj4gc2hhcmUg YSBwYXJlbnQtY2hpbGQgaGllcmFyY2h5IGluIHRoZSBkZXZpY2UgdHJlZS4KPj4KPj4gTm9uLWRz aSBkcml2ZXJzIHRoYXQgY3JlYXRlIGEgZHVtbXkgZHNpIGRldmljZSBkb24ndCBoYXZlIHRoaXMg ZGF0YS4KPj4gSW4gb3JkZXIgdG8gZ2V0IHRoaXMgaW5mb3JtYXRpb24sIHRoZXkgcmVxdWlyZSB0 byBhIHBoYW5kbGUgdG8gdGhlIGRzaQo+PiBob3N0IGluIHRoZSBkZXZpY2UgdHJlZS4KPj4KPj4g TWFpbnRhaW4gYSBsaXN0IG9mIGFsbCB0aGUgaG9zdHMgRFNJIHRoYXQgYXJlIGN1cnJlbnRseSBy ZWdpc3RlcmVkLgo+Pgo+PiBUaGlzIGxpc3Qgd2lsbCBiZSB1c2VkIHRvIGZpbmQgdGhlIG1pcGlf ZHNpX2hvc3QgY29ycmVzcG9uZGluZyB0byB0aGUKPj4gZGV2aWNlX25vZGUgcGFzc2VkIGluIG9m X2ZpbmRfbWlwaV9kc2lfaG9zdF9ieV9ub2RlLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBBcmNoaXQg VGFuZWphIDxhcmNoaXR0QGNvZGVhdXJvcmEub3JnPgo+Cj4gTG9va3MgT0ssIGJlc2lkZSBsYWNr IG9mIGRvY3VtZW50YXRpb24sIGFmdGVyIGZpeGluZyBpdCB5b3UgY2FuIGFkZAo+IFJldmlld2Vk LWJ5OiBBbmRyemVqIEhhamRhIDxhLmhhamRhQHNhbXN1bmcuY29tPgoKSSB3aWxsIGFkZCBtaXNz aW5nIGRvY3VtZW50YXRpb24gYmVmb3JlIHBvc3RpbmcgdjMuCgpUaGFua3MgYWdhaW4gZm9yIHRo ZSByZXZpZXcuCgpBcmNoaXQKCj4KPiBSZWdhcmRzCj4gQW5kcnplago+Cj4+IC0tLQo+PiAgIGRy aXZlcnMvZ3B1L2RybS9kcm1fbWlwaV9kc2kuYyB8IDMwICsrKysrKysrKysrKysrKysrKysrKysr KysrKysrKwo+PiAgIGluY2x1ZGUvZHJtL2RybV9taXBpX2RzaS5oICAgICB8ICAyICsrCj4+ICAg MiBmaWxlcyBjaGFuZ2VkLCAzMiBpbnNlcnRpb25zKCspCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vZHJtX21pcGlfZHNpLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX21pcGlfZHNp LmMKPj4gaW5kZXggY2JiNzM3My4uYzUxZDczZSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2RybV9taXBpX2RzaS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fbWlwaV9kc2ku Ywo+PiBAQCAtMjE2LDYgKzIxNiwyOCBAQCBvZl9taXBpX2RzaV9kZXZpY2VfYWRkKHN0cnVjdCBt aXBpX2RzaV9ob3N0ICpob3N0LCBzdHJ1Y3QgZGV2aWNlX25vZGUgKm5vZGUpCj4+ICAgCXJldHVy biBtaXBpX2RzaV9kZXZpY2VfbmV3KGhvc3QsICZpbmZvKTsKPj4gICB9Cj4+Cj4+ICtzdGF0aWMg REVGSU5FX01VVEVYKGhvc3RfbG9jayk7Cj4+ICtzdGF0aWMgTElTVF9IRUFEKGhvc3RfbGlzdCk7 Cj4+ICsKPj4gK3N0cnVjdCBtaXBpX2RzaV9ob3N0ICpvZl9maW5kX21pcGlfZHNpX2hvc3RfYnlf bm9kZShzdHJ1Y3QgZGV2aWNlX25vZGUgKm5vZGUpCj4+ICt7Cj4+ICsJc3RydWN0IG1pcGlfZHNp X2hvc3QgKmhvc3Q7Cj4+ICsKPj4gKwltdXRleF9sb2NrKCZob3N0X2xvY2spOwo+PiArCj4+ICsJ bGlzdF9mb3JfZWFjaF9lbnRyeShob3N0LCAmaG9zdF9saXN0LCBsaXN0KSB7Cj4+ICsJCWlmICho b3N0LT5kZXYtPm9mX25vZGUgPT0gbm9kZSkgewo+PiArCQkJbXV0ZXhfdW5sb2NrKCZob3N0X2xv Y2spOwo+PiArCQkJcmV0dXJuIGhvc3Q7Cj4+ICsJCX0KPj4gKwl9Cj4+ICsKPj4gKwltdXRleF91 bmxvY2soJmhvc3RfbG9jayk7Cj4+ICsKPj4gKwlyZXR1cm4gTlVMTDsKPj4gK30KPj4gK0VYUE9S VF9TWU1CT0wob2ZfZmluZF9taXBpX2RzaV9ob3N0X2J5X25vZGUpOwo+PiArCj4+ICAgaW50IG1p cGlfZHNpX2hvc3RfcmVnaXN0ZXIoc3RydWN0IG1pcGlfZHNpX2hvc3QgKmhvc3QpCj4+ICAgewo+ PiAgIAlzdHJ1Y3QgZGV2aWNlX25vZGUgKm5vZGU7Cj4+IEBAIC0yMjcsNiArMjQ5LDEwIEBAIGlu dCBtaXBpX2RzaV9ob3N0X3JlZ2lzdGVyKHN0cnVjdCBtaXBpX2RzaV9ob3N0ICpob3N0KQo+PiAg IAkJb2ZfbWlwaV9kc2lfZGV2aWNlX2FkZChob3N0LCBub2RlKTsKPj4gICAJfQo+Pgo+PiArCW11 dGV4X2xvY2soJmhvc3RfbG9jayk7Cj4+ICsJbGlzdF9hZGRfdGFpbCgmaG9zdC0+bGlzdCwgJmhv c3RfbGlzdCk7Cj4+ICsJbXV0ZXhfdW5sb2NrKCZob3N0X2xvY2spOwo+PiArCj4+ICAgCXJldHVy biAwOwo+PiAgIH0KPj4gICBFWFBPUlRfU1lNQk9MKG1pcGlfZHNpX2hvc3RfcmVnaXN0ZXIpOwo+ PiBAQCAtMjQzLDYgKzI2OSwxMCBAQCBzdGF0aWMgaW50IG1pcGlfZHNpX3JlbW92ZV9kZXZpY2Vf Zm4oc3RydWN0IGRldmljZSAqZGV2LCB2b2lkICpwcml2KQo+PiAgIHZvaWQgbWlwaV9kc2lfaG9z dF91bnJlZ2lzdGVyKHN0cnVjdCBtaXBpX2RzaV9ob3N0ICpob3N0KQo+PiAgIHsKPj4gICAJZGV2 aWNlX2Zvcl9lYWNoX2NoaWxkKGhvc3QtPmRldiwgTlVMTCwgbWlwaV9kc2lfcmVtb3ZlX2Rldmlj ZV9mbik7Cj4+ICsKPj4gKwltdXRleF9sb2NrKCZob3N0X2xvY2spOwo+PiArCWxpc3RfZGVsX2lu aXQoJmhvc3QtPmxpc3QpOwo+PiArCW11dGV4X3VubG9jaygmaG9zdF9sb2NrKTsKPj4gICB9Cj4+ ICAgRVhQT1JUX1NZTUJPTChtaXBpX2RzaV9ob3N0X3VucmVnaXN0ZXIpOwo+Pgo+PiBkaWZmIC0t Z2l0IGEvaW5jbHVkZS9kcm0vZHJtX21pcGlfZHNpLmggYi9pbmNsdWRlL2RybS9kcm1fbWlwaV9k c2kuaAo+PiBpbmRleCA2OGY0OWY0Li4xNWQzMDY4IDEwMDY0NAo+PiAtLS0gYS9pbmNsdWRlL2Ry bS9kcm1fbWlwaV9kc2kuaAo+PiArKysgYi9pbmNsdWRlL2RybS9kcm1fbWlwaV9kc2kuaAo+PiBA QCAtMTAwLDEwICsxMDAsMTIgQEAgc3RydWN0IG1pcGlfZHNpX2hvc3Rfb3BzIHsKPj4gICBzdHJ1 Y3QgbWlwaV9kc2lfaG9zdCB7Cj4+ICAgCXN0cnVjdCBkZXZpY2UgKmRldjsKPj4gICAJY29uc3Qg c3RydWN0IG1pcGlfZHNpX2hvc3Rfb3BzICpvcHM7Cj4+ICsJc3RydWN0IGxpc3RfaGVhZCBsaXN0 Owo+PiAgIH07Cj4+Cj4+ICAgaW50IG1pcGlfZHNpX2hvc3RfcmVnaXN0ZXIoc3RydWN0IG1pcGlf ZHNpX2hvc3QgKmhvc3QpOwo+PiAgIHZvaWQgbWlwaV9kc2lfaG9zdF91bnJlZ2lzdGVyKHN0cnVj dCBtaXBpX2RzaV9ob3N0ICpob3N0KTsKPj4gK3N0cnVjdCBtaXBpX2RzaV9ob3N0ICpvZl9maW5k X21pcGlfZHNpX2hvc3RfYnlfbm9kZShzdHJ1Y3QgZGV2aWNlX25vZGUgKm5vZGUpOwo+Pgo+PiAg IC8qIERTSSBtb2RlIGZsYWdzICovCj4+Cj4KCi0tIApUaGUgUXVhbGNvbW0gSW5ub3ZhdGlvbiBD ZW50ZXIsIEluYy4gaXMgYSBtZW1iZXIgb2YgdGhlIENvZGUgQXVyb3JhIApGb3J1bSwgaG9zdGVk IGJ5IFRoZSBMaW51eCBGb3VuZGF0aW9uCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932085AbbKCHUW (ORCPT ); Tue, 3 Nov 2015 02:20:22 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:49366 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751803AbbKCHUV (ORCPT ); Tue, 3 Nov 2015 02:20:21 -0500 Subject: Re: [RFC v2 5/5] drm/dsi: Get DSI host by DT device node To: Andrzej Hajda , dri-devel@lists.freedesktop.org References: <1435641851-27295-1-git-send-email-architt@codeaurora.org> <1444123482-25579-1-git-send-email-architt@codeaurora.org> <1444123482-25579-6-git-send-email-architt@codeaurora.org> <56374004.6040501@samsung.com> Cc: linux-kernel@vger.kernel.org, airlied@linux.ie, daniel@ffwll.ch, treding@nvidia.com, l.stach@pengutronix.de, robh@kernel.org, linux-arm-msm@vger.kernel.org, jani.nikula@linux.intel.com From: Archit Taneja Message-ID: <5638602E.9000604@codeaurora.org> Date: Tue, 3 Nov 2015 12:50:14 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <56374004.6040501@samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/02/2015 04:20 PM, Andrzej Hajda wrote: > On 10/06/2015 11:24 AM, Archit Taneja wrote: >> mipi_dsi_devices are inherently aware of their host because they >> share a parent-child hierarchy in the device tree. >> >> Non-dsi drivers that create a dummy dsi device don't have this data. >> In order to get this information, they require to a phandle to the dsi >> host in the device tree. >> >> Maintain a list of all the hosts DSI that are currently registered. >> >> This list will be used to find the mipi_dsi_host corresponding to the >> device_node passed in of_find_mipi_dsi_host_by_node. >> >> Signed-off-by: Archit Taneja > > Looks OK, beside lack of documentation, after fixing it you can add > Reviewed-by: Andrzej Hajda I will add missing documentation before posting v3. Thanks again for the review. Archit > > Regards > Andrzej > >> --- >> drivers/gpu/drm/drm_mipi_dsi.c | 30 ++++++++++++++++++++++++++++++ >> include/drm/drm_mipi_dsi.h | 2 ++ >> 2 files changed, 32 insertions(+) >> >> diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c >> index cbb7373..c51d73e 100644 >> --- a/drivers/gpu/drm/drm_mipi_dsi.c >> +++ b/drivers/gpu/drm/drm_mipi_dsi.c >> @@ -216,6 +216,28 @@ of_mipi_dsi_device_add(struct mipi_dsi_host *host, struct device_node *node) >> return mipi_dsi_device_new(host, &info); >> } >> >> +static DEFINE_MUTEX(host_lock); >> +static LIST_HEAD(host_list); >> + >> +struct mipi_dsi_host *of_find_mipi_dsi_host_by_node(struct device_node *node) >> +{ >> + struct mipi_dsi_host *host; >> + >> + mutex_lock(&host_lock); >> + >> + list_for_each_entry(host, &host_list, list) { >> + if (host->dev->of_node == node) { >> + mutex_unlock(&host_lock); >> + return host; >> + } >> + } >> + >> + mutex_unlock(&host_lock); >> + >> + return NULL; >> +} >> +EXPORT_SYMBOL(of_find_mipi_dsi_host_by_node); >> + >> int mipi_dsi_host_register(struct mipi_dsi_host *host) >> { >> struct device_node *node; >> @@ -227,6 +249,10 @@ int mipi_dsi_host_register(struct mipi_dsi_host *host) >> of_mipi_dsi_device_add(host, node); >> } >> >> + mutex_lock(&host_lock); >> + list_add_tail(&host->list, &host_list); >> + mutex_unlock(&host_lock); >> + >> return 0; >> } >> EXPORT_SYMBOL(mipi_dsi_host_register); >> @@ -243,6 +269,10 @@ static int mipi_dsi_remove_device_fn(struct device *dev, void *priv) >> void mipi_dsi_host_unregister(struct mipi_dsi_host *host) >> { >> device_for_each_child(host->dev, NULL, mipi_dsi_remove_device_fn); >> + >> + mutex_lock(&host_lock); >> + list_del_init(&host->list); >> + mutex_unlock(&host_lock); >> } >> EXPORT_SYMBOL(mipi_dsi_host_unregister); >> >> diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h >> index 68f49f4..15d3068 100644 >> --- a/include/drm/drm_mipi_dsi.h >> +++ b/include/drm/drm_mipi_dsi.h >> @@ -100,10 +100,12 @@ struct mipi_dsi_host_ops { >> struct mipi_dsi_host { >> struct device *dev; >> const struct mipi_dsi_host_ops *ops; >> + struct list_head list; >> }; >> >> int mipi_dsi_host_register(struct mipi_dsi_host *host); >> void mipi_dsi_host_unregister(struct mipi_dsi_host *host); >> +struct mipi_dsi_host *of_find_mipi_dsi_host_by_node(struct device_node *node); >> >> /* DSI mode flags */ >> > -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation