Re: [PATCH] vhost-user: enable virtio 1.0

[Marcel Apfelbaum <marcel@redhat.com>]

On 11/03/2015 05:49 AM, Xu, Qian Q wrote:
> Sorry, correct the kernel info, my kernel version is 4.1.8-100.fc21.x86_64.

Hi,

This is weird, VIRTIO_F_VERSION_1 is defined in 4.0 (I think), and for sure in 4.1 .
You can see commit 4ec22fae (virtio: add virtio 1.0 feature bit) from 2014-10-22 in kernel git.

Can you please check a mismatch in header files of your development machine?

Thanks,
Marcel

>
> Thanks
> Qian
>
>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xu, Qian Q
> Sent: Tuesday, November 03, 2015 11:45 AM
> To: Thomas Monjalon; Marcel Apfelbaum
> Cc: dev@dpdk.org; Michael S. Tsirkin
> Subject: Re: [dpdk-dev] [PATCH] vhost-user: enable virtio 1.0
>
> DPDK GCC 64bit build on kernel 3.18 will be failed, could you help check?
>
> == Build lib/librte_pipeline
> /home/qxu10/virtio-opt-test/dpdk/lib/librte_vhost/virtio-net.c:81:106: error: 'VIRTIO_F_VERSION_1' undeclared here (not in a function) static uint64_t VHOST_FEATURES = VHOST_SUPPORTED_FEATURES;
>                                                                                                            ^
> /home/qxu10/virtio-opt-test/dpdk/mk/internal/rte.compile-pre.mk:126: recipe for target 'virtio-net.o' failed
> make[5]: *** [virtio-net.o] Error 1
> /home/qxu10/virtio-opt-test/dpdk/mk/rte.subdir.mk:61: recipe for target 'librte_vhost' failed
> make[4]: *** [librte_vhost] Error 2
> make[4]: *** Waiting for unfinished jobs....
>    SYMLINK-FILE include/rte_pipeline.h
>    CC rte_pipeline.o
>    AR librte_pipeline.a
>    INSTALL-LIB librte_pipeline.a
> /home/qxu10/virtio-opt-test/dpdk/mk/rte.sdkbuild.mk:93: recipe for target 'lib' failed
> make[3]: *** [lib] Error 2
> /home/qxu10/virtio-opt-test/dpdk/mk/rte.sdkroot.mk:124: recipe for target 'all' failed
> make[2]: *** [all] Error 2
> /home/qxu10/virtio-opt-test/dpdk/mk/rte.sdkinstall.mk:58: recipe for target 'x86_64-native-linuxapp-gcc_install' failed
> make[1]: *** [x86_64-native-linuxapp-gcc_install] Error 2
> /home/qxu10/virtio-opt-test/dpdk/mk/rte.sdkroot.mk:102: recipe for target 'install' failed
> make: *** [install] Error 2
>
> Thanks
> Qian
>
>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Tuesday, November 03, 2015 6:14 AM
> To: Marcel Apfelbaum
> Cc: dev@dpdk.org; Michael S. Tsirkin
> Subject: Re: [dpdk-dev] [PATCH] vhost-user: enable virtio 1.0
>
>>> Make vhost-user virtio 1.0 compatible by adding it to the supported
>>> features and keeping the header length the same as for mergeable RX
>>> buffers.
>>>
>>> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
>>
>> Looks good to me
>>
>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>
> Applied, thanks
>