From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH v2 1/4] clocksource: rockchip: Make the driver more compatible Date: Tue, 3 Nov 2015 09:32:16 +0100 Message-ID: <56387110.4060805@linaro.org> References: <1443147298-12603-1-git-send-email-wxt@rock-chips.com> <5632E765.4010207@gmail.com> <56334995.6090103@linaro.org> <21587719.mnFBFBzBeI@phil> <56379D46.1000402@linaro.org> <56381547.5070109@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <56381547.5070109-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Caesar Wang Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Heiko Stuebner , Arnd Bergmann , catalin.marinas-5wv7dgnIgG8@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Caesar Wang List-Id: linux-rockchip.vger.kernel.org T24gMTEvMDMvMjAxNSAwMzowMCBBTSwgQ2Flc2FyIFdhbmcgd3JvdGU6Cj4gRGFuaWVsLAo+Cj4g 5ZyoIDIwMTXlubQxMeaciDAz5pelIDAxOjI4LCBEYW5pZWwgTGV6Y2FubyDlhpnpgZM6Cj4+IE9u IDEwLzMxLzIwMTUgMTI6NDcgQU0sIEhlaWtvIFN0dWVibmVyIHdyb3RlOgo+Pj4gSGkgRGFuaWVs LAo+Pj4KPj4+IEFtIEZyZWl0YWcsIDMwLiBPa3RvYmVyIDIwMTUsIDExOjQyOjI5IHNjaHJpZWIg RGFuaWVsIExlemNhbm86Cj4+Pj4gT24gMTAvMzAvMjAxNSAwNDo0MyBBTSwgQ2Flc2FyIFdhbmcg d3JvdGU6Cj4+Pj4+IEhpIERhbmllbCwKPj4+Pj4KPj4+Pj4g5ZyoIDIwMTXlubQxMOaciDAx5pel IDAzOjE0LCBIZWlrbyBTdMO8Ym5lciDlhpnpgZM6Cj4+Pj4+PiBIaSBEYW5pZWwsCj4+Pj4+Pgo+ Pj4+Pj4gQW0gRGllbnN0YWcsIDI5LiBTZXB0ZW1iZXIgMjAxNSwgMDY6MTg6MDMgc2NocmllYiBE YW5pZWwgTGV6Y2FubzoKPj4+Pj4+PiBPbiAwOS8yNS8yMDE1IDA0OjE0IEFNLCBDYWVzYXIgV2Fu ZyB3cm90ZToKPj4+Pj4+Pj4gQnVpbGQgdGhlIGFybTY0IFNvQ3MgKGUuZy46IFJLMzM2OCkgb24g Um9ja2NoaXAgcGxhdGZvcm0sCj4+Pj4+Pj4+IFRoZXJlIGFyZSBzb21lIGZhaWx1cmUgd2l0aCBi dWlsZCB1cCBvbiB0aW1lciBkcml2ZXIgZm9yIHJvY2tjaGlwLgo+Pj4+Pj4+Pgo+Pj4+Pj4+PiBT YXlzOgo+Pj4+Pj4+PiAvdG1wL2NjZEFuTnk1LnM6NDc6IEVycm9yOiBtaXNzaW5nIGltbWVkaWF0 ZSBleHByZXNzaW9uIGF0ICBvcGVyYW5kCj4+Pj4+Pj4+IDEgLS0KPj4+Pj4+Pj4gYGRzYmAKPj4+ Pj4+Pj4gLi4uCj4+Pj4+Pj4+Cj4+Pj4+Pj4+IFRoZSBwcm9ibGVtIHdhcyBkaWZmZXJlbnQgc2Vt YW50aWNzIG9mIGRzYiBvbiBidHcgYXJtMzIgYW5kIGFybTY0LAo+Pj4+Pj4+PiBIZXJlIHdlIGNh biBjb252ZXJ0IHRoZSBkc2Igd2l0aCBpbnN0ZWFkaW5nIG9mIGRzYihzeSkuVGhlICJzeSIKPj4+ Pj4+Pj4gcGFyYW0KPj4+Pj4+Pj4gaXMgdGhlIGRlZmF1bHQgd2hpY2ggeW91IGFyZSBhbGxvdyB0 byBvbWl0LCBzbyBvbiBhcm0zMiBkc2IoKWFuZAo+Pj4+Pj4+PiBkc2Ioc3kpCj4+Pj4+Pj4+IGFy ZSB0aGUgc2FtZS4KPj4+Pj4+Pj4KPj4+Pj4+Pj4gU2lnbmVkLW9mZi1ieTogQ2Flc2FyIFdhbmcg PHd4dEByb2NrLWNoaXBzLmNvbT4KPj4+Pj4+PiBBY2tlZC1ieTogRGFuaWVsIExlemNhbm8gPGRh bmllbC5sZXpjYW5vQGxpbmFyby5vcmc+Cj4+Pj4+PiBhcyB5b3UgaGF2ZSAianVzdCIgQWNrZWQg dGhlc2UgcGF0Y2hlcywgSSBndWVzcyB5b3UgYXJlIGV4cGVjdGluZwo+Pj4+Pj4gdGhlbQo+Pj4+ Pj4gdG8gZ28KPj4+Pj4+IHRocm91Z2ggdGhlIHNhbWUgdHJlZSBhcyB0aGUgZGV2aWNldHJlZSBj aGFuZ2VzLCByaWdodD8KPj4+Pj4KPj4+Pj4gSSdtIHdvbmRlciBpZiBzb21lb25lIHdpbGwgYXBw bHkgdGhpcyBzZXJpZXMgcGF0Y2hzIGJ1dCB0aGUgd2FpdC46LSkKPj4+Pj4gSW4gZmFjdCwgSSdt IG5vIHN1cmUgdGhhdCB0aGUgQWNrZWQgaXMgcmVhbGx5IG1lYW5pbmcuOi0KPj4+Pgo+Pj4+IFll cywgYnkgYWNraW5nIHRoZSBwYXRjaCBJIHNheSBJIGFtIG9rIHdpdGggaXQgYW5kIEkgYWdyZWUg aXQgY2FuIGdvCj4+Pj4gdGhyb3VnaCBhbm90aGVyIHRyZWUuCj4+Pgo+Pj4gYWx0aG91Z2ggSSBn dWVzcyB0aGUgdHdvIGNsb2Nrc291cmNlIGNoYW5nZXMgY291bGQgdmVyeSB3ZWxsIGp1c3QgZ28K Pj4+IHRocm91Z2ggeW91ciB0cmVlLiBkc2IoKSAtPiBkc2Ioc3kpIGlzIHN1cHBvc2VkIHRvIGJl IGVxdWFsIGFuZCB0aGUKPj4+IHNlY29uZAo+Pj4gb25lIGlzIGp1c3QgY29zbWV0aWNzLiAgVGhl IEtjb25maWcgYW5kIGR0cyBjaGFuZ2VzIG5lZWQgdG8gd2FpdCBpbgo+Pj4gYW55IGNhc2UKPj4+ IGZvciA0LjUgLi4uIGJ1dCBJIGd1ZXNzIHRoYXQgbWF5IGJlIHRydWUgZm9yIHRoZSBjbG9ja3Nv dXJjZSBjaGFuZ2VzCj4+PiBhcyB3ZWxsPwo+Pgo+PiBIZWlrbywgQ2Flc2FyLAo+Pgo+PiBJIGFt IHdvbmRlcmluZyBpZiB0aGUgZHNiKCkgaXMgcmVhbGx5IG5lY2Vzc2FyeS4gSXMgaXQgcG9zc2li bGUgeW91Cj4+IHRlc3QgdGhlIHRpbWVyIGJ5IHJlbW92aW5nIHRoaXMgaW5zdHJ1Y3Rpb24gPyBP dGhlcndpc2UgSSB3aWxsIGhhdmUgdG8KPj4gc2V0dXAgbXkgYm9hcmQgYWdhaW4gYW5kIGl0IHdp bGwgdGFrZSBhd2hpbGUuCj4+Cj4KPiBBcyB0aGUgQEFybmQgc3VnZ2VzdGlvbiwKPgo+IFRoYXQn cyBzZWVtIG9rIGZvciBtZS4KPiBBbHRob3VnaCB0aGUgd3JpdGVsX3JlbGF4ZWQoKSBhbmQgd3Jp dGVsKCkgYSBiaXQgZGlmZmVyZW50ICB3aXRoIERTQigpCj4gYW5kIEwyJ3Mgc3luYy4KPgo+IERv IEkgbmVlZCBzZW5kIHRoZSBwYXRjaCB2Mz8gIEkgd2lsbCB0ZXN0IHRoYXQgb24gbXkgYm9hcmQu Cj4KPiBJJ20gbm8gc3VyZSB0aGF0IHdoeSB0aGUgY2xvY2tzb3VyY2UgZHJpdmVyIGRpZG4ndCB1 c2UgdGhlCj4gd3JpdGVsX3JlbGF4ZWQoKSB0byB3b3JrLgo+IE9rYXksIEkgdGhpbmsgd2Ugc2hv dWxkIGFjY29yZGluZyB0byB0aGUgc3VnZ2VzdGlvbiBvciByZXF1aXJlZC4KCkkgdGhpbmsgdGhl IHBhdGNoIGlzIHRyaXZpYWwgZW5vdWdoIEkgY2FuIGRvIHRoZSBjaGFuZ2UgbXlzZWxmIGlmIHlv dSAKdGVzdCB0aGUgY2hhbmdlIG9uIHlvdXIgc2lkZS4gQnV0IGl0IHdvdWxkIGJlIGEgZ29vZCBw cmFjdGljZSB0byBzZW5kIAp0aGUgcGF0Y2ggeW91IGhhdmUgdGVzdGVkLiBVcCB0byB5b3UgOykK ClRoYW5rcyAhCgogICAtLSBEYW5pZWwKCgotLSAKICA8aHR0cDovL3d3dy5saW5hcm8ub3JnLz4g TGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFSTSBTb0NzCgpGb2xsb3cg TGluYXJvOiAgPGh0dHA6Ly93d3cuZmFjZWJvb2suY29tL3BhZ2VzL0xpbmFybz4gRmFjZWJvb2sg fAo8aHR0cDovL3R3aXR0ZXIuY29tLyMhL2xpbmFyb29yZz4gVHdpdHRlciB8CjxodHRwOi8vd3d3 LmxpbmFyby5vcmcvbGluYXJvLWJsb2cvPiBCbG9nCgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KTGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4 LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel.lezcano@linaro.org (Daniel Lezcano) Date: Tue, 3 Nov 2015 09:32:16 +0100 Subject: [PATCH v2 1/4] clocksource: rockchip: Make the driver more compatible In-Reply-To: <56381547.5070109@gmail.com> References: <1443147298-12603-1-git-send-email-wxt@rock-chips.com> <5632E765.4010207@gmail.com> <56334995.6090103@linaro.org> <21587719.mnFBFBzBeI@phil> <56379D46.1000402@linaro.org> <56381547.5070109@gmail.com> Message-ID: <56387110.4060805@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/03/2015 03:00 AM, Caesar Wang wrote: > Daniel, > > ? 2015?11?03? 01:28, Daniel Lezcano ??: >> On 10/31/2015 12:47 AM, Heiko Stuebner wrote: >>> Hi Daniel, >>> >>> Am Freitag, 30. Oktober 2015, 11:42:29 schrieb Daniel Lezcano: >>>> On 10/30/2015 04:43 AM, Caesar Wang wrote: >>>>> Hi Daniel, >>>>> >>>>> ? 2015?10?01? 03:14, Heiko St?bner ??: >>>>>> Hi Daniel, >>>>>> >>>>>> Am Dienstag, 29. September 2015, 06:18:03 schrieb Daniel Lezcano: >>>>>>> On 09/25/2015 04:14 AM, Caesar Wang wrote: >>>>>>>> Build the arm64 SoCs (e.g.: RK3368) on Rockchip platform, >>>>>>>> There are some failure with build up on timer driver for rockchip. >>>>>>>> >>>>>>>> Says: >>>>>>>> /tmp/ccdAnNy5.s:47: Error: missing immediate expression at operand >>>>>>>> 1 -- >>>>>>>> `dsb` >>>>>>>> ... >>>>>>>> >>>>>>>> The problem was different semantics of dsb on btw arm32 and arm64, >>>>>>>> Here we can convert the dsb with insteading of dsb(sy).The "sy" >>>>>>>> param >>>>>>>> is the default which you are allow to omit, so on arm32 dsb()and >>>>>>>> dsb(sy) >>>>>>>> are the same. >>>>>>>> >>>>>>>> Signed-off-by: Caesar Wang >>>>>>> Acked-by: Daniel Lezcano >>>>>> as you have "just" Acked these patches, I guess you are expecting >>>>>> them >>>>>> to go >>>>>> through the same tree as the devicetree changes, right? >>>>> >>>>> I'm wonder if someone will apply this series patchs but the wait.:-) >>>>> In fact, I'm no sure that the Acked is really meaning.:- >>>> >>>> Yes, by acking the patch I say I am ok with it and I agree it can go >>>> through another tree. >>> >>> although I guess the two clocksource changes could very well just go >>> through your tree. dsb() -> dsb(sy) is supposed to be equal and the >>> second >>> one is just cosmetics. The Kconfig and dts changes need to wait in >>> any case >>> for 4.5 ... but I guess that may be true for the clocksource changes >>> as well? >> >> Heiko, Caesar, >> >> I am wondering if the dsb() is really necessary. Is it possible you >> test the timer by removing this instruction ? Otherwise I will have to >> setup my board again and it will take awhile. >> > > As the @Arnd suggestion, > > That's seem ok for me. > Although the writel_relaxed() and writel() a bit different with DSB() > and L2's sync. > > Do I need send the patch v3? I will test that on my board. > > I'm no sure that why the clocksource driver didn't use the > writel_relaxed() to work. > Okay, I think we should according to the suggestion or required. I think the patch is trivial enough I can do the change myself if you test the change on your side. But it would be a good practice to send the patch you have tested. Up to you ;) Thanks ! -- Daniel -- Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752929AbbKCIcV (ORCPT ); Tue, 3 Nov 2015 03:32:21 -0500 Received: from mail-wi0-f176.google.com ([209.85.212.176]:34379 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751359AbbKCIcT (ORCPT ); Tue, 3 Nov 2015 03:32:19 -0500 Subject: Re: [PATCH v2 1/4] clocksource: rockchip: Make the driver more compatible To: Caesar Wang References: <1443147298-12603-1-git-send-email-wxt@rock-chips.com> <5632E765.4010207@gmail.com> <56334995.6090103@linaro.org> <21587719.mnFBFBzBeI@phil> <56379D46.1000402@linaro.org> <56381547.5070109@gmail.com> Cc: Heiko Stuebner , devicetree@vger.kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Caesar Wang , Arnd Bergmann From: Daniel Lezcano Message-ID: <56387110.4060805@linaro.org> Date: Tue, 3 Nov 2015 09:32:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56381547.5070109@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/03/2015 03:00 AM, Caesar Wang wrote: > Daniel, > > 在 2015年11月03日 01:28, Daniel Lezcano 写道: >> On 10/31/2015 12:47 AM, Heiko Stuebner wrote: >>> Hi Daniel, >>> >>> Am Freitag, 30. Oktober 2015, 11:42:29 schrieb Daniel Lezcano: >>>> On 10/30/2015 04:43 AM, Caesar Wang wrote: >>>>> Hi Daniel, >>>>> >>>>> 在 2015年10月01日 03:14, Heiko Stübner 写道: >>>>>> Hi Daniel, >>>>>> >>>>>> Am Dienstag, 29. September 2015, 06:18:03 schrieb Daniel Lezcano: >>>>>>> On 09/25/2015 04:14 AM, Caesar Wang wrote: >>>>>>>> Build the arm64 SoCs (e.g.: RK3368) on Rockchip platform, >>>>>>>> There are some failure with build up on timer driver for rockchip. >>>>>>>> >>>>>>>> Says: >>>>>>>> /tmp/ccdAnNy5.s:47: Error: missing immediate expression at operand >>>>>>>> 1 -- >>>>>>>> `dsb` >>>>>>>> ... >>>>>>>> >>>>>>>> The problem was different semantics of dsb on btw arm32 and arm64, >>>>>>>> Here we can convert the dsb with insteading of dsb(sy).The "sy" >>>>>>>> param >>>>>>>> is the default which you are allow to omit, so on arm32 dsb()and >>>>>>>> dsb(sy) >>>>>>>> are the same. >>>>>>>> >>>>>>>> Signed-off-by: Caesar Wang >>>>>>> Acked-by: Daniel Lezcano >>>>>> as you have "just" Acked these patches, I guess you are expecting >>>>>> them >>>>>> to go >>>>>> through the same tree as the devicetree changes, right? >>>>> >>>>> I'm wonder if someone will apply this series patchs but the wait.:-) >>>>> In fact, I'm no sure that the Acked is really meaning.:- >>>> >>>> Yes, by acking the patch I say I am ok with it and I agree it can go >>>> through another tree. >>> >>> although I guess the two clocksource changes could very well just go >>> through your tree. dsb() -> dsb(sy) is supposed to be equal and the >>> second >>> one is just cosmetics. The Kconfig and dts changes need to wait in >>> any case >>> for 4.5 ... but I guess that may be true for the clocksource changes >>> as well? >> >> Heiko, Caesar, >> >> I am wondering if the dsb() is really necessary. Is it possible you >> test the timer by removing this instruction ? Otherwise I will have to >> setup my board again and it will take awhile. >> > > As the @Arnd suggestion, > > That's seem ok for me. > Although the writel_relaxed() and writel() a bit different with DSB() > and L2's sync. > > Do I need send the patch v3? I will test that on my board. > > I'm no sure that why the clocksource driver didn't use the > writel_relaxed() to work. > Okay, I think we should according to the suggestion or required. I think the patch is trivial enough I can do the change myself if you test the change on your side. But it would be a good practice to send the patch you have tested. Up to you ;) Thanks ! -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog