From mboxrd@z Thu Jan 1 00:00:00 1970 From: Caesar Wang Subject: Re: [PATCH v2 1/4] clocksource: rockchip: Make the driver more compatible Date: Tue, 3 Nov 2015 17:59:05 +0800 Message-ID: <56388569.1070108@gmail.com> References: <1443147298-12603-1-git-send-email-wxt@rock-chips.com> <5632E765.4010207@gmail.com> <56334995.6090103@linaro.org> <21587719.mnFBFBzBeI@phil> <56379D46.1000402@linaro.org> <56381547.5070109@gmail.com> <56387110.4060805@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <56387110.4060805-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Daniel Lezcano Cc: Caesar Wang , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Heiko Stuebner , Arnd Bergmann , catalin.marinas-5wv7dgnIgG8@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Caesar Wang List-Id: linux-rockchip.vger.kernel.org CgrlnKggMjAxNeW5tDEx5pyIMDPml6UgMTY6MzIsIERhbmllbCBMZXpjYW5vIOWGmemBkzoKPiBP biAxMS8wMy8yMDE1IDAzOjAwIEFNLCBDYWVzYXIgV2FuZyB3cm90ZToKPj4gRGFuaWVsLAo+Pgo+ PiDlnKggMjAxNeW5tDEx5pyIMDPml6UgMDE6MjgsIERhbmllbCBMZXpjYW5vIOWGmemBkzoKPj4+ IE9uIDEwLzMxLzIwMTUgMTI6NDcgQU0sIEhlaWtvIFN0dWVibmVyIHdyb3RlOgo+Pj4+IEhpIERh bmllbCwKPj4+Pgo+Pj4+IEFtIEZyZWl0YWcsIDMwLiBPa3RvYmVyIDIwMTUsIDExOjQyOjI5IHNj aHJpZWIgRGFuaWVsIExlemNhbm86Cj4+Pj4+IE9uIDEwLzMwLzIwMTUgMDQ6NDMgQU0sIENhZXNh ciBXYW5nIHdyb3RlOgo+Pj4+Pj4gSGkgRGFuaWVsLAo+Pj4+Pj4KPj4+Pj4+IOWcqCAyMDE15bm0 MTDmnIgwMeaXpSAwMzoxNCwgSGVpa28gU3TDvGJuZXIg5YaZ6YGTOgo+Pj4+Pj4+IEhpIERhbmll bCwKPj4+Pj4+Pgo+Pj4+Pj4+IEFtIERpZW5zdGFnLCAyOS4gU2VwdGVtYmVyIDIwMTUsIDA2OjE4 OjAzIHNjaHJpZWIgRGFuaWVsIExlemNhbm86Cj4+Pj4+Pj4+IE9uIDA5LzI1LzIwMTUgMDQ6MTQg QU0sIENhZXNhciBXYW5nIHdyb3RlOgo+Pj4+Pj4+Pj4gQnVpbGQgdGhlIGFybTY0IFNvQ3MgKGUu Zy46IFJLMzM2OCkgb24gUm9ja2NoaXAgcGxhdGZvcm0sCj4+Pj4+Pj4+PiBUaGVyZSBhcmUgc29t ZSBmYWlsdXJlIHdpdGggYnVpbGQgdXAgb24gdGltZXIgZHJpdmVyIGZvciAKPj4+Pj4+Pj4+IHJv Y2tjaGlwLgo+Pj4+Pj4+Pj4KPj4+Pj4+Pj4+IFNheXM6Cj4+Pj4+Pj4+PiAvdG1wL2NjZEFuTnk1 LnM6NDc6IEVycm9yOiBtaXNzaW5nIGltbWVkaWF0ZSBleHByZXNzaW9uIGF0ICAKPj4+Pj4+Pj4+ IG9wZXJhbmQKPj4+Pj4+Pj4+IDEgLS0KPj4+Pj4+Pj4+IGBkc2JgCj4+Pj4+Pj4+PiAuLi4KPj4+ Pj4+Pj4+Cj4+Pj4+Pj4+PiBUaGUgcHJvYmxlbSB3YXMgZGlmZmVyZW50IHNlbWFudGljcyBvZiBk c2Igb24gYnR3IGFybTMyIGFuZCAKPj4+Pj4+Pj4+IGFybTY0LAo+Pj4+Pj4+Pj4gSGVyZSB3ZSBj YW4gY29udmVydCB0aGUgZHNiIHdpdGggaW5zdGVhZGluZyBvZiBkc2Ioc3kpLlRoZSAic3kiCj4+ Pj4+Pj4+PiBwYXJhbQo+Pj4+Pj4+Pj4gaXMgdGhlIGRlZmF1bHQgd2hpY2ggeW91IGFyZSBhbGxv dyB0byBvbWl0LCBzbyBvbiBhcm0zMiBkc2IoKWFuZAo+Pj4+Pj4+Pj4gZHNiKHN5KQo+Pj4+Pj4+ Pj4gYXJlIHRoZSBzYW1lLgo+Pj4+Pj4+Pj4KPj4+Pj4+Pj4+IFNpZ25lZC1vZmYtYnk6IENhZXNh ciBXYW5nIDx3eHRAcm9jay1jaGlwcy5jb20+Cj4+Pj4+Pj4+IEFja2VkLWJ5OiBEYW5pZWwgTGV6 Y2FubyA8ZGFuaWVsLmxlemNhbm9AbGluYXJvLm9yZz4KPj4+Pj4+PiBhcyB5b3UgaGF2ZSAianVz dCIgQWNrZWQgdGhlc2UgcGF0Y2hlcywgSSBndWVzcyB5b3UgYXJlIGV4cGVjdGluZwo+Pj4+Pj4+ IHRoZW0KPj4+Pj4+PiB0byBnbwo+Pj4+Pj4+IHRocm91Z2ggdGhlIHNhbWUgdHJlZSBhcyB0aGUg ZGV2aWNldHJlZSBjaGFuZ2VzLCByaWdodD8KPj4+Pj4+Cj4+Pj4+PiBJJ20gd29uZGVyIGlmIHNv bWVvbmUgd2lsbCBhcHBseSB0aGlzIHNlcmllcyBwYXRjaHMgYnV0IHRoZSB3YWl0LjotKQo+Pj4+ Pj4gSW4gZmFjdCwgSSdtIG5vIHN1cmUgdGhhdCB0aGUgQWNrZWQgaXMgcmVhbGx5IG1lYW5pbmcu Oi0KPj4+Pj4KPj4+Pj4gWWVzLCBieSBhY2tpbmcgdGhlIHBhdGNoIEkgc2F5IEkgYW0gb2sgd2l0 aCBpdCBhbmQgSSBhZ3JlZSBpdCBjYW4gZ28KPj4+Pj4gdGhyb3VnaCBhbm90aGVyIHRyZWUuCj4+ Pj4KPj4+PiBhbHRob3VnaCBJIGd1ZXNzIHRoZSB0d28gY2xvY2tzb3VyY2UgY2hhbmdlcyBjb3Vs ZCB2ZXJ5IHdlbGwganVzdCBnbwo+Pj4+IHRocm91Z2ggeW91ciB0cmVlLiBkc2IoKSAtPiBkc2Io c3kpIGlzIHN1cHBvc2VkIHRvIGJlIGVxdWFsIGFuZCB0aGUKPj4+PiBzZWNvbmQKPj4+PiBvbmUg aXMganVzdCBjb3NtZXRpY3MuICBUaGUgS2NvbmZpZyBhbmQgZHRzIGNoYW5nZXMgbmVlZCB0byB3 YWl0IGluCj4+Pj4gYW55IGNhc2UKPj4+PiBmb3IgNC41IC4uLiBidXQgSSBndWVzcyB0aGF0IG1h eSBiZSB0cnVlIGZvciB0aGUgY2xvY2tzb3VyY2UgY2hhbmdlcwo+Pj4+IGFzIHdlbGw/Cj4+Pgo+ Pj4gSGVpa28sIENhZXNhciwKPj4+Cj4+PiBJIGFtIHdvbmRlcmluZyBpZiB0aGUgZHNiKCkgaXMg cmVhbGx5IG5lY2Vzc2FyeS4gSXMgaXQgcG9zc2libGUgeW91Cj4+PiB0ZXN0IHRoZSB0aW1lciBi eSByZW1vdmluZyB0aGlzIGluc3RydWN0aW9uID8gT3RoZXJ3aXNlIEkgd2lsbCBoYXZlIHRvCj4+ PiBzZXR1cCBteSBib2FyZCBhZ2FpbiBhbmQgaXQgd2lsbCB0YWtlIGF3aGlsZS4KPj4+Cj4+Cj4+ IEFzIHRoZSBAQXJuZCBzdWdnZXN0aW9uLAo+Pgo+PiBUaGF0J3Mgc2VlbSBvayBmb3IgbWUuCj4+ IEFsdGhvdWdoIHRoZSB3cml0ZWxfcmVsYXhlZCgpIGFuZCB3cml0ZWwoKSBhIGJpdCBkaWZmZXJl bnQgIHdpdGggRFNCKCkKPj4gYW5kIEwyJ3Mgc3luYy4KPj4KPj4gRG8gSSBuZWVkIHNlbmQgdGhl IHBhdGNoIHYzPyAgSSB3aWxsIHRlc3QgdGhhdCBvbiBteSBib2FyZC4KPj4KPj4gSSdtIG5vIHN1 cmUgdGhhdCB3aHkgdGhlIGNsb2Nrc291cmNlIGRyaXZlciBkaWRuJ3QgdXNlIHRoZQo+PiB3cml0 ZWxfcmVsYXhlZCgpIHRvIHdvcmsuCj4+IE9rYXksIEkgdGhpbmsgd2Ugc2hvdWxkIGFjY29yZGlu ZyB0byB0aGUgc3VnZ2VzdGlvbiBvciByZXF1aXJlZC4KPgo+IEkgdGhpbmsgdGhlIHBhdGNoIGlz IHRyaXZpYWwgZW5vdWdoIEkgY2FuIGRvIHRoZSBjaGFuZ2UgbXlzZWxmIGlmIHlvdSAKPiB0ZXN0 IHRoZSBjaGFuZ2Ugb24geW91ciBzaWRlLiBCdXQgaXQgd291bGQgYmUgYSBnb29kIHByYWN0aWNl IHRvIHNlbmQgCj4gdGhlIHBhdGNoIHlvdSBoYXZlIHRlc3RlZC4gVXAgdG8geW91IDspCj4KCll1 cCwgdGhhdCdzIGFsc28gaGFwcHkgd29yay4KCkZlZWwgZnJlZSBhZGQgbXkgdGVzdCB0YWcgaWYg eW91IHJlbW92ZSB0aGUgZHNiKCkuClRlc3RlZC1ieTogQ2Flc2FyIFdhbmcgPHd4dEByb2NrLWNo aXBzLmNvbT4KClRoYW5rcyB5b3VyIHNlbmQhCgo+IFRoYW5rcyAhCj4KPiAgIC0tIERhbmllbAo+ Cj4KCgotLSAKVGhhbmtzLApDYWVzYXIKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2No aXBAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: caesar.upstream@gmail.com (Caesar Wang) Date: Tue, 3 Nov 2015 17:59:05 +0800 Subject: [PATCH v2 1/4] clocksource: rockchip: Make the driver more compatible In-Reply-To: <56387110.4060805@linaro.org> References: <1443147298-12603-1-git-send-email-wxt@rock-chips.com> <5632E765.4010207@gmail.com> <56334995.6090103@linaro.org> <21587719.mnFBFBzBeI@phil> <56379D46.1000402@linaro.org> <56381547.5070109@gmail.com> <56387110.4060805@linaro.org> Message-ID: <56388569.1070108@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org ? 2015?11?03? 16:32, Daniel Lezcano ??: > On 11/03/2015 03:00 AM, Caesar Wang wrote: >> Daniel, >> >> ? 2015?11?03? 01:28, Daniel Lezcano ??: >>> On 10/31/2015 12:47 AM, Heiko Stuebner wrote: >>>> Hi Daniel, >>>> >>>> Am Freitag, 30. Oktober 2015, 11:42:29 schrieb Daniel Lezcano: >>>>> On 10/30/2015 04:43 AM, Caesar Wang wrote: >>>>>> Hi Daniel, >>>>>> >>>>>> ? 2015?10?01? 03:14, Heiko St?bner ??: >>>>>>> Hi Daniel, >>>>>>> >>>>>>> Am Dienstag, 29. September 2015, 06:18:03 schrieb Daniel Lezcano: >>>>>>>> On 09/25/2015 04:14 AM, Caesar Wang wrote: >>>>>>>>> Build the arm64 SoCs (e.g.: RK3368) on Rockchip platform, >>>>>>>>> There are some failure with build up on timer driver for >>>>>>>>> rockchip. >>>>>>>>> >>>>>>>>> Says: >>>>>>>>> /tmp/ccdAnNy5.s:47: Error: missing immediate expression at >>>>>>>>> operand >>>>>>>>> 1 -- >>>>>>>>> `dsb` >>>>>>>>> ... >>>>>>>>> >>>>>>>>> The problem was different semantics of dsb on btw arm32 and >>>>>>>>> arm64, >>>>>>>>> Here we can convert the dsb with insteading of dsb(sy).The "sy" >>>>>>>>> param >>>>>>>>> is the default which you are allow to omit, so on arm32 dsb()and >>>>>>>>> dsb(sy) >>>>>>>>> are the same. >>>>>>>>> >>>>>>>>> Signed-off-by: Caesar Wang >>>>>>>> Acked-by: Daniel Lezcano >>>>>>> as you have "just" Acked these patches, I guess you are expecting >>>>>>> them >>>>>>> to go >>>>>>> through the same tree as the devicetree changes, right? >>>>>> >>>>>> I'm wonder if someone will apply this series patchs but the wait.:-) >>>>>> In fact, I'm no sure that the Acked is really meaning.:- >>>>> >>>>> Yes, by acking the patch I say I am ok with it and I agree it can go >>>>> through another tree. >>>> >>>> although I guess the two clocksource changes could very well just go >>>> through your tree. dsb() -> dsb(sy) is supposed to be equal and the >>>> second >>>> one is just cosmetics. The Kconfig and dts changes need to wait in >>>> any case >>>> for 4.5 ... but I guess that may be true for the clocksource changes >>>> as well? >>> >>> Heiko, Caesar, >>> >>> I am wondering if the dsb() is really necessary. Is it possible you >>> test the timer by removing this instruction ? Otherwise I will have to >>> setup my board again and it will take awhile. >>> >> >> As the @Arnd suggestion, >> >> That's seem ok for me. >> Although the writel_relaxed() and writel() a bit different with DSB() >> and L2's sync. >> >> Do I need send the patch v3? I will test that on my board. >> >> I'm no sure that why the clocksource driver didn't use the >> writel_relaxed() to work. >> Okay, I think we should according to the suggestion or required. > > I think the patch is trivial enough I can do the change myself if you > test the change on your side. But it would be a good practice to send > the patch you have tested. Up to you ;) > Yup, that's also happy work. Feel free add my test tag if you remove the dsb(). Tested-by: Caesar Wang Thanks your send! > Thanks ! > > -- Daniel > > -- Thanks, Caesar From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752673AbbKCJ7Y (ORCPT ); Tue, 3 Nov 2015 04:59:24 -0500 Received: from mail-pa0-f66.google.com ([209.85.220.66]:32945 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750788AbbKCJ7U (ORCPT ); Tue, 3 Nov 2015 04:59:20 -0500 Subject: Re: [PATCH v2 1/4] clocksource: rockchip: Make the driver more compatible To: Daniel Lezcano References: <1443147298-12603-1-git-send-email-wxt@rock-chips.com> <5632E765.4010207@gmail.com> <56334995.6090103@linaro.org> <21587719.mnFBFBzBeI@phil> <56379D46.1000402@linaro.org> <56381547.5070109@gmail.com> <56387110.4060805@linaro.org> Cc: Caesar Wang , devicetree@vger.kernel.org, Heiko Stuebner , Arnd Bergmann , catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Caesar Wang From: Caesar Wang Message-ID: <56388569.1070108@gmail.com> Date: Tue, 3 Nov 2015 17:59:05 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <56387110.4060805@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2015年11月03日 16:32, Daniel Lezcano 写道: > On 11/03/2015 03:00 AM, Caesar Wang wrote: >> Daniel, >> >> 在 2015年11月03日 01:28, Daniel Lezcano 写道: >>> On 10/31/2015 12:47 AM, Heiko Stuebner wrote: >>>> Hi Daniel, >>>> >>>> Am Freitag, 30. Oktober 2015, 11:42:29 schrieb Daniel Lezcano: >>>>> On 10/30/2015 04:43 AM, Caesar Wang wrote: >>>>>> Hi Daniel, >>>>>> >>>>>> 在 2015年10月01日 03:14, Heiko Stübner 写道: >>>>>>> Hi Daniel, >>>>>>> >>>>>>> Am Dienstag, 29. September 2015, 06:18:03 schrieb Daniel Lezcano: >>>>>>>> On 09/25/2015 04:14 AM, Caesar Wang wrote: >>>>>>>>> Build the arm64 SoCs (e.g.: RK3368) on Rockchip platform, >>>>>>>>> There are some failure with build up on timer driver for >>>>>>>>> rockchip. >>>>>>>>> >>>>>>>>> Says: >>>>>>>>> /tmp/ccdAnNy5.s:47: Error: missing immediate expression at >>>>>>>>> operand >>>>>>>>> 1 -- >>>>>>>>> `dsb` >>>>>>>>> ... >>>>>>>>> >>>>>>>>> The problem was different semantics of dsb on btw arm32 and >>>>>>>>> arm64, >>>>>>>>> Here we can convert the dsb with insteading of dsb(sy).The "sy" >>>>>>>>> param >>>>>>>>> is the default which you are allow to omit, so on arm32 dsb()and >>>>>>>>> dsb(sy) >>>>>>>>> are the same. >>>>>>>>> >>>>>>>>> Signed-off-by: Caesar Wang >>>>>>>> Acked-by: Daniel Lezcano >>>>>>> as you have "just" Acked these patches, I guess you are expecting >>>>>>> them >>>>>>> to go >>>>>>> through the same tree as the devicetree changes, right? >>>>>> >>>>>> I'm wonder if someone will apply this series patchs but the wait.:-) >>>>>> In fact, I'm no sure that the Acked is really meaning.:- >>>>> >>>>> Yes, by acking the patch I say I am ok with it and I agree it can go >>>>> through another tree. >>>> >>>> although I guess the two clocksource changes could very well just go >>>> through your tree. dsb() -> dsb(sy) is supposed to be equal and the >>>> second >>>> one is just cosmetics. The Kconfig and dts changes need to wait in >>>> any case >>>> for 4.5 ... but I guess that may be true for the clocksource changes >>>> as well? >>> >>> Heiko, Caesar, >>> >>> I am wondering if the dsb() is really necessary. Is it possible you >>> test the timer by removing this instruction ? Otherwise I will have to >>> setup my board again and it will take awhile. >>> >> >> As the @Arnd suggestion, >> >> That's seem ok for me. >> Although the writel_relaxed() and writel() a bit different with DSB() >> and L2's sync. >> >> Do I need send the patch v3? I will test that on my board. >> >> I'm no sure that why the clocksource driver didn't use the >> writel_relaxed() to work. >> Okay, I think we should according to the suggestion or required. > > I think the patch is trivial enough I can do the change myself if you > test the change on your side. But it would be a good practice to send > the patch you have tested. Up to you ;) > Yup, that's also happy work. Feel free add my test tag if you remove the dsb(). Tested-by: Caesar Wang Thanks your send! > Thanks ! > > -- Daniel > > -- Thanks, Caesar