From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Cong Wang <cwang@twopensource.com>, Sasha Levin <sasha.levin@oracle.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
LKML <linux-kernel@vger.kernel.org>,
syzkaller@googlegroups.com, Dmitry Vyukov <dvyukov@google.com>
Subject: Re: net: lockdep warning in ip_mc_msfget (net/ipv4/igmp.c:2400)
Date: Tue, 3 Nov 2015 09:21:09 -0200 [thread overview]
Message-ID: <563898A5.9050200@gmail.com> (raw)
In-Reply-To: <CAHA+R7OsGmYPWtHFK8QmuzaZW9WBfVCVviReEopTRF_zjxzKKA@mail.gmail.com>
Em 02-11-2015 22:38, Cong Wang escreveu:
> On Mon, Nov 2, 2015 at 1:31 PM, Cong Wang <cwang@twopensource.com> wrote:
>>
>> Good catch!
>>
>> This is probably introduced by:
>>
>> commit baf606d9c9b12517e47e0d1370e8aa9f7323f210
>> Author: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
>> Date: Wed Mar 18 14:50:42 2015 -0300
>>
>> ipv4,ipv6: grab rtnl before locking the socket
Yes, that commit introduced this inverse order situation by not fixing
the get path of it.
>> I am thinking what is the right way to fix it...
>
> Please try the attached patch.
>
> Thanks!
Patch LGTM, same design and covered all rtnl_lock()s I could find on get
path now. Thanks!
Marcelo
prev parent reply other threads:[~2015-11-03 11:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 15:22 net: lockdep warning in ip_mc_msfget (net/ipv4/igmp.c:2400) Sasha Levin
2015-11-02 21:31 ` Cong Wang
2015-11-03 0:38 ` Cong Wang
2015-11-03 11:21 ` Marcelo Ricardo Leitner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563898A5.9050200@gmail.com \
--to=marcelo.leitner@gmail.com \
--cc=cwang@twopensource.com \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sasha.levin@oracle.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.