From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Davidlohr Bueso <dave@stgolabs.net>, George Spelvin <linux@horizon.com>
Cc: tglx@linutronix.de, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, manfred@colorfullife.com,
peterz@infradead.org
Subject: Re: [PATCH] ipc/msg: Implement lockless pipelined wakeups
Date: Tue, 3 Nov 2015 15:15:28 +0100 [thread overview]
Message-ID: <5638C180.6050901@linutronix.de> (raw)
In-Reply-To: <20151031190633.GA1707@linux-uzut.site>
On 10/31/2015 08:06 PM, Davidlohr Bueso wrote:
> On Sat, 31 Oct 2015, Bueso wrote:
>
>> Yes, and this confirms that we still rely on the implicit barrier
>> from the cmpxchg as tglx mentioned. As such, we also need to keep
>> the pairing when reading 'r_msg' in do_msgrcv(), instead of dropping
>> the comments.
>
> Hmm having r_msg as volatile seems even less needed now, we should
> drop it. I imagine it was there initially for the busy-wait on the variable
> becoming non-nil, but we had cpu_relax _anyway_, so ...
Didn't noticed that. So that volatile part and the casts are gone, too.
Sebastian
next prev parent reply other threads:[~2015-11-03 14:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 11:26 [PATCH] ipc/msg: Implement lockless pipelined wakeups Sebastian Andrzej Siewior
2015-10-30 22:30 ` George Spelvin
2015-11-03 14:01 ` Sebastian Andrzej Siewior
2015-10-31 10:31 ` Thomas Gleixner
2015-10-31 13:02 ` George Spelvin
2015-10-31 15:17 ` Thomas Gleixner
2015-10-31 18:54 ` Davidlohr Bueso
2015-10-31 19:06 ` Davidlohr Bueso
2015-11-03 14:15 ` Sebastian Andrzej Siewior [this message]
2015-11-03 14:11 ` Sebastian Andrzej Siewior
2015-11-01 4:32 ` Manfred Spraul
2015-11-03 14:51 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5638C180.6050901@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@horizon.com \
--cc=manfred@colorfullife.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.