From: Jens Axboe <axboe@kernel.dk>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Ming Lei <ming.lei@canonical.com>,
Jason Luo <zhangqing.luo@oracle.com>,
linux-kernel@vger.kernel.org
Subject: Re: [patch, v3] blk-mq: avoid excessive boot delays with large lun counts
Date: Tue, 3 Nov 2015 08:46:04 -0700 [thread overview]
Message-ID: <5638D6BC.4050607@kernel.dk> (raw)
In-Reply-To: <x4937wn3xd5.fsf@segfault.boston.devel.redhat.com>
On 11/03/2015 08:40 AM, Jeff Moyer wrote:
> Hi,
>
> Zhangqing Luo reported long boot times on a system with thousands of
> LUNs when scsi-mq was enabled. He narrowed the problem down to
> blk_mq_add_queue_tag_set, where every queue is frozen in order to set
> the BLK_MQ_F_TAG_SHARED flag. Each added device will freeze all queues
> added before it in sequence, which involves waiting for an RCU grace
> period for each one. We don't need to do this. After the second queue
> is added, only new queues need to be initialized with the shared tag.
> We can do that by percolating the flag up to the blk_mq_tag_set, and
> updating the newly added queue's hctxs if the flag is set.
>
> This problem was introduced by commit 0d2602ca30e41 (blk-mq: improve
> support for shared tags maps).
Applied, thanks Jeff and Ming.
--
Jens Axboe
prev parent reply other threads:[~2015-11-03 15:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 15:40 [patch, v3] blk-mq: avoid excessive boot delays with large lun counts Jeff Moyer
2015-11-03 15:46 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5638D6BC.4050607@kernel.dk \
--to=axboe@kernel.dk \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=zhangqing.luo@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.