From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45504) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtfRW-0003ka-9e for qemu-devel@nongnu.org; Tue, 03 Nov 2015 12:32:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtfRR-0000Ja-Q2 for qemu-devel@nongnu.org; Tue, 03 Nov 2015 12:32:22 -0500 References: <1445644612-12702-1-git-send-email-jsnow@redhat.com> <1445644612-12702-4-git-send-email-jsnow@redhat.com> <20151103163341.GB15533@localhost.localdomain> From: John Snow Message-ID: <5638EF9D.1080509@redhat.com> Date: Tue, 3 Nov 2015 12:32:13 -0500 MIME-Version: 1.0 In-Reply-To: <20151103163341.GB15533@localhost.localdomain> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v10 03/14] block: rename BlkTransactionState and BdrvActionOps List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: vsementsov@virtuozzo.com, famz@redhat.com, qemu-block@nongnu.org, armbru@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On 11/03/2015 11:33 AM, Jeff Cody wrote: > On Fri, Oct 23, 2015 at 07:56:41PM -0400, John Snow wrote: >> These structures are misnomers, somewhat. >> >> (1) BlockTransactionState is not state for a transaction, >> but is rather state for a single transaction action. >> Rename it "BlkActionState" to be more accurate. >> >> (2) The BdrvActionOps describes operations for the BlkActionState, >> above. This name might imply a 'BdrvAction' or a 'BdrvActionState', >> which there isn't. >> Rename this to 'BlkActionOps' to match 'BlkActionState'. >> >> Lastly, update the surrounding in-line documentation and comments >> to reflect the current nature of how Transactions operate. >> >> This patch changes only comments and names, and should not affect >> behavior in any way. >> >> Signed-off-by: John Snow >> Reviewed-by: Max Reitz >> Reviewed-by: Stefan Hajnoczi >> Signed-off-by: Stefan Hajnoczi >> Reviewed-by: Fam Zheng >> Signed-off-by: Fam Zheng >> --- >> blockdev.c | 116 ++++++++++++++++++++++++++++++++++--------------------------- >> 1 file changed, 65 insertions(+), 51 deletions(-) >> > > just a heads up - this patch fails to apply on qemu master, so a > rebase is probably in order (this series is based on qemu master, > right?) > Yes, but is a week old. I'll rebase and re-upload to github. V11 will follow. > (I'll review from your github branch for now) > Grazie. --js