All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew <nitr0@seti.kr.ua>
To: Netdev <netdev@vger.kernel.org>
Subject: Re: HTB, HFSC, PIE, FIFO stuck on 2.4Gbit on default values
Date: Tue, 3 Nov 2015 23:04:08 +0200	[thread overview]
Message-ID: <56392148.4090309@seti.kr.ua> (raw)
In-Reply-To: <1446580156.23275.74.camel@edumazet-glaptop2.roam.corp.google.com>

Hi.

This is common trouble due to hierarchical shapers realization (global 
tree lock on packet dequeuing - so when one CPU looks for parent class 
where tokens can be borrowed, other CPUs are waiting). It's mentioned 
even in academic publications :) You can read about it here: 
http://www.ijcset.com/docs/IJCSET13-04-04-113.pdf

I think that simple lock removing will greatly improve performance; and 
race conditions on packets dequeuing shouldn't hurt anything except 
shaping accuracy. Another solutions looks more complex.

03.11.2015 21:49, Eric Dumazet пишет:
> On Tue, 2015-11-03 at 21:17 +0200, Denys Fedoryshchenko wrote:
>>   GSO/TSO on the output and watch performance coming back.
>>
>> It is not, since i have more than 120 servers installed over country
>> (most of them handle small traffic), in forwarding mode, first thing i
>> am doing on forwarding setup - disabling gro/gso/tso. It is helped also
>> many ISP on their forum where i visit often, first thing in
>> troubleshooting unreliable network traffic forwarding - disabling
>> offloading.
>> Because problem starts from incorrect shaping, and ends in some cases
>> with network drivers spitting watchdog errors. Sometimes even shaper not
>> necessary, just plain forwarding with offload enabled can cause issues,
>> but it might be bug in networking drivers.
>> Should i try to reproduce and report? Sure if anybody can look into this
>> issue.
>
> Well, I am telling you.
>
> Say no to people advising to turn off GRO/TSO.
>
> If you were the guy adviding others to do so, it is time to see the
> light.
>
> Lets fix the bugs if any, instead of spreading disinformation.
>
> I am so tired of telling these very simple facts guys.
>
> If you prefer, continue to work on linux-2.0 but don't ask help on
> netdev.
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-11-03 21:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03 17:33 HTB, HFSC, PIE, FIFO stuck on 2.4Gbit on default values Denys Fedoryshchenko
2015-11-03 19:11 ` Eric Dumazet
2015-11-03 19:17   ` Denys Fedoryshchenko
2015-11-03 19:49     ` Eric Dumazet
2015-11-03 20:01       ` David Miller
2015-11-03 20:24       ` Denys Fedoryshchenko
2015-11-03 21:23         ` Eric Dumazet
2015-11-04  4:12           ` Denys Fedoryshchenko
2015-11-04  4:28             ` Eric Dumazet
2015-11-04  4:49               ` Denys Fedoryshchenko
2015-11-04  5:02                 ` Eric Dumazet
2015-11-03 21:04       ` Andrew [this message]
2015-11-03 22:02         ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56392148.4090309@seti.kr.ua \
    --to=nitr0@seti.kr.ua \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.