From: Mark Hatle <mark.hatle@windriver.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] binutils: Fix XLP / Octeon 3 instruction clash
Date: Tue, 3 Nov 2015 18:35:49 -0600 [thread overview]
Message-ID: <563952E5.6060603@windriver.com> (raw)
In-Reply-To: <CAMKF1soDd-GpSYetT-mv-PeXiwS3iwtA8=MyD8ntutiD+f84ow@mail.gmail.com>
On 11/3/15 5:28 PM, Khem Raj wrote:
> On Tue, Nov 3, 2015 at 2:21 PM, Mark Hatle <mark.hatle@windriver.com> wrote:
>> Use the value 0x00000080 for INSN_XLP, as the value 0x00000040 has already
>> been assigned to INSN_OCTEON3 by the binutils project.
>>
>> Without this change, invalid instructions can be generated for both INSN_XLP
>> and INSN_OCTEON3.
>>
>
> this is ok. is octeon3 sent upstream yet ?
AFAIK, the octeon3 stuff is in the binutils master.
--Mark
>> Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
>> ---
>> .../binutils/binutils/0012-Add-XLP-instructions-support.patch | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-devtools/binutils/binutils/0012-Add-XLP-instructions-support.patch b/meta/recipes-devtools/binutils/binutils/0012-Add-XLP-instructions-support.patch
>> index c56ff91..ecc37cc 100644
>> --- a/meta/recipes-devtools/binutils/binutils/0012-Add-XLP-instructions-support.patch
>> +++ b/meta/recipes-devtools/binutils/binutils/0012-Add-XLP-instructions-support.patch
>> @@ -31,6 +31,12 @@ Netlogic. Also, update vendor name to NLM wherever applicable.
>> Upstream-Status: Pending
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> +
>> +Use 0x00000080 for INSN_XLP, the value 0x00000040 has already been assigned
>> +to INSN_OCTEON3
>> +
>> +Signed-off-by: Baoshan Pang <baoshan.pang@windriver.com>
>> +Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
>> ---
>> bfd/aoutx.h | 1 +
>> bfd/archures.c | 1 +
>> @@ -251,7 +257,7 @@ index ef26167..ef53ec6 100644
>> +/* Netlogic Xlr instruction */
>> +#define INSN_XLR 0x00000020
>> +/* Netlogic XlP instruction */
>> -+#define INSN_XLP 0x00000040
>> ++#define INSN_XLP 0x00000080
>>
>> /* DSP ASE */
>> #define ASE_DSP 0x00000001
>> --
>> 1.9.3
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
prev parent reply other threads:[~2015-11-04 0:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 22:21 [PATCH] [jethro/master] Fix mips XLP and Octeon3 assembly Mark Hatle
2015-11-03 22:21 ` [PATCH] binutils: Fix XLP / Octeon 3 instruction clash Mark Hatle
2015-11-03 23:28 ` Khem Raj
2015-11-04 0:35 ` Mark Hatle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563952E5.6060603@windriver.com \
--to=mark.hatle@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.