From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Liang, Cunming" <cunming.liang@intel.com>
Subject: Re: [PATCH v2 01/11] eal/linux: vfio map misc intr to
 vector zero
Date: Wed, 4 Nov 2015 09:17:28 +0800
Message-ID: <56395CA8.7090500@intel.com>
References: <1443072831-19065-1-git-send-email-cunming.liang@intel.com>
 <1446182873-28814-1-git-send-email-cunming.liang@intel.com>
 <1446182873-28814-2-git-send-email-cunming.liang@intel.com>
 <CALwxeUsOwbbUwcpp+rY4PUW-DvT1pwvGDGxOKU7RS_ynqMb02g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: David Marchand <david.marchand@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 2FC528E94
 for <dev@dpdk.org>; Wed,  4 Nov 2015 02:18:33 +0100 (CET)
In-Reply-To: <CALwxeUsOwbbUwcpp+rY4PUW-DvT1pwvGDGxOKU7RS_ynqMb02g@mail.gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi David,

On 11/2/2015 11:53 PM, David Marchand wrote:
> Hello,
>
> On Fri, Oct 30, 2015 at 6:27 AM, Cunming Liang <cunming.liang@intel.com>
> wrote:
> [snip]
>
>> diff --git a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h
>> b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h
>> index 45071b7..b8fd318 100644
>> --- a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h
>> +++ b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h
>> @@ -77,6 +77,9 @@ struct rte_epoll_event {
>>          struct rte_epoll_data epdata;
>>   };
>>
>> +#define MISC_VEC_ID                (0)
>>
> "misc" is not really descriptive ...
>
>
>> +#define RX_VEC_START               (MISC_VEC_ID + 1)
>> +
>>
> Please, prefix these macros properly.
> Else, when looking at the driver code, this kind of macros seems to be
> local to the driver.
>
>
That makes sense, will fix it in v3. Thanks. /Steve