Re: [PATCH v2 07/11] ixgbevf: cleanup unnecessary interrupt handler

["Liang, Cunming" <cunming.liang@intel.com>]

Hi David,

On 11/3/2015 12:06 AM, David Marchand wrote:
> On Fri, Oct 30, 2015 at 6:27 AM, Cunming Liang <cunming.liang@intel.com>
> wrote:
>
>> As ixgbe vf doesn't support lsc, the patch removes those unused code.
>> In addition, it does some tiny cleanup.
>>
> Please, can you describe this tiny cleanup ?
> Did it trigger some bug ?
It causes confusing to enable/allocate efd with a zero number of vector.
But this piece of code shall be merged in a different patch. Thanks.
>> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
>> b/drivers/net/ixgbe/ixgbe_ethdev.c
>> index 366923f..794171c 100644
>> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
>> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
>> [snip]
>> @@ -3492,11 +3442,11 @@ ixgbevf_dev_start(struct rte_eth_dev *dev)
>>          ixgbevf_dev_rxtx_start(dev);
>>
>>          /* check and configure queue intr-vector mapping */
>> -       if (dev->data->dev_conf.intr_conf.rxq != 0)
>> +       if (dev->data->dev_conf.intr_conf.rxq != 0) {
>>                  intr_vector = dev->data->nb_rx_queues;
>> -
>> -       if (rte_intr_efd_enable(intr_handle, intr_vector))
>> -               return -1;
>> +               if (rte_intr_efd_enable(intr_handle, intr_vector))
>> +                       return -1;
>> +       }
>>
>>
>