From: Jason Wang <jasowang@redhat.com>
To: P J P <ppandit@redhat.com>, qemu-devel@nongnu.org
Cc: max <luodalongde@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] eepro100: prevent an infinite loop over same command block
Date: Wed, 4 Nov 2015 11:31:41 +0800 [thread overview]
Message-ID: <56397C1D.6070304@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1511040013320.25860@wniryva>
On 11/04/2015 02:49 AM, P J P wrote:
> +-- On Tue, 20 Oct 2015, Jason Wang wrote --+
> | Can this survive if we had a chain like?
> | A->B->A
>
> No, current patch wouldn't cope with it. Though I wonder if such a loop is
> possible?
Just wondering.
Tx.link is unit32_t, but any chance s->cu_base + s->cu_offset can result
a integer overflow?
>
> | If not, looks like we need to limit the maximum number of commands in a
> | chain? (e.g 256)
>
> Okay, I'll update the patch.
>
> @max, @Qinghao: did you have chance to test the current patch? (just checking)
>
>
> Thank you.
> --
> - P J P
> 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
>
next prev parent reply other threads:[~2015-11-04 3:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 11:12 [Qemu-devel] [PATCH] eepro100: prevent an infinite loop over same command block P J P
2015-10-16 12:41 ` Paolo Bonzini
2015-10-16 17:19 ` P J P
2015-10-16 21:37 ` Stefan Weil
2015-10-17 11:25 ` P J P
2015-10-17 11:35 ` Peter Maydell
2015-10-20 3:04 ` Jason Wang
2015-10-20 3:10 ` max
2015-10-20 3:02 ` Jason Wang
2015-11-03 18:49 ` P J P
2015-11-04 3:31 ` Jason Wang [this message]
2015-11-20 2:43 ` Qinghao Tang
2015-11-20 6:10 ` P J P
2015-11-20 6:29 ` Qinghao Tang
2015-11-20 7:23 ` P J P
2015-11-20 7:47 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56397C1D.6070304@redhat.com \
--to=jasowang@redhat.com \
--cc=luodalongde@gmail.com \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.