From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Hartkopp Subject: Re: can-isotp-modules Date: Wed, 04 Nov 2015 11:06:17 +0100 Message-ID: <5639D899.1090305@hartkopp.net> References: <44220b4fed9da26bb9ba1b9c2ec885c4@pjnk.de> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.163]:57491 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932531AbbKDKIB (ORCPT ); Wed, 4 Nov 2015 05:08:01 -0500 In-Reply-To: <44220b4fed9da26bb9ba1b9c2ec885c4@pjnk.de> Sender: linux-can-owner@vger.kernel.org List-ID: To: Oliver Pajonk , Michael Luxen Cc: linux-can@vger.kernel.org, linux-can-owner@vger.kernel.org Hi all, Oliver is right! :-) Instead of 1. git clone https://github.com/hartkopp/can-isotp-modules/ 2. cd can-isotp-modules 3. make just do 1. git clone https://github.com/hartkopp/can-isotp-modules/ 2. cd can-isotp-modules/net/can 3. ./make_isotp.sh which should create a can-isotp.ko module there. When the PF_CAN infrastructure is loaded (modprobe can) an insmod ./can-isotp.ko should make it. Currently MAX_MSG_LENGTH is set to 8200 to be able to play with the new jumbo PDU length in ISO 15765-2:2015. For previous ISO versions MAX_MSG_LENGTH was set to 4095. N.B. take care for the isotp can-utils buffer length too when using jumbo PDU length there. Regards, Oliver On 04.11.2015 07:59, Oliver Pajonk wrote: > > Hi Michael, > > I was struggeling to compile ISO-TP as well (on my Raspi), but then I found > this script (it was mentioned in some other mailing list post): > > https://github.com/hartkopp/can-isotp-modules/blob/master/net/can/make_isotp.sh > > That worked just fine. Maybe it helps? > > Best regards, > Oliver > > On 2015-11-03 23:29, Michael Luxen wrote: >> Hello Oliver, >> >> today I've tried to install can-isotp-modules on my BeagleBone Black by >> >> 1. git clone https://github.com/hartkopp/can-isotp-modules/ >> 2. cd can-isotp-modules >> 3. make >> >> The make process on my Debian Jessie 8.2 (uname -r: 4.1.6-ti-r16) >> powered BBB ends up with: >> >> root@beaglebone:~/can-isotp-modules# make >> make -C /lib/modules/4.1.6-ti-r16/build M=/root/can-isotp-modules >> modules TOPDIR=/root/can-isotp-modules >> make[1]: Entering directory '/usr/src/linux-headers-4.1.6-ti-r16' >> CC [M] /root/can-isotp-modules/drivers/net/can/vcan.o >> In file included from include/linux/module.h:17:0, >> from /root/can-isotp-modules/drivers/net/can/vcan.c:44: >> /root/can-isotp-modules/drivers/net/can/vcan.c: In function '__check_echo': >> include/linux/moduleparam.h:377:61: warning: return from incompatible >> pointer type >> static inline type __always_unused *__check_##name(void) { return(p); } >> ^ >> include/linux/moduleparam.h:428:35: note: in expansion of macro '__param_check' >> #define param_check_bool(name, p) __param_check(name, p, bool) >> ^ >> include/linux/moduleparam.h:145:2: note: in expansion of macro >> 'param_check_bool' >> param_check_##type(name, &(value)); \ >> ^ >> include/linux/moduleparam.h:125:2: note: in expansion of macro >> 'module_param_named' >> module_param_named(name, name, type, perm) >> ^ >> /root/can-isotp-modules/drivers/net/can/vcan.c:91:1: note: in >> expansion of macro 'module_param' >> module_param(echo, bool, S_IRUGO); >> ^ >> CC [M] /root/can-isotp-modules/drivers/net/can/slcan.o >> /root/can-isotp-modules/drivers/net/can/slcan.c:46:24: fatal error: >> asm/system.h: No such file or directory >> #include >> ^ >> compilation terminated. >> scripts/Makefile.build:264: recipe for target >> '/root/can-isotp-modules/drivers/net/can/slcan.o' failed >> make[3]: *** [/root/can-isotp-modules/drivers/net/can/slcan.o] Error 1 >> scripts/Makefile.build:403: recipe for target >> '/root/can-isotp-modules/drivers/net/can' failed >> make[2]: *** [/root/can-isotp-modules/drivers/net/can] Error 2 >> Makefile:1384: recipe for target '_module_/root/can-isotp-modules' failed >> make[1]: *** [_module_/root/can-isotp-modules] Error 2 >> make[1]: Leaving directory '/usr/src/linux-headers-4.1.6-ti-r16' >> Makefile:42: recipe for target 'modules' failed >> make: *** [modules] Error 2 >> >> >> Any idea/hint how to fix this issue? >> >> Regards >> Michael >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-can" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-can" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html