All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	qemu-devel@nongnu.org,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/3] target-i386: Don't trigger CPUID warnings by default in KVM mode (in most hosts)
Date: Wed, 4 Nov 2015 11:50:25 +0100	[thread overview]
Message-ID: <5639E2F1.6090204@redhat.com> (raw)
In-Reply-To: <20151103225443.GF4180@thinpad.lan.raisama.net>



On 03/11/2015 23:54, Eduardo Habkost wrote:
> Probably, yes. libvirt even has these commented out in their cpu_map.xml:
> 
>     <model name='qemu64'>
>       <model name='kvm64'/>
>       <!-- These are supported only by TCG.  KVM supports them only if the
>            host does.  So we leave them out:
> 
>            <feature name='popcnt'/>
>            <feature name='lahf_lm'/>
>            <feature name='sse4a'/>
>            <feature name='abm'/>
>       -->
>       <feature name='svm'/>
>     </model>
> 
> (libvirt must stop making assumptions about the CPU model feature sets so
> all <feature> elements in cpu_map.xml should go away. But at least the
> current cpu_map.xml is a good reference to what it expects today.)

FWIW, lahf_lm is present on virtually all 64-bit machines and is rare
enough that KVM could just emulate it, so we shouldn't remove it.  But
removing popcnt is a good suggestion to take from libvirt.  It can be
done on top of this series.  We should get all of this into the first
-rc, anyway.

Paolo

      reply	other threads:[~2015-11-04 10:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03 19:58 [Qemu-devel] [PATCH v2 0/3] target-i386: Don't trigger CPUID warnings by default in KVM mode (in most hosts) Eduardo Habkost
2015-11-03 19:58 ` [Qemu-devel] [PATCH v2 1/3] target-i386: Set "check=off" by default on pc-*-2.4 and older Eduardo Habkost
2015-11-03 19:58 ` [Qemu-devel] [PATCH v2 2/3] target-i386: Remove SSE4a from qemu64 CPU model Eduardo Habkost
2015-11-03 19:58 ` [Qemu-devel] [PATCH v2 3/3] target-i386: Remove ABM " Eduardo Habkost
2015-11-03 20:22 ` [Qemu-devel] [PATCH v2 0/3] target-i386: Don't trigger CPUID warnings by default in KVM mode (in most hosts) Paolo Bonzini
2015-11-03 22:54   ` Eduardo Habkost
2015-11-04 10:50     ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5639E2F1.6090204@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.