From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1ZtwD5-0002GS-On
	for mharc-grub-devel@gnu.org; Wed, 04 Nov 2015 06:26:35 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33615)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arvidjaar@gmail.com>) id 1ZtwD1-0002Eq-UO
	for grub-devel@gnu.org; Wed, 04 Nov 2015 06:26:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arvidjaar@gmail.com>) id 1ZtwCy-0003gb-KU
	for grub-devel@gnu.org; Wed, 04 Nov 2015 06:26:31 -0500
Received: from mail-lf0-x22a.google.com ([2a00:1450:4010:c07::22a]:35347)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arvidjaar@gmail.com>) id 1ZtwCy-0003gX-Cj
	for grub-devel@gnu.org; Wed, 04 Nov 2015 06:26:28 -0500
Received: by lfbn126 with SMTP id n126so37684275lfb.2
	for <grub-devel@gnu.org>; Wed, 04 Nov 2015 03:26:27 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=subject:to:references:from:message-id:date:user-agent:mime-version
	:in-reply-to:content-type:content-transfer-encoding;
	bh=LO8orIYg++Qv8vLI1pjhmV7QOay2IC4K/2MXNXQsB2k=;
	b=qsRDLuums6nCf95eqetp+A8Fthuo8OsLAYxkkFPYDoCOuOCLB4R/CEhuCXLtvKoxwA
	oeg5UJQJZfrXJ0HWQE8FlUGOZRfrdjzs20Tbi+aD7QE/reWu7F6x7f12TzRZKnTpt1A7
	1tWyB41XhVPCvDq8HSbNU7VZZ/U4l6B/8+p1VXqo3EnsWmfU/WHuQ9O/PQguCrCNOXOQ
	2hCIlrElPj6GxCqfIG2o81DyBbJ5iBSoy2T6pPatOKc2kpg+22DClsRHjfSgrHwIEEJJ
	+aj6NBRuvgrNipkD+QMGN6XjXu4G+oMXRp1lbj381d4nwZnBVK3t3vydJYa+k0MLOT+o
	9ERA==
X-Received: by 10.25.90.74 with SMTP id o71mr39852lfb.120.1446636387629;
	Wed, 04 Nov 2015 03:26:27 -0800 (PST)
Received: from [192.168.1.41] (ppp91-76-25-247.pppoe.mtu-net.ru.
	[91.76.25.247])
	by smtp.gmail.com with ESMTPSA id k1sm134055lbc.28.2015.11.04.03.26.26
	for <grub-devel@gnu.org>
	(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
	Wed, 04 Nov 2015 03:26:26 -0800 (PST)
Subject: Re: modules size in mkimage
To: grub-devel@gnu.org
References: <56346783.20504@gmail.com>
	<CAEaD8JOhE+zs4sgmfGnVxC3DBG5GmxW2mCn5C2=Wg+NFxtc+yQ@mail.gmail.com>
From: Andrei Borzenkov <arvidjaar@gmail.com>
Message-ID: <5639EB62.9050703@gmail.com>
Date: Wed, 4 Nov 2015 14:26:26 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
	Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <CAEaD8JOhE+zs4sgmfGnVxC3DBG5GmxW2mCn5C2=Wg+NFxtc+yQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address
	(bad octet value).
X-Received-From: 2a00:1450:4010:c07::22a
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: The development of GNU GRUB <grub-devel@gnu.org>
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Nov 2015 11:26:32 -0000

04.11.2015 14:21, Vladimir 'phcoder' Serbinenko пишет:
> Le 31 oct. 2015 8:02 AM, "Andrei Borzenkov" <arvidjaar@gmail.com> a écrit :
>>
>> mkimage sets module size to aligned value; later it is used to actually
> process it which /may/ lead to inconsistency (as any comparison is against
> stored aligned size, not actual module size).
>>
> Which inconsistency do you have in mind?

   if (size < e->e_shoff + e->e_shentsize * e->e_shnum)
     {
       grub_error (GRUB_ERR_BAD_OS, "ELF sections outside core");