AW: can-isotp-modules

AW: can-isotp-modules

[Michael Luxen]

Hello Oliver & Oliver,

thanks for the hint.
The can-isotp-module is created now.

@Oliver H.:
One proposal from myside, can you please add a can-isotp-module installation process (like it is below) on the GITHUB webside.
It would be easier for some people (like me) to get the source code running without asking. :-)

Thanks & Regards
Michael

-----Ursprüngliche Nachricht-----
Von:	Oliver Hartkopp <socketcan@hartkopp.net>
Gesendet:	Mi 04.11.2015 11:11
Betreff:	Re: can-isotp-modules
An:	Oliver Pajonk <oliver@pjnk.de>; Michael Luxen <mluxen@gmx.net>; 
CC:	linux-can@vger.kernel.org; linux-can-owner@vger.kernel.org; 
> Hi all,
> 
> Oliver is right! :-)
> 
> Instead of
> 
> 1. git clone https://github.com/hartkopp/can-isotp-modules/
> 2. cd can-isotp-modules
> 3. make
> 
> just do
> 
> 1. git clone https://github.com/hartkopp/can-isotp-modules/
> 2. cd can-isotp-modules/net/can
> 3. ./make_isotp.sh
> 
> which should create a can-isotp.ko module there.
> 
> When the PF_CAN infrastructure is loaded (modprobe can) an
> 
> 	insmod ./can-isotp.ko
> 
> should make it.
> 
> Currently MAX_MSG_LENGTH is set to 8200 to be able to play with the new jumbo 
> PDU length in ISO 15765-2:2015. For previous ISO versions MAX_MSG_LENGTH was 
> set to 4095. N.B. take care for the isotp can-utils buffer length too when 
> using jumbo PDU length there.
> 
> Regards,
> Oliver
> 
> On 04.11.2015 07:59, Oliver Pajonk wrote:
> >
> > Hi Michael,
> >
> > I was struggeling to compile ISO-TP as well (on my Raspi), but then I found
> > this script (it was mentioned in some other mailing list post):
> >
> > 
> https://github.com/hartkopp/can-isotp-modules/blob/master/net/can/make_isotp.sh
> >
> > That worked just fine. Maybe it helps?
> >
> > Best regards,
> > Oliver
> >
> > On 2015-11-03 23:29, Michael Luxen wrote:
> >> Hello Oliver,
> >>
> >> today I've tried to install can-isotp-modules on my BeagleBone Black by
> >>
> >> 1. git clone https://github.com/hartkopp/can-isotp-modules/
> >> 2. cd can-isotp-modules
> >> 3. make
> >>
> >> The make process on my Debian Jessie 8.2 (uname -r: 4.1.6-ti-r16)
> >> powered BBB ends up with:
> >>
> >> root@beaglebone:~/can-isotp-modules# make
> >> make -C /lib/modules/4.1.6-ti-r16/build M=/root/can-isotp-modules
> >> modules TOPDIR=/root/can-isotp-modules
> >> make[1]: Entering directory '/usr/src/linux-headers-4.1.6-ti-r16'
> >>   CC [M]  /root/can-isotp-modules/drivers/net/can/vcan.o
> >> In file included from include/linux/module.h:17:0,
> >>                  from /root/can-isotp-modules/drivers/net/can/vcan.c:44:
> >> /root/can-isotp-modules/drivers/net/can/vcan.c: In function '__check_echo':
> >> include/linux/moduleparam.h:377:61: warning: return from incompatible
> >> pointer type
> >>   static inline type __always_unused *__check_##name(void) { return(p); }
> >>                                                              ^
> >> include/linux/moduleparam.h:428:35: note: in expansion of macro 
> '__param_check'
> >>  #define param_check_bool(name, p) __param_check(name, p, bool)
> >>                                    ^
> >> include/linux/moduleparam.h:145:2: note: in expansion of macro
> >> 'param_check_bool'
> >>   param_check_##type(name, &(value));       \
> >>   ^
> >> include/linux/moduleparam.h:125:2: note: in expansion of macro
> >> 'module_param_named'
> >>   module_param_named(name, name, type, perm)
> >>   ^
> >> /root/can-isotp-modules/drivers/net/can/vcan.c:91:1: note: in
> >> expansion of macro 'module_param'
> >>  module_param(echo, bool, S_IRUGO);
> >>  ^
> >>   CC [M]  /root/can-isotp-modules/drivers/net/can/slcan.o
> >> /root/can-isotp-modules/drivers/net/can/slcan.c:46:24: fatal error:
> >> asm/system.h: No such file or directory
> >>  #include <asm/system.h>
> >>                         ^
> >> compilation terminated.
> >> scripts/Makefile.build:264: recipe for target
> >> '/root/can-isotp-modules/drivers/net/can/slcan.o' failed
> >> make[3]: *** [/root/can-isotp-modules/drivers/net/can/slcan.o] Error 1
> >> scripts/Makefile.build:403: recipe for target
> >> '/root/can-isotp-modules/drivers/net/can' failed
> >> make[2]: *** [/root/can-isotp-modules/drivers/net/can] Error 2
> >> Makefile:1384: recipe for target '_module_/root/can-isotp-modules' failed
> >> make[1]: *** [_module_/root/can-isotp-modules] Error 2
> >> make[1]: Leaving directory '/usr/src/linux-headers-4.1.6-ti-r16'
> >> Makefile:42: recipe for target 'modules' failed
> >> make: *** [modules] Error 2
> >>
> >>
> >> Any idea/hint how to fix this issue?
> >>
> >> Regards
> >> Michael
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-can" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-can" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-can" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: AW: can-isotp-modules

[Oliver Hartkopp]

On 04.11.2015 13:02, Michael Luxen wrote:

> @Oliver H.:
> One proposal from myside, can you please add a can-isotp-module installation process (like it is below) on the GITHUB webside.
> It would be easier for some people (like me) to get the source code running without asking. :-)

Done.

Don't know why I did not had that idea before m)

Thanks,
Oliver

AW: can-isotp-modules

[Michael Luxen]

Hello Oliver,

one additional remark.
Not all preconditions are mentioned in your updated installation process.
On a fresh BBB Debian console image I've to install...

sudo apt-get install linux-headers-$(uname -r)

...before.

Regards
Michael

-----Ursprüngliche Nachricht-----
Von:	Oliver Hartkopp <socketcan@hartkopp.net>
Gesendet:	Mi 04.11.2015 19:33
Betreff:	Re: AW: can-isotp-modules
An:	Michael Luxen <mluxen@gmx.net>; Oliver Pajonk <oliver@pjnk.de>; 
CC:	linux-can-owner@vger.kernel.org; linux-can@vger.kernel.org; 
> On 04.11.2015 13:02, Michael Luxen wrote:
> 
> > @Oliver H.:
> > One proposal from myside, can you please add a can-isotp-module installation 
> process (like it is below) on the GITHUB webside.
> > It would be easier for some people (like me) to get the source code running 
> without asking. :-)
> 
> Done.
> 
> Don't know why I did not had that idea before m)
> 
> Thanks,
> Oliver
>