From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] mpc85xx: Add support for the Varisys Cyrus board
Date: Wed, 4 Nov 2015 10:39:18 -0800 [thread overview]
Message-ID: <563A50D6.8060309@freescale.com> (raw)
In-Reply-To: <1446593406-12671-1-git-send-email-afleming@gmail.com>
On 11/03/2015 03:30 PM, Andy Fleming wrote:
> This board runs a P5020 or P5040 chip, and utilizes
> an EEPROM with similar formatting to the Freescale P5020DS.
>
> Large amounts of this code were developed by
> Adrian Cox <adrian@humboldt dot co dot uk>
>
> Signed-off-by: Andy Fleming <afleming@gmail.com>
> ---
> v2:
> * Cleaned up sys_eeprom.c
> * Removed CONFIG_CMD_ELF, CONFIG_SYS_GENERIC_BOARD
Why do you want to remove CONFIG_SYS_GENERIC_BOARD? We are dropping non-generic
board.
>
> arch/powerpc/cpu/mpc85xx/Kconfig | 4 +
> board/varisys/common/Makefile | 23 ++
> board/varisys/common/eeprom.h | 6 +
> board/varisys/common/sys_eeprom.c | 500 +++++++++++++++++++++++++++++
> board/varisys/cyrus/Kconfig | 13 +
> board/varisys/cyrus/Makefile | 8 +
> board/varisys/cyrus/README | 21 ++
> board/varisys/cyrus/cyrus.c | 116 +++++++
> board/varisys/cyrus/cyrus.h | 11 +
> board/varisys/cyrus/ddr.c | 188 +++++++++++
> board/varisys/cyrus/eth.c | 100 ++++++
> board/varisys/cyrus/law.c | 27 ++
> board/varisys/cyrus/pbi.cfg | 35 +++
> board/varisys/cyrus/pci.c | 23 ++
> board/varisys/cyrus/rcw_p5020_v2.cfg | 11 +
> board/varisys/cyrus/rcw_p5040.cfg | 11 +
> board/varisys/cyrus/tlb.c | 106 +++++++
> configs/Cyrus_P5020_defconfig | 9 +
> configs/Cyrus_P5040_defconfig | 9 +
> include/configs/cyrus.h | 588 +++++++++++++++++++++++++++++++++++
> 20 files changed, 1809 insertions(+)
> create mode 100644 board/varisys/common/Makefile
> create mode 100644 board/varisys/common/eeprom.h
> create mode 100644 board/varisys/common/sys_eeprom.c
> create mode 100644 board/varisys/cyrus/Kconfig
> create mode 100644 board/varisys/cyrus/Makefile
> create mode 100644 board/varisys/cyrus/README
> create mode 100644 board/varisys/cyrus/cyrus.c
> create mode 100644 board/varisys/cyrus/cyrus.h
> create mode 100644 board/varisys/cyrus/ddr.c
> create mode 100644 board/varisys/cyrus/eth.c
> create mode 100644 board/varisys/cyrus/law.c
> create mode 100644 board/varisys/cyrus/pbi.cfg
> create mode 100644 board/varisys/cyrus/pci.c
> create mode 100644 board/varisys/cyrus/rcw_p5020_v2.cfg
> create mode 100644 board/varisys/cyrus/rcw_p5040.cfg
> create mode 100644 board/varisys/cyrus/tlb.c
> create mode 100644 configs/Cyrus_P5020_defconfig
> create mode 100644 configs/Cyrus_P5040_defconfig
> create mode 100644 include/configs/cyrus.h
Please add MAINTAINERS file.
<snip>
> diff --git a/board/varisys/common/sys_eeprom.c b/board/varisys/common/sys_eeprom.c
> new file mode 100644
> index 0000000..086fad2
> --- /dev/null
> +++ b/board/varisys/common/sys_eeprom.c
> @@ -0,0 +1,500 @@
> +/*
> + * Copyright 2006, 2008-2009, 2011 Freescale Semiconductor
> + * York Sun (yorksun at freescale.com)
> + * Haiying Wang (haiying.wang at freescale.com)
> + * Timur Tabi (timur at freescale.com)
> + *
> + * This defines the API for storing board information in the
> + * eeprom. It has been adapted from an earlier version of the
> + * Freescale code for doing the same thing. Therefore it is
> + * nearly identical to the Freescale code, but is intended for
> + * use with Varisys-produced boards.
> + *
> + * SPDX-License-Identifier: GPL-2.0+
> + */
> +
> +#include <common.h>
> +#include <command.h>
> +#include <i2c.h>
> +#include <linux/ctype.h>
> +
> +#include "eeprom.h"
> +
> +#ifdef CONFIG_SYS_I2C_EEPROM_NXID_MAC
> +#define MAX_NUM_PORTS CONFIG_SYS_I2C_EEPROM_NXID_MAC
> +#else
> +#define MAX_NUM_PORTS 8
> +#endif
> +#define NXID_VERSION 0
> +
> +/**
> + * static eeprom: EEPROM layout for NXID formats
> + *
> + * See Freescale application note AN3638 for details.
> + */
This comment and file header still implies this file follows Freescale EEPROM
spec. I think additional comment is needed to state the difference.
There are several blank lines added to the end of files.
York
next prev parent reply other threads:[~2015-11-04 18:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 23:30 [U-Boot] [PATCH v2] mpc85xx: Add support for the Varisys Cyrus board Andy Fleming
2015-11-04 18:39 ` York Sun [this message]
2015-11-04 19:05 ` Andy Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563A50D6.8060309@freescale.com \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.