All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Smalley <sds@tycho.nsa.gov>
To: Paul Moore <paul@paul-moore.com>, Jan Stancek <jstancek@redhat.com>
Cc: selinux@tycho.nsa.gov
Subject: Re: selinux-testsuite: mmap execmod test failure on RHEL6.7 s390x
Date: Wed, 4 Nov 2015 15:49:21 -0500	[thread overview]
Message-ID: <563A6F51.8090109@tycho.nsa.gov> (raw)
In-Reply-To: <CAHC9VhTihxGX=7MPRxP+CQiOeXTqd7BGnhf+XJ10Fx4OwOiLZg@mail.gmail.com>

On 11/04/2015 03:32 PM, Paul Moore wrote:
> On Wed, Nov 4, 2015 at 2:21 PM, Stephen Smalley <sds@tycho.nsa.gov> wrote:
>> selinux-testsuite exercises the individual kernel permission checks using
>> its own privately defined test domains and types, so a failure indicates a
>> kernel bug or a bug in the test policy or test code, not a bug in the
>> distribution policy package.  It could be that a change in the distribution
>> policy has a side effect (e.g. allowing some permission to all domains that
>> we are trying to test such that we cannot trigger a failure, as in this
>> case), but the testsuite tries to work around such cases by setting any
>> necessary global booleans for the test duration and/or custom defining the
>> test domain in such a way that it does not inherit anything from the
>> distribution policy.
>>
>> The exec* checks can be disabled on certain architectures if they default to
>> executable data but that would affect more than just execmod (and s390 does
>> not default to executable data).
>>
>> Can you check that execmod permission is NOT granted to test_no_execmod_t:
>> $ sesearch -AC -s test_no_execmod_t -p execmod
>>
>> Can you confirm that the test program is not marked with executable stack
>> flag:
>> $ execstack -q tests/mmap/mprotect_file_private_execmod
>>
>> Otherwise, I think you need some kernel instrumentation / tracing to see
>> what is happening, particularly the selinux_file_mprotect() function.
>
> I have been working with Jan on this and it appears that the issue is
> due to the READ_IMPLIES_EXEC personality being set on the affected
> s390x kernels.

Hmmm...doesn't explain why only execmod failed - that should create 
failures for multiple tests.

  reply	other threads:[~2015-11-04 20:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1722157580.2900002.1446655193117.JavaMail.zimbra@redhat.com>
2015-11-04 16:49 ` selinux-testsuite: mmap execmod test failure on RHEL6.7 s390x Jan Stancek
2015-11-04 19:21   ` Stephen Smalley
2015-11-04 20:32     ` Paul Moore
2015-11-04 20:49       ` Stephen Smalley [this message]
2015-11-04 21:51         ` Paul Moore
2015-11-05 13:27           ` Jan Stancek
2015-11-05 14:37             ` Stephen Smalley
2015-11-05 15:45               ` Jan Stancek
2015-11-05 16:01                 ` Stephen Smalley
2015-11-05 16:14                   ` Jan Stancek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563A6F51.8090109@tycho.nsa.gov \
    --to=sds@tycho.nsa.gov \
    --cc=jstancek@redhat.com \
    --cc=paul@paul-moore.com \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.