All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Gerhard Wiesinger <lists@wiesinger.com>, kvm@vger.kernel.org
Subject: Re: [PATCH] Fixed KVM problems with old DOS programs. Compatibility can be forced by module parameter.
Date: Wed, 4 Nov 2015 22:27:03 +0100	[thread overview]
Message-ID: <563A7827.8030506@redhat.com> (raw)
In-Reply-To: <563A5D7D.4080201@wiesinger.com>



On 04/11/2015 20:33, Gerhard Wiesinger wrote:
> Signed-off-by: Gerhard Wiesinger <lists@wiesinger.com>
> ---
>  arch/x86/kvm/svm.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
> index 2f9ed1f..e0b00fc 100644
> --- a/arch/x86/kvm/svm.c
> +++ b/arch/x86/kvm/svm.c
> @@ -198,6 +198,10 @@ static bool npt_enabled;
>  static int npt = true;
>  module_param(npt, int, S_IRUGO);
>  +/* allow backward compatibility with e.g. old DOS application */
> +static int npt_task_switch_emulation = true;
> +module_param(npt_task_switch_emulation, int, S_IRUGO);
> +
>  /* allow nested virtualization in KVM/SVM */
>  static int nested = true;
>  module_param(nested, int, S_IRUGO);
> @@ -1177,6 +1181,9 @@ static void init_vmcb(struct vcpu_svm *svm, bool
> init_event)
>      if (npt_enabled) {
>          /* Setup VMCB for Nested Paging */
>          control->nested_ctl = 1;
> +        if (!npt_task_switch_emulation) {
> +            clr_intercept(svm, INTERCEPT_TASK_SWITCH);
> +        }
>          clr_intercept(svm, INTERCEPT_INVLPG);
>          clr_exception_intercept(svm, PF_VECTOR);
>          clr_cr_intercept(svm, INTERCEPT_CR3_READ);

What is the problem you are seeing?  KVM can emulate task switches; the
intercept is set here because of a processor erratum that can mess them
up even though, in theory, AMD supports task switching from guest mode.

Paolo

  reply	other threads:[~2015-11-04 21:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-04 19:33 [PATCH] Fixed KVM problems with old DOS programs. Compatibility can be forced by module parameter Gerhard Wiesinger
2015-11-04 21:27 ` Paolo Bonzini [this message]
2015-11-04 21:33   ` Gerhard Wiesinger
2015-11-04 22:04     ` Paolo Bonzini
2015-11-05 16:07       ` Gerhard Wiesinger
2015-11-05 16:15         ` Paolo Bonzini
2015-11-05 16:19           ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563A7827.8030506@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lists@wiesinger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.