All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: <qemu-devel@nongnu.org>
Cc: qemu-trivial@nongnu.org, afaerber@suse.de
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] object_new_with_type: remove redundant code
Date: Thu, 5 Nov 2015 14:24:01 +0800	[thread overview]
Message-ID: <563AF601.20104@cn.fujitsu.com> (raw)
In-Reply-To: <1446700754-16219-1-git-send-email-caoj.fnst@cn.fujitsu.com>

sorry for this, I am wrong at removing type_initialize.
please forget it

On 11/05/2015 01:19 PM, Cao jin wrote:
> g_assert & type_initialize are called in object_initialize_with_type
>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
>   qom/object.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/qom/object.c b/qom/object.c
> index fc6e161..43ac2dd 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -423,9 +423,6 @@ Object *object_new_with_type(Type type)
>   {
>       Object *obj;
>
> -    g_assert(type != NULL);
> -    type_initialize(type);
> -
>       obj = g_malloc(type->instance_size);
>       object_initialize_with_type(obj, type->instance_size, type);
>       obj->free = g_free;
>

-- 
Yours Sincerely,

Cao Jin


WARNING: multiple messages have this Message-ID (diff)
From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH] object_new_with_type: remove redundant code
Date: Thu, 5 Nov 2015 14:24:01 +0800	[thread overview]
Message-ID: <563AF601.20104@cn.fujitsu.com> (raw)
In-Reply-To: <1446700754-16219-1-git-send-email-caoj.fnst@cn.fujitsu.com>

sorry for this, I am wrong at removing type_initialize.
please forget it

On 11/05/2015 01:19 PM, Cao jin wrote:
> g_assert & type_initialize are called in object_initialize_with_type
>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
>   qom/object.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/qom/object.c b/qom/object.c
> index fc6e161..43ac2dd 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -423,9 +423,6 @@ Object *object_new_with_type(Type type)
>   {
>       Object *obj;
>
> -    g_assert(type != NULL);
> -    type_initialize(type);
> -
>       obj = g_malloc(type->instance_size);
>       object_initialize_with_type(obj, type->instance_size, type);
>       obj->free = g_free;
>

-- 
Yours Sincerely,

Cao Jin

  reply	other threads:[~2015-11-05  6:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05  5:19 [Qemu-trivial] [PATCH] object_new_with_type: remove redundant code Cao jin
2015-11-05  5:19 ` [Qemu-devel] " Cao jin
2015-11-05  6:24 ` Cao jin [this message]
2015-11-05  6:24   ` Cao jin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563AF601.20104@cn.fujitsu.com \
    --to=caoj.fnst@cn.fujitsu.com \
    --cc=afaerber@suse.de \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.