From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [v2] KVM: VMX: Fix commit which broke PML Date: Thu, 5 Nov 2015 09:20:30 +0100 Message-ID: <563B114E.1090601@redhat.com> References: <1446615965-3898-1-git-send-email-kai.huang@linux.intel.com> <5639F34F.9070206@redhat.com> <563AB91F.6080802@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: Kai Huang , guangrong.xiao@linux.intel.com, kvm@vger.kernel.org Return-path: Received: from mail-wi0-f170.google.com ([209.85.212.170]:34212 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030562AbbKEIUh (ORCPT ); Thu, 5 Nov 2015 03:20:37 -0500 Received: by wikq8 with SMTP id q8so5326910wik.1 for ; Thu, 05 Nov 2015 00:20:35 -0800 (PST) In-Reply-To: <563AB91F.6080802@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/11/2015 03:04, Kai Huang wrote: > > Thanks for applying! I am really sorry that I forgot to delete the line > that clears SECONDARY_EXEC_ENABLE_PML bit in vmx_disable_pml, which is > renamed to vmx_destroy_pml_buffer now. > It won't impact functionality but to make the function consistent, would > you also do below? Sorry for such negligence! > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index 89f4fa2..ef4ca76 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -7826,8 +7826,6 @@ static void vmx_destroy_pml_buffer(struct vcpu_vmx > *vmx) > ASSERT(vmx->pml_pg); > __free_page(vmx->pml_pg); > vmx->pml_pg = NULL; > - > - vmcs_clear_bits(SECONDARY_VM_EXEC_CONTROL, > SECONDARY_EXEC_ENABLE_PML); > } No problem. I haven't yet pushed to kvm/next, so I can change this commit. Thanks for the quick response. Paolo