All of lore.kernel.org
 help / color / mirror / Atom feed
From: Caesar Wang <wxt@rock-chips.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
	Eduardo Valentin <edubezval@gmail.com>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the thermal-soc tree
Date: Thu, 5 Nov 2015 18:22:00 +0800	[thread overview]
Message-ID: <563B2DC8.1080900@rock-chips.com> (raw)
In-Reply-To: <20151105160113.5d6f73f7@canb.auug.org.au>



在 2015年11月05日 13:01, Stephen Rothwell 写道:
> Hi Eduardo,
>
> After merging the thermal-soc tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/thermal/rockchip_thermal.c: In function 'rockchip_thermal_suspend':
> drivers/thermal/rockchip_thermal.c:641:2: error: implicit declaration of function 'pinctrl_pm_select_sleep_state' [-Werror=implicit-function-declaration]
>    pinctrl_pm_select_sleep_state(dev);
>    ^
> drivers/thermal/rockchip_thermal.c: In function 'rockchip_thermal_resume':
> drivers/thermal/rockchip_thermal.c:679:2: error: implicit declaration of function 'pinctrl_pm_select_default_state' [-Werror=implicit-function-declaration]
>    pinctrl_pm_select_default_state(dev);
>    ^

That's indeed wonder that I build up in next-kernel-v4.3, applied into 
chromium v3.14 stable kernel.

from the log I guess wee need the include file:
"#include <linux/pinctrl/consumer.h>"


>
> Caused by commit
>
>    7e38a5b1daa1 ("thermal: rockchip: support the sleep pinctrl state to avoid glitches")
>
> Probably just a missing include file.
>
> I have reverted that commit for today.
>
>
>

-- 
Yours,
Caesar

  reply	other threads:[~2015-11-05 10:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05  5:01 linux-next: build failure after merge of the thermal-soc tree Stephen Rothwell
2015-11-05 10:22 ` Caesar Wang [this message]
2015-11-09 19:17   ` Eduardo Valentin
  -- strict thread matches above, loose matches on Subject: below --
2019-05-13  1:02 Stephen Rothwell
2019-05-13 15:57 ` Guenter Roeck
2015-12-31  1:53 Stephen Rothwell
2015-12-31 17:01 ` Srinivas Pandruvada
2015-03-04  7:06 Stephen Rothwell
2015-03-04 19:01 ` Eduardo Valentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563B2DC8.1080900@rock-chips.com \
    --to=wxt@rock-chips.com \
    --cc=edubezval@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.