All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrei LUTAS <vlutas@bitdefender.com>
To: Jan Beulich <JBeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Razvan Cojocaru <rcojocaru@bitdefender.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: Getting the XSAVE size from userspace
Date: Thu, 5 Nov 2015 13:35:04 +0200	[thread overview]
Message-ID: <563B3EE8.9050908@bitdefender.com> (raw)
In-Reply-To: <563B42CE02000078000B2145@prv-mh.provo.novell.com>

On 11/5/2015 12:51 PM, Jan Beulich wrote:
>>>> On 05.11.15 at 11:49, <andrew.cooper3@citrix.com> wrote:
>> On 05/11/15 10:42, Jan Beulich wrote:
>>>>>> On 05.11.15 at 10:52, <rcojocaru@bitdefender.com> wrote:
>>>> I need to get the XSAVE size from userspace. The easiest way seems to be
>>>> to use the XEN_DOMCTL_getvcpuextstate hypercall, but that hypercall is
>>>> not public / there's no xenctrl.h wrapper for it.
>>> Before going into any detail of the rest of your mail - any reason you
>>> can't just consult CPUID output?
>> It depends on precisely what you want.
>>
>> CPUID.0xD[0].ecx gives you the maximum xsave area on this processor
>> CPUID.0xD[0].ebx gives you the current size for the value in xcr0, but
>> that is not very useful from userspace.
> Why would the maximum size not be sufficient for most (all?) user
> mode purposes?
>
> Jan
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>
Hello,

The use-case is the following: whenever an EPT violation is triggered 
inside a monitored VM, the introspection logic needs to know how many 
bytes were accessed (read/written). This is done by inspecting the 
faulting instruction and directly inferring the size, which is not 
straight-forward for XSAVE/XRSTOR family. Using the maximum possible 
size is wrong, as in any given moment the OS may or may not desire to 
XSAVE/XRSTOR the entire state (and thinking that the instruction tries 
to access more than it actually does may yield undesired effects). 
Therefore, the size needed for the currently enabled features of the 
monitored guest is required instead. Normally, it could be done by 
running CPUID with eax = 0xD and ecx = i, where i >= 2 and XCR0[i] is 1 
(XCR0 belongs to the monitored guest), but I am unsure if using CPUID 
this way would be safe/desired: will Xen expose the same CPUID features, 
for XSAVE related functionality, on all VMs? (using XCPUID with eax = 
0xD and ecx = 0 would give us the needed size for the SVA, and like I 
said, using the maximum size would not be safe, even if it's the same 
across all VMs on a given host). Also, I'm unsure how this would get 
along with migration...

Thanks,
Andrei.

  reply	other threads:[~2015-11-05 11:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05  9:52 Getting the XSAVE size from userspace Razvan Cojocaru
2015-11-05 10:42 ` Jan Beulich
2015-11-05 10:47   ` Razvan Cojocaru
2015-11-05 10:52     ` Jan Beulich
2015-11-05 10:53     ` Andrew Cooper
2015-11-05 10:49   ` Andrew Cooper
2015-11-05 10:51     ` Jan Beulich
2015-11-05 11:35       ` Andrei LUTAS [this message]
2015-11-05 11:44         ` Andrew Cooper
2015-11-05 12:26           ` Razvan Cojocaru
2015-11-05 14:05             ` Andrew Cooper
2015-11-05 14:13               ` Razvan Cojocaru

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563B3EE8.9050908@bitdefender.com \
    --to=vlutas@bitdefender.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=rcojocaru@bitdefender.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.