From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ross Lagerwall <ross.lagerwall@citrix.com>
Subject: Re: [PATCH v1 07/11] xsplice: Implement payload loading
Date: Thu, 5 Nov 2015 11:51:53 +0000
Message-ID: <563B42D9.3080208@citrix.com>
References: <1446574568-9644-1-git-send-email-ross.lagerwall@citrix.com>
	<1446574568-9644-7-git-send-email-ross.lagerwall@citrix.com>
	<20151104222118.GA25657@char.us.oracle.com>
	<563B3F0902000078000B20FF@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <563B3F0902000078000B20FF@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Stefano Stabellini <stefano.stabellini@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 11/05/2015 10:35 AM, Jan Beulich wrote:
>>>> On 04.11.15 at 23:21, <konrad.wilk@oracle.com> wrote:
>>> +int xsplice_perform_rela(struct xsplice_elf *elf,
>>> +                         struct xsplice_elf_sec *base,
>>> +                         struct xsplice_elf_sec *rela)
>>> +{
>>> +    Elf64_Rela *r;
>>> +    int symndx, i;
>>
>> unsigned int
>>
>>> +    uint64_t val;
>>> +    uint8_t *dest;
>>> +
>>
>> Can you double check that rela->sec-sh_entsize is not zero first?
>
> Perhaps not just not zero, but at least a certain minimum? Or even
> equaling some sizeof()?
>

Well it only makes sense if rela->sec-sh_entsize == sizeof(Elf64_Rela) 
so that is what I shall check for.

-- 
Ross Lagerwall