Re: [PATCH v1 05/11] elf: Add relocation types to elfstructs.h

[Ross Lagerwall <ross.lagerwall@citrix.com>]

On 11/05/2015 10:38 AM, Jan Beulich wrote:
>>>> On 03.11.15 at 19:16, <ross.lagerwall@citrix.com> wrote:
>> --- a/xen/include/xen/elfstructs.h
>> +++ b/xen/include/xen/elfstructs.h
>> @@ -348,6 +348,27 @@ typedef struct {
>>   #define	ELF64_R_TYPE(info)	((info) & 0xFFFFFFFF)
>>   #define ELF64_R_INFO(s,t) 	(((s) << 32) + (u_int32_t)(t))
>>
>> +/* x86-64 relocation types */
>> +#define R_X86_64_NONE		0	/* No reloc */
>> +#define R_X86_64_64		1	/* Direct 64 bit  */
>> +#define R_X86_64_PC32		2	/* PC relative 32 bit signed */
>> +#define R_X86_64_GOT32		3	/* 32 bit GOT entry */
>> +#define R_X86_64_PLT32		4	/* 32 bit PLT address */
>> +#define R_X86_64_COPY		5	/* Copy symbol at runtime */
>> +#define R_X86_64_GLOB_DAT	6	/* Create GOT entry */
>> +#define R_X86_64_JUMP_SLOT	7	/* Create PLT entry */
>> +#define R_X86_64_RELATIVE	8	/* Adjust by program base */
>> +#define R_X86_64_GOTPCREL	9	/* 32 bit signed pc relative
>> +					   offset to GOT */
>> +#define R_X86_64_32		10	/* Direct 32 bit zero extended */
>> +#define R_X86_64_32S		11	/* Direct 32 bit sign extended */
>> +#define R_X86_64_16		12	/* Direct 16 bit zero extended */
>> +#define R_X86_64_PC16		13	/* 16 bit sign extended pc relative */
>> +#define R_X86_64_8		14	/* Direct 8 bit sign extended  */
>> +#define R_X86_64_PC8		15	/* 8 bit sign extended pc relative */
>> +
>> +#define R_X86_64_NUM		16
>
> Since the set isn't complete anyway - any reason not to drop
> everything that's of no relevance to xSplice?
>

I copied these definitions from Linux (wrongly) assuming that they were 
complete. I shall remove the unused ones.

-- 
Ross Lagerwall