All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@codeaurora.org>
To: Sinan Kaya <okaya@codeaurora.org>,
	Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
	cov@codeaurora.org, jcm@redhat.com,
	Doug Gilbert <dgilbert@interlog.com>,
	"James E.J. Bottomley" <JBottomley@odin.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] scsi: fix compiler warning for sg
Date: Thu, 5 Nov 2015 09:25:11 -0600	[thread overview]
Message-ID: <563B74D7.5090505@codeaurora.org> (raw)
In-Reply-To: <563B7180.2000405@codeaurora.org>

Sinan Kaya wrote:
 >
 >
 > #define MULDIV(X,MUL,DIV)    mult_frac64(X, MUL, DIV)

Why bother with the macro at all? Just change the code to use do_div() 
directly. It's possible that the original code was written before 
do_div() became standard, or the developer didn't know about, which is 
why we have this macro in the first place.

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.

  reply	other threads:[~2015-11-05 15:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05  4:46 [PATCH 1/4] scsi: mpt2sas: try 64 bit DMA when 32 bit DMA fails Sinan Kaya
2015-11-05  4:46 ` [PATCH 2/4] scsi: mpt3sas: " Sinan Kaya
2015-11-05  4:46 ` [PATCH 3/4] scsi: fix compiler warning for sg Sinan Kaya
2015-11-05  5:39   ` kbuild test robot
2015-11-05  5:39     ` kbuild test robot
2015-11-05  6:40   ` kbuild test robot
2015-11-05  6:40     ` kbuild test robot
2015-11-05  6:51   ` kbuild test robot
2015-11-05  6:51     ` kbuild test robot
2015-11-05  8:48   ` Andy Shevchenko
2015-11-05 15:10     ` Sinan Kaya
2015-11-05 15:25       ` Timur Tabi [this message]
2015-11-05 18:07       ` Andy Shevchenko
2015-11-05 18:32         ` Sinan Kaya
2015-11-05 19:31           ` Andy Shevchenko
2015-11-05 19:56             ` Andy Shevchenko
2015-11-05 20:16               ` Sinan Kaya
2015-11-09  1:17               ` Sinan Kaya
2015-11-05  4:46 ` [PATCH 4/4] scsi: mptxsas: offload IRQ execution Sinan Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563B74D7.5090505@codeaurora.org \
    --to=timur@codeaurora.org \
    --cc=JBottomley@odin.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=cov@codeaurora.org \
    --cc=dgilbert@interlog.com \
    --cc=jcm@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=okaya@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.