All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <jbacik@fb.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] efinet: add efinet_multicast_filter command
Date: Thu, 5 Nov 2015 16:17:23 -0500	[thread overview]
Message-ID: <563BC763.1080002@fb.com> (raw)
In-Reply-To: <CAEaD8JP-usrQQhcSc0bqazg4T_WNdKkN4XBr3GF4MkEhU9Q_jg@mail.gmail.com>

On 11/05/2015 03:28 PM, Vladimir 'phcoder' Serbinenko wrote:
> I don't have EFI spec under my hand now. Can we get away with making it
> a default or at least for the case when no interface overrides mac
> address. Extra config to workaround firmware bugs is usually harmful
>

http://wiki.phoenix.com/wiki/index.php/EFI_SIMPLE_NETWORK_PROTOCOL

That is what I've been using.  The thing I worry about is that this is 
just the multicast address for ipv6.  There's a wikipedia page that 
lists about 15 addresses for different things.  Now how many do we care 
about for grub?  I have no idea.  I _think_ that we only really care 
about multicast traffic for ipv6 router advertisements, I can't think of 
when else we'd want to use it.  So in that sense I think it would be ok 
to do this.  But I have no way of knowing what would break in current 
working configurations which is why I went with the config option.  I 
can test with the variety of hardware I have here and see how it does 
with it set by default.  It's up to you, I'm good either way.  Thanks,

Josef


  reply	other threads:[~2015-11-05 21:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05 19:23 [PATCH] efinet: add efinet_multicast_filter command Josef Bacik
2015-11-05 20:28 ` Vladimir 'phcoder' Serbinenko
2015-11-05 21:17   ` Josef Bacik [this message]
2015-11-05 23:47     ` Vladimir 'phcoder' Serbinenko
2015-11-06 18:42       ` Andrei Borzenkov
2015-11-06 18:47         ` Vladimir 'phcoder' Serbinenko
2015-11-07  6:08           ` Andrei Borzenkov
2015-11-10 18:33   ` Josef Bacik
2015-11-06  4:15 ` Andrei Borzenkov
2015-11-06 14:12   ` Josef Bacik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563BC763.1080002@fb.com \
    --to=jbacik@fb.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.