From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZuRug-0005Pi-Kc for mharc-grub-devel@gnu.org; Thu, 05 Nov 2015 16:17:42 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44353) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuRud-0005PK-SZ for grub-devel@gnu.org; Thu, 05 Nov 2015 16:17:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZuRuY-0002jZ-TV for grub-devel@gnu.org; Thu, 05 Nov 2015 16:17:39 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:48483) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuRuY-0002jD-NE for grub-devel@gnu.org; Thu, 05 Nov 2015 16:17:34 -0500 Received: from pps.filterd (m0001255.ppops.net [127.0.0.1]) by mx0b-00082601.pphosted.com (8.15.0.59/8.15.0.59) with SMTP id tA5LD7Tq004244 for ; Thu, 5 Nov 2015 13:17:32 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fb.com; h=subject : to : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=facebook; bh=rnqNykfyBd9d+TTxO5O5f1VT06tIoXPihOuhcsssPVI=; b=g2yUNYJrLtaq8vl5PEjIv9sRM0+Da1pTKmpVhNKfqV8v2AgYgnHX0QUELaroKRlPL5ij JEp5hX3Qzvow3v96czOKwe2ELQH4s05aBCQCcSCmrEpeIjeNPWZFbujmfLHySB2YuBow +cgYNKisd1M1XbiD4js3pMs3580POYpG09I= Received: from mail.thefacebook.com ([199.201.64.23]) by mx0b-00082601.pphosted.com with ESMTP id 1xxfbqmnfj-1 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT) for ; Thu, 05 Nov 2015 13:17:32 -0800 Received: from localhost.localdomain (192.168.52.123) by mail.thefacebook.com (192.168.16.21) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 5 Nov 2015 13:17:25 -0800 Subject: Re: [PATCH] efinet: add efinet_multicast_filter command To: The development of GNU GRUB References: <1446751432-2184661-1-git-send-email-jbacik@fb.com> From: Josef Bacik Message-ID: <563BC763.1080002@fb.com> Date: Thu, 5 Nov 2015 16:17:23 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.52.123] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2015-11-05_14:, , signatures=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 67.231.153.30 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Nov 2015 21:17:40 -0000 On 11/05/2015 03:28 PM, Vladimir 'phcoder' Serbinenko wrote: > I don't have EFI spec under my hand now. Can we get away with making it > a default or at least for the case when no interface overrides mac > address. Extra config to workaround firmware bugs is usually harmful > http://wiki.phoenix.com/wiki/index.php/EFI_SIMPLE_NETWORK_PROTOCOL That is what I've been using. The thing I worry about is that this is just the multicast address for ipv6. There's a wikipedia page that lists about 15 addresses for different things. Now how many do we care about for grub? I have no idea. I _think_ that we only really care about multicast traffic for ipv6 router advertisements, I can't think of when else we'd want to use it. So in that sense I think it would be ok to do this. But I have no way of knowing what would break in current working configurations which is why I went with the config option. I can test with the variety of hardware I have here and see how it does with it set by default. It's up to you, I'm good either way. Thanks, Josef