From: Daniel Walker <danielwa@cisco.com>
To: Scott Wood <scottwood@freescale.com>
Cc: Jia Hongtao <B38951@freescale.com>,
Kumar Gala <galak@kernel.crashing.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@lists.ozlabs.org,
"David Beazley (dbeazley)" <dbeazley@cisco.com>,
"xe-kernel@external.cisco.com" <xe-kernel@external.cisco.com>
Subject: Re: powerpc/fsl-pci: Unify pci/pcie initialization code
Date: Thu, 5 Nov 2015 15:16:25 -0800 [thread overview]
Message-ID: <563BE349.6080100@cisco.com> (raw)
In-Reply-To: <1446765154.12676.132.camel@freescale.com>
On 11/05/2015 03:12 PM, Scott Wood wrote:
> On Thu, 2015-11-05 at 10:48 -0800, Daniel Walker wrote:
>> Hi,
>>
>> 905e75c46dba5f3061049277e4eb7110beedba43:arch/powerpc/platforms/85xx/mpc85xx_ads.c
>>
>>
>> This commit seems to cause problems with PCI devices doing DMA, just
>> with mpc85xx ads. If you do the "fsl_add_bridge()" after you setup the
>> ppc_md.pci_exclude_device to mpc85xx_exclude_device, then the
>> early_read_config_word() calls in
>> arch/powerpc/sysdev/fsl_pci.c:setup_pci_cmd() are like no-ops.
>>
>> This issue was found by David Beazley (on the CC), he can respond to
>> more detailed questions on it. The fix he came up with was to remove the
>> "pci_exclude_device".
>>
>> Daniel
> OK, please send a patch.
>
I was hoping Jia Hongtao could address why it wasn't address in the
original patch. Some of the other boards also have an exclude function,
and I wonder if those work with this change.
Daniel
next prev parent reply other threads:[~2015-11-05 23:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 18:48 powerpc/fsl-pci: Unify pci/pcie initialization code Daniel Walker
2015-11-05 23:12 ` Scott Wood
2015-11-05 23:16 ` Daniel Walker [this message]
2015-11-05 23:40 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563BE349.6080100@cisco.com \
--to=danielwa@cisco.com \
--cc=B38951@freescale.com \
--cc=benh@kernel.crashing.org \
--cc=dbeazley@cisco.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=scottwood@freescale.com \
--cc=xe-kernel@external.cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.