From: Timur Tabi <timur@codeaurora.org>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: andre.przywara@arm.com, Linus Walleij <linus.walleij@linaro.org>,
Andrew.Jackson@arm.com, rmk+kernel@arm.linux.org.uk,
jun.nie@linaro.or, linux-serial@vger.kernel.org,
Greg Kroah-Hartman <greg@kroah.com>,
jslaby@suse.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] tty: amba-pl011: add options to earlycon for 32-bit reg access
Date: Thu, 5 Nov 2015 20:00:27 -0600 [thread overview]
Message-ID: <563C09BB.9030706@codeaurora.org> (raw)
In-Reply-To: <563C07C8.9060506@hurleysoftware.com>
Peter Hurley wrote:
> Perhaps I wasn't clear enough in my previous comments regarding this
> approach; I see no benefit to re-using the pl011 earlycon definition.
> Just define a completely new earlycon for sbsa32 (and zte):
>
> EARLYCON_DECLARE(sbsa32, sbsa32_early_console_setup);
>
> Example:
> earlycon=sbsa32,0x3ced1000
Sounds like six of one, half-dozen of another. But I'm happy to modify
my patch accordingly. It will avoid the strcmp, but I'm not sure it
will reduce the actual number of lines of code.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
WARNING: multiple messages have this Message-ID (diff)
From: timur@codeaurora.org (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] tty: amba-pl011: add options to earlycon for 32-bit reg access
Date: Thu, 5 Nov 2015 20:00:27 -0600 [thread overview]
Message-ID: <563C09BB.9030706@codeaurora.org> (raw)
In-Reply-To: <563C07C8.9060506@hurleysoftware.com>
Peter Hurley wrote:
> Perhaps I wasn't clear enough in my previous comments regarding this
> approach; I see no benefit to re-using the pl011 earlycon definition.
> Just define a completely new earlycon for sbsa32 (and zte):
>
> EARLYCON_DECLARE(sbsa32, sbsa32_early_console_setup);
>
> Example:
> earlycon=sbsa32,0x3ced1000
Sounds like six of one, half-dozen of another. But I'm happy to modify
my patch accordingly. It will avoid the strcmp, but I'm not sure it
will reduce the actual number of lines of code.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
next prev parent reply other threads:[~2015-11-06 2:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 0:37 [PATCH] tty: amba-pl011: add options to earlycon for 32-bit reg access Timur Tabi
2015-11-06 0:37 ` Timur Tabi
2015-11-06 1:52 ` Peter Hurley
2015-11-06 1:52 ` Peter Hurley
2015-11-06 2:00 ` Timur Tabi [this message]
2015-11-06 2:00 ` Timur Tabi
2015-11-06 2:44 ` Peter Hurley
2015-11-06 2:44 ` Peter Hurley
2015-11-06 18:59 ` Timur Tabi
2015-11-06 18:59 ` Timur Tabi
2015-11-07 22:36 ` Peter Hurley
2015-11-07 22:36 ` Peter Hurley
2015-11-07 23:02 ` Russell King - ARM Linux
2015-11-07 23:02 ` Russell King - ARM Linux
2015-11-07 23:31 ` Timur Tabi
2015-11-07 23:31 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563C09BB.9030706@codeaurora.org \
--to=timur@codeaurora.org \
--cc=Andrew.Jackson@arm.com \
--cc=andre.przywara@arm.com \
--cc=greg@kroah.com \
--cc=jslaby@suse.com \
--cc=jun.nie@linaro.or \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.