From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH v7 20/35] dimm: get mapped memory region from DIMMDeviceClass->get_memory_region Date: Fri, 6 Nov 2015 10:50:55 +0800 Message-ID: <563C158F.1080804@linux.intel.com> References: <1446455617-129562-1-git-send-email-guangrong.xiao@linux.intel.com> <1446455617-129562-21-git-send-email-guangrong.xiao@linux.intel.com> <20151105172953.GP4180@thinpad.lan.raisama.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: vsementsov@virtuozzo.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net To: Eduardo Habkost Return-path: In-Reply-To: <20151105172953.GP4180@thinpad.lan.raisama.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 11/06/2015 01:29 AM, Eduardo Habkost wrote: > On Mon, Nov 02, 2015 at 05:13:22PM +0800, Xiao Guangrong wrote: > [...] >> static MemoryRegion *pc_dimm_get_memory_region(DIMMDevice *dimm) >> { >> - return host_memory_backend_get_memory(dimm->hostmem, &error_abort); >> + Error *local_err = NULL; >> + MemoryRegion *mr; >> + >> + mr = host_memory_backend_get_memory(dimm->hostmem, &local_err); >> + >> + /* >> + * plug a pc-dimm device whose backend memory was not properly >> + * initialized? >> + */ >> + assert(!local_err && mr); > > I don't know if you are going to remove the errp parameter in the next > version, but if you want to simply abort in case an error is reported by > a function, you can use &error_abort. > Thank you, Eduardo! let's happily drop the unused errp parameter in host_memory_backend_get_memory in the next version. :) From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuXDI-0000nH-EE for qemu-devel@nongnu.org; Thu, 05 Nov 2015 21:57:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZuXDD-0006t5-BC for qemu-devel@nongnu.org; Thu, 05 Nov 2015 21:57:16 -0500 Received: from mga11.intel.com ([192.55.52.93]:54616) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuXDD-0006ss-5k for qemu-devel@nongnu.org; Thu, 05 Nov 2015 21:57:11 -0500 References: <1446455617-129562-1-git-send-email-guangrong.xiao@linux.intel.com> <1446455617-129562-21-git-send-email-guangrong.xiao@linux.intel.com> <20151105172953.GP4180@thinpad.lan.raisama.net> From: Xiao Guangrong Message-ID: <563C158F.1080804@linux.intel.com> Date: Fri, 6 Nov 2015 10:50:55 +0800 MIME-Version: 1.0 In-Reply-To: <20151105172953.GP4180@thinpad.lan.raisama.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 20/35] dimm: get mapped memory region from DIMMDeviceClass->get_memory_region List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: vsementsov@virtuozzo.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net On 11/06/2015 01:29 AM, Eduardo Habkost wrote: > On Mon, Nov 02, 2015 at 05:13:22PM +0800, Xiao Guangrong wrote: > [...] >> static MemoryRegion *pc_dimm_get_memory_region(DIMMDevice *dimm) >> { >> - return host_memory_backend_get_memory(dimm->hostmem, &error_abort); >> + Error *local_err = NULL; >> + MemoryRegion *mr; >> + >> + mr = host_memory_backend_get_memory(dimm->hostmem, &local_err); >> + >> + /* >> + * plug a pc-dimm device whose backend memory was not properly >> + * initialized? >> + */ >> + assert(!local_err && mr); > > I don't know if you are going to remove the errp parameter in the next > version, but if you want to simply abort in case an error is reported by > a function, you can use &error_abort. > Thank you, Eduardo! let's happily drop the unused errp parameter in host_memory_backend_get_memory in the next version. :)