From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZuYRP-0003DC-Et for mharc-grub-devel@gnu.org; Thu, 05 Nov 2015 23:15:55 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53123) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuYRN-0003Cg-JX for grub-devel@gnu.org; Thu, 05 Nov 2015 23:15:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZuYRI-00035Q-Fa for grub-devel@gnu.org; Thu, 05 Nov 2015 23:15:53 -0500 Received: from mail-lb0-x235.google.com ([2a00:1450:4010:c04::235]:34487) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuYRI-00034m-7R for grub-devel@gnu.org; Thu, 05 Nov 2015 23:15:48 -0500 Received: by lbbwb3 with SMTP id wb3so49648296lbb.1 for ; Thu, 05 Nov 2015 20:15:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type:content-transfer-encoding; bh=2hrhUXeQp/XMIwLOY9CT0vYTcS0Y4HAEljVupaPPyXA=; b=ARS7fjha6DJLiZzqxsNjahsCs/egUVVODAi9ZDJehBlF2530dpIyHr1jdUGPEISUkd 3Z33yzXxtz29UohsDf/RRlLgO1OMA3Mso8HZxpwcSQI5bvFkNrkMTfYRUIph1dgYZaRU clwHrf/1BNLB5PvKNFgxPFJZ/LeDl4tTH2mi6NamDI2xy/dGtqaHQ5vgVeARduTnewIu Z4ShuwsiZWPfD2B8UgYUWSGV+UpHAKP7Z3PGbYUejZ7Fvg9BJXh5OAhMMxCw8IWwk2s9 Fd2SqZ4DK7XlaE1gjsDnKV/JP25GZ3ff3T+OBE1BXEJNXnuuwJfkGSpf4HQaBUxjTJOv CuFQ== X-Received: by 10.112.64.41 with SMTP id l9mr5884808lbs.32.1446783346773; Thu, 05 Nov 2015 20:15:46 -0800 (PST) Received: from [192.168.1.41] (ppp91-76-25-247.pppoe.mtu-net.ru. [91.76.25.247]) by smtp.gmail.com with ESMTPSA id xt6sm1420147lbb.25.2015.11.05.20.15.45 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Nov 2015 20:15:45 -0800 (PST) Subject: Re: [PATCH] efinet: add efinet_multicast_filter command To: grub-devel@gnu.org References: <1446751432-2184661-1-git-send-email-jbacik@fb.com> From: Andrei Borzenkov Message-ID: <563C2971.5090705@gmail.com> Date: Fri, 6 Nov 2015 07:15:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1446751432-2184661-1-git-send-email-jbacik@fb.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::235 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Nov 2015 04:15:54 -0000 05.11.2015 22:23, Josef Bacik пишет: > We have some hardware that doesn't honor > EFI_SIMPLE_NETWORK_RECEIVE_PROMISCUOUS_MULTICAST properly so we aren't getting You mean that driver advertises promiscuous multicast support but does not implement it? Can you add debugging to efi_call_6 (net->receive_filters, net, filters, 0, 0, 0, NULL); whether it fails. May be need set each one separately and fall back to promiscuous. > RA's that are multicasted properly (our switches respond to solicitations with a > multicast rather than a unicast). Could you send packet trace? > I don't want to add this filtering by > default, so add a new command to allow a user to specify a multicast receive > filter. We use it like this > I do not think we need any IPv4 multicasts; for IPv6 we need all nodes and solicited address. But I would like to understand first whether receive_filters fail and we ignore it or it succeeds.