All of lore.kernel.org
 help / color / mirror / Atom feed
From: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, x86@kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Stephane Eranian <eranian@gmail.com>,
	Russell King <linux@arm.linux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Subject: Re: [RFC PATCH 0/3]perf/core: extend perf_reg and perf_sample_regs_intr
Date: Fri, 6 Nov 2015 12:57:17 +0530	[thread overview]
Message-ID: <563C5655.3000605@linux.vnet.ibm.com> (raw)
In-Reply-To: <20151105130716.GC3604@twins.programming.kicks-ass.net>



On Thursday 05 November 2015 06:37 PM, Peter Zijlstra wrote:
> On Thu, Nov 05, 2015 at 02:16:15AM +0530, Madhavan Srinivasan wrote:
>> Second patch updates struct arch_misc_reg for arch/powerpc with pmu registers
>> and adds offsetof macro for the same. It extends perf_reg_value()
>> to use reg idx to decide on struct to return value from.
> Why; what's in those regs?

Was out and did not have access to mail, so missed to respond in time.

In current implementation of patch 2, have added 
few pmu control/status and counter registers,
which give additional information about the PMU context
for the sample.

These pmu registers are not relevant for ptrace and did not
want to overload pt_regs struct.

Adding these arch specific regs in perf_regs will break the "arch
neutral" part, and
other arch can also use this new struct in perf_regs to add more data
using perf_sample_regs_intr without extending the pt_regs.

Maddy

WARNING: multiple messages have this Message-ID (diff)
From: maddy@linux.vnet.ibm.com (Madhavan Srinivasan)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 0/3]perf/core: extend perf_reg and perf_sample_regs_intr
Date: Fri, 6 Nov 2015 12:57:17 +0530	[thread overview]
Message-ID: <563C5655.3000605@linux.vnet.ibm.com> (raw)
In-Reply-To: <20151105130716.GC3604@twins.programming.kicks-ass.net>



On Thursday 05 November 2015 06:37 PM, Peter Zijlstra wrote:
> On Thu, Nov 05, 2015 at 02:16:15AM +0530, Madhavan Srinivasan wrote:
>> Second patch updates struct arch_misc_reg for arch/powerpc with pmu registers
>> and adds offsetof macro for the same. It extends perf_reg_value()
>> to use reg idx to decide on struct to return value from.
> Why; what's in those regs?

Was out and did not have access to mail, so missed to respond in time.

In current implementation of patch 2, have added 
few pmu control/status and counter registers,
which give additional information about the PMU context
for the sample.

These pmu registers are not relevant for ptrace and did not
want to overload pt_regs struct.

Adding these arch specific regs in perf_regs will break the "arch
neutral" part, and
other arch can also use this new struct in perf_regs to add more data
using perf_sample_regs_intr without extending the pt_regs.

Maddy

  parent reply	other threads:[~2015-11-06  7:28 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-04 20:46 [RFC PATCH 0/3]perf/core: extend perf_reg and perf_sample_regs_intr Madhavan Srinivasan
2015-11-04 20:46 ` Madhavan Srinivasan
2015-11-04 20:46 ` [RFC PATCH 1/3] perf/core: extend perf_regs to include arch specific regs Madhavan Srinivasan
2015-11-04 20:46   ` Madhavan Srinivasan
2015-11-04 20:46   ` Madhavan Srinivasan
2015-11-04 20:46 ` [RFC PATCH 2/3]perf/powerpc: update macros and add regs to arch_misc_reg struct Madhavan Srinivasan
2015-11-04 20:46   ` Madhavan Srinivasan
2015-11-04 20:46   ` Madhavan Srinivasan
2015-11-04 20:46 ` [RFC PATCH 3/3]perf/powerpc: Functions to update arch_misc_regs Madhavan Srinivasan
2015-11-04 20:46   ` Madhavan Srinivasan
2015-11-05 13:07 ` [RFC PATCH 0/3]perf/core: extend perf_reg and perf_sample_regs_intr Peter Zijlstra
2015-11-05 13:07   ` Peter Zijlstra
2015-11-06  2:58   ` Sukadev Bhattiprolu
2015-11-06  2:58     ` Sukadev Bhattiprolu
2015-11-06  7:47     ` Madhavan Srinivasan
2015-11-06  7:47       ` Madhavan Srinivasan
2015-11-06  9:39       ` Michael Ellerman
2015-11-06  9:39         ` Michael Ellerman
2015-11-06  7:27   ` Madhavan Srinivasan [this message]
2015-11-06  7:27     ` Madhavan Srinivasan
2015-11-06  9:24     ` Peter Zijlstra
2015-11-06  9:24       ` Peter Zijlstra
2015-11-06 10:04       ` Michael Ellerman
2015-11-06 10:04         ` Michael Ellerman
2015-11-06 10:25         ` Peter Zijlstra
2015-11-06 10:25           ` Peter Zijlstra
2015-11-07  4:29           ` Madhavan Srinivasan
2015-11-07  4:29             ` Madhavan Srinivasan
2015-11-10  0:21           ` Michael Ellerman
2015-11-10  0:21             ` Michael Ellerman
2015-11-07  4:28         ` Madhavan Srinivasan
2015-11-07  4:28           ` Madhavan Srinivasan
2015-11-05 14:42 ` Stephane Eranian
2015-11-05 14:42   ` Stephane Eranian
2015-11-06  7:33   ` Madhavan Srinivasan
2015-11-06  7:33     ` Madhavan Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563C5655.3000605@linux.vnet.ibm.com \
    --to=maddy@linux.vnet.ibm.com \
    --cc=acme@kernel.org \
    --cc=benh@kernel.crashing.org \
    --cc=catalin.marinas@arm.com \
    --cc=eranian@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=peterz@infradead.org \
    --cc=sukadev@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=will.deacon@arm.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.