From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Zuc2A-0005dk-IU for mharc-qemu-trivial@gnu.org; Fri, 06 Nov 2015 03:06:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58646) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zuc28-0005ZT-Ao for qemu-trivial@nongnu.org; Fri, 06 Nov 2015 03:06:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zuc27-0000hN-C1 for qemu-trivial@nongnu.org; Fri, 06 Nov 2015 03:06:04 -0500 Received: from isrv.corpit.ru ([86.62.121.231]:44479) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zuc22-0000gp-8z; Fri, 06 Nov 2015 03:05:58 -0500 Received: from [192.168.88.2] (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id 8F55E40B3A; Fri, 6 Nov 2015 11:05:57 +0300 (MSK) Message-ID: <563C5F65.6020807@msgid.tls.msk.ru> Date: Fri, 06 Nov 2015 11:05:57 +0300 From: Michael Tokarev Organization: Telecom Service, JSC User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Paolo Bonzini , qemu-devel@nongnu.org References: <1446644927-8764-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1446644927-8764-1-git-send-email-pbonzini@redhat.com> OpenPGP: id=804465C5 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 86.62.121.231 Cc: qemu-trivial@nongnu.org, eblake@redhat.com, armbru@redhat.com, crobinso@redhat.com Subject: Re: [Qemu-trivial] [PATCH v2] qemu-sockets: do not test path with access() before unlinking X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Nov 2015 08:06:05 -0000 04.11.2015 16:48, Paolo Bonzini wrote: > Using access() is a time-of-check/time-of-use race condition. It is > okay to use them to provide better error messages, but that is pretty > much it. Applied to -trivial, thanks! /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zuc26-0005Y0-4r for qemu-devel@nongnu.org; Fri, 06 Nov 2015 03:06:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zuc22-0000gv-IR for qemu-devel@nongnu.org; Fri, 06 Nov 2015 03:06:02 -0500 Message-ID: <563C5F65.6020807@msgid.tls.msk.ru> Date: Fri, 06 Nov 2015 11:05:57 +0300 From: Michael Tokarev MIME-Version: 1.0 References: <1446644927-8764-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1446644927-8764-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] qemu-sockets: do not test path with access() before unlinking List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, armbru@redhat.com, crobinso@redhat.com 04.11.2015 16:48, Paolo Bonzini wrote: > Using access() is a time-of-check/time-of-use race condition. It is > okay to use them to provide better error messages, but that is pretty > much it. Applied to -trivial, thanks! /mjt