All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Cao jin <caoj.fnst@cn.fujitsu.com>, =qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, afaerber@suse.de
Subject: Re: [Qemu-trivial] [PATCH] object_new_with_type: remove redundant code
Date: Fri, 06 Nov 2015 11:11:01 +0300	[thread overview]
Message-ID: <563C6095.5000503@msgid.tls.msk.ru> (raw)
In-Reply-To: <1446700614-16138-1-git-send-email-caoj.fnst@cn.fujitsu.com>

05.11.2015 08:16, Cao jin wrote:
> g_assert & type_initialize are called in object_initialize_with_type

object_new_with_type() is a separate QOM API function.  If we're
to rely on other functions calling it to check for parameters,
we should probably remove it from public API and make it static.

And yes, I'm aware of the fact that currently object_new_with_type()
is only called from object_initialize_with_type().  This is not a
good reason to drop the check/init, since object_new_with_type()
remains a published API and might be used in other places in the
future.

Thanks,

/mjt


  reply	other threads:[~2015-11-06  8:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05  5:16 [Qemu-trivial] [PATCH] object_new_with_type: remove redundant code Cao jin
2015-11-06  8:11 ` Michael Tokarev [this message]
2015-11-06 11:28   ` Cao jin
  -- strict thread matches above, loose matches on Subject: below --
2015-11-05  5:19 Cao jin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563C6095.5000503@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc==qemu-devel@nongnu.org \
    --cc=afaerber@suse.de \
    --cc=caoj.fnst@cn.fujitsu.com \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.